From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BFCFCF9C5B for ; Mon, 23 Sep 2024 07:48:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79CF66B007B; Mon, 23 Sep 2024 03:48:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74CD16B0083; Mon, 23 Sep 2024 03:48:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63A806B0085; Mon, 23 Sep 2024 03:48:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 470C36B007B for ; Mon, 23 Sep 2024 03:48:31 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A61521C69C2 for ; Mon, 23 Sep 2024 07:48:30 +0000 (UTC) X-FDA: 82595225580.28.556954D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 123274000E for ; Mon, 23 Sep 2024 07:48:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lkst6L7r; spf=pass (imf07.hostedemail.com: domain of jarkko@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727077649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8rxXpFW6BNtOfD+JqInDd0LqR937jznZjZuFvZ6u51Y=; b=d9ljivRcMHpKx6VUrVpDa1k7im/h/afu4M0pZCNXJpNUpkhAzoqL/nl47iPWUiN/rb2LlB tWYO7bHsKh2wJLgCeGLRt14IJiFxrn0xEZ7dZCVQeVY/vq2eFmo0fOTXKNVVgBYR8XEgfu ED/dNdOKMiWOd643uk3uiDXAsxvN3aI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lkst6L7r; spf=pass (imf07.hostedemail.com: domain of jarkko@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727077649; a=rsa-sha256; cv=none; b=M/ySHz+RIJyYzRN2VCuORVfP8fYcA72vUnvC7GNzpdpv7T1XQxb/XbDnQ6sN8Y2sKdVTJZ 8AsBffpkcZdzsBt6eO/9AaC8XO3kO6nkRUZqCYTWHGX5RVVJW9ey3DFrfgj5kUzjH0JGVR vi6Cg5W86Cxcc0//JSmyrVD+TOJik6Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1DF07A416E1; Mon, 23 Sep 2024 07:48:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51C58C4CEC4; Mon, 23 Sep 2024 07:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727077707; bh=8rxXpFW6BNtOfD+JqInDd0LqR937jznZjZuFvZ6u51Y=; h=Date:Subject:From:To:References:In-Reply-To:From; b=lkst6L7rnoICjE9Y4i9sxfUBcAr6l/A9eiqKQ28FdPXpGycdH7pN/iVuJCvRWuBsH L3WCMoUClNhZoiF92Xcxd/qWrPIM92TcANI+vcp2WAIr8xFS3cmxWoL2W9JaOxjjYZ RLIu3l58mPqqhH/rMD1fQZmJkexMS7V6EL8kkIvph4sZNnVKgKG39WirASYzUYtlS4 y8idgrNnQjTXg4DwnOBCLxO15ifeKZaukxyeTMduLcLKxprZ1x3IArWKpJOWkY762A qVWyS9p0u2TsWH9ehGt1GS61bpYgTurwhScBwZZOyyauokYTihNKWhVgAvyl8BQrYg 9vxUiW0PeEJsA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 23 Sep 2024 10:48:23 +0300 Message-Id: Subject: Re: VMA merging updateds? From: "Jarkko Sakkinen" To: "Jarkko Sakkinen" , "Jarkko Sakkinen" , , X-Mailer: aerc 0.18.2 References: In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 123274000E X-Stat-Signature: fc11jxihsnsf7fenameeii368rxhxa7f X-HE-Tag: 1727077708-580589 X-HE-Meta: U2FsdGVkX19d83BW9zsKCO27g6o0dKRsIVr+o+JmIwS6s00cWO4pqUqriBUSbgogZAmGPlHKSS5l1c+DrU+cYJRt1Hk3uf0lST/Ii1vriAjFsYPqBgC8Qb3V5YYNIBrBynA0KefQI/nKuKSHiBiesXPccOfc6TETmDVhg3/VqeEs7Cdt0cZtW/LRHhF++4uZY6zt/lqfHhu+NetCULDovBQ8/LUoqx+6fpUgWjtljj7SgGfSZ/pKfsEoBMf7QA8KkCjWeoNSJk9wzQICoDPDHoc0fv6tst8kPqzPCM6DRa7c9gwjnhAHSbSp5tpyB9vGD9Sqj5reclkKBIIuSdiPD+AS7O1Y+8IpwDmv+6X/yevuN/Ct01AU48Ia5O3psFJWaQFt1rCUqT+P5H6FPY4VxxTj1hIcIH2FIizngqsnkAgel/61Wb4IcinAHomMh5b/xiwKwc0IOk0e3mt+ygQNaRdLtDyQiX138V5Wo+7IFHFhFUo1WRZRKNTGQ6c/c9Qo2paLNjvALeWKHWK5RzdoLLkPu68x57VbJnDrHWlecy9J/EhISnP1AyhEiUHONVrRKRYo9PN6Y7XIKbsFgJIqFB3WKXQuPMHgeKGsxo6xRUZJyB2r8CWpFX3XkCqNS3El6I3oZDbyeaAPwCGubjWZ5e+9VtvTmUJvPuI1fhnIQOetSYz9uW3r1Nhxbwf0NL1NsG+vYMjB/n3H3gzUEcEj6A/FKz4VV9m/uAfyRjYd8w1LvHkfMPwVn4UTLC5nUmDzcwTmfPNADzjc09Qa6+BB7xLMj8uAD7DU7JMu8yAkv/jGwN3TcjvhY4lXrSRw2DDg8MdyRG2eyBivoznji4o6yTxvCUD1/rbwJ2GwIOzIrDSp8z9gtTUwNv6nuw48Ur5lYBUFJaqWQGwcMGqZWl61lC5dDIO79c1ZiJ8gPg5mwee0hBGwNh66gVxX2+5ZrxE4xfKyBJpsQlZZkK4SXog zD17zu3j MYg1kLr67xafqzLzaHGGugUepuYR0kaDGjkW12dHglH1GSeCSK5JdHijcqs1+alpAmjIPHtuxc4Z2EMGgebhXf/mKqoDyZIwOgaBprf0BTGPzUAVmv5dp9QRaYpsVgap5CEKqJft+4vrcuXn1sAcF16UFJbFCShOgOlXXPyKV7L51dCmW4DU/F64/vTPnEcUCh9GR3+wiC+Lj/CUNm8S0xuGZI2Jyc4NRJi8cBADIOLbEkB0/XNZ0SGSfmI9aenWmGUs7nZrMcflQWzuNfs0MZW/aGaf3Xy89VuMqbay4xgK7N9OvQ3dObmRgTctY1OIjd1H2HZVvMWJGB2I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002238, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun Sep 22, 2024 at 7:57 PM EEST, Jarkko Sakkinen wrote: > > On Sun Sep 22, 2024 at 7:27 PM EEST, Jarkko Sakkinen wrote: > > > Hi > > > > > > I started to look into this old issue with mm subsystem and SGX, i.e. > > > can we make SGX VMA's to merge together? > > > > > > This demonstrates the problem pretty well: > > > > > > https://lore.kernel.org/linux-sgx/884c7ea454cf2eb0ba2e95f7c25bd420188= 24f97.camel@kernel.org/ > > > > > > It was result of brk() syscall being applied a few times. > > Briging some context here. This can be fixed in the run-time by book > keeping the ranges and doing unmapping/mapping. I guess this goes > beyond what mm should support? > > I thought to plain check this as it has been two years since my last > query on topic (if we could improve either the driver or mm somehow). In the past I've substituted kernel's mm merge code with user space replacement: https://github.com/enarx/mmledger/blob/main/src/lib.rs It's essentially a reimplementation of al stuff that goes into=20 mm/mmap.c's vma_merge(). I cannot recall anymore whether merges which map over existing ranges were working correctly, i.e. was the issue only concerning adjacent VMA's. What I'm looking here is that can we make some cosntraints that if satisfied by the pfnmap code, it could leverage the code from vma_merge(). Perhaps by making explicit call to vma_merge()? I get that implicit use moves too much responsibility to the mm subsystem. BR, Jarkko