From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79070C78828 for ; Fri, 20 Sep 2024 11:35:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB7AA6B0085; Fri, 20 Sep 2024 07:35:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C409A6B0088; Fri, 20 Sep 2024 07:35:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B130F6B0089; Fri, 20 Sep 2024 07:35:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8E7E86B0085 for ; Fri, 20 Sep 2024 07:35:51 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3F6EF1A0272 for ; Fri, 20 Sep 2024 11:35:51 +0000 (UTC) X-FDA: 82584912102.14.A3840E3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 4974180011 for ; Fri, 20 Sep 2024 11:35:49 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fM2OnSX3; spf=pass (imf02.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726832116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rgd71jqRVnSncVSljmf3ZnpC+tAeAB9wnnbgsKk+YhM=; b=OqRTjyr92ZZjwIEoCwPselrnijUTlcNXA+cLgF2bcc4Cx/wI9ARkpEF2ZAnSf6I8INcWdP a6hml14VNYLdQ8y5qVQQk7Ert6koiNt5BJ7lnqSFSfeFPXO7x9NA/gZ1gzCHJthUxwh4tk hx9NXsdCMv+cLdkaU/ng3gVE0YCbRSM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fM2OnSX3; spf=pass (imf02.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726832116; a=rsa-sha256; cv=none; b=kERpTAHtWCUe3dTeq4elw1oxh2BajZgnRzhXiLY6pdZHbxMerk4pLff+RQ4J5Gty1vOyHL e1VAmuaZXTLoeMs0M7ClKjpCucIP3AEPQYigElptFaT6jodo8Cb110WQzMWJBPeg33sTX0 u8gASGyI2VlbXXrbVToGtbvPJXbZl4Q= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8FD0A5C0386; Fri, 20 Sep 2024 11:35:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CF4FC4CEC3; Fri, 20 Sep 2024 11:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726832148; bh=EbTjQgk/7KugYLkubRSV4y03LGYLCfQsZg5hwoWGZyo=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=fM2OnSX3rC+deNekkdTvQ+Arwe7lDLn8On26UqgCf7KcVwGnzJEDv95G78s2Yg8Ic 0NLb00A6A1czFHATmVWOYNWXUlTjYjLTDywli6stQlQ9qdR2nMgjo0d3lm5EeXHG2J SRxdECnbhwWlW0XH+vky4wqtwBeZLZjSLYDpcCo4OSGc0co33RnxB4+mbMMHwbTdj7 5Aeh35PYdeEoPi5UFCq09Gz/bLSHctvQJlUhQ8lDkyI5KmKSIeN0yejIgvf6vti91W k6E5Ioo9aWBV+BwZhIdWzQ8F9lBuYfTXG33YHiREeVNh62SkFDpmMBtgUaCT4tzTQ8 9Kc1PRIKou1qw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Sep 2024 14:35:44 +0300 Message-Id: Cc: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 2/3] mm: memory-failure: move return value documentation to function declaration From: "Jarkko Sakkinen" To: "Shuai Xue" , , , , , , , , , , , , , , , , , X-Mailer: aerc 0.18.2 References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20240920043027.21907-3-xueshuai@linux.alibaba.com> In-Reply-To: <20240920043027.21907-3-xueshuai@linux.alibaba.com> X-Rspam-User: X-Stat-Signature: qh7xoipfqc4fua8mt7kwu5qaiq1z4kzr X-Rspamd-Queue-Id: 4974180011 X-Rspamd-Server: rspam11 X-HE-Tag: 1726832149-511370 X-HE-Meta: U2FsdGVkX1/2Imkx/AfcRRNjPRKAJzyBFRBqjdFSZmhFqYt/lqkbWuy9veHzqdFi5Z+7K9FdAnklRihdYb7sPU/DRDXYsihSSorm6h0/ougC+jV2QvuFmhsX5LIZRP7o1WGy5Ecmo2iZN2074Xi0qygey0QSLIPUjosKVHIgltXb0MrEqJuvlRU5dqo4DHMquZ3hxcCMoq6ZnqisEqFI1pFurlNaG9h5VVhfELOgLn13aqjgvUwyq/g7O7lcsMaRx2TTzzEeRCK5fdXOifdv69ZXZ5yBY+jPUZ0cHE7G+YprMikst+cZDVzhiMRvJ8+cSDQFJe5liL91xMWG4mDRYOFPmo0rQ+IIwHDVVXE3obBScat5JJL8j2COsvkYx0E2czWJt+xzWp1/6/d7zrnvdvfcmAU7Evyd1Fl4wu/VZKxE7amIjNVnOC6/4fs3Bh66pB8ryXqt1fRDcWDTd36zVeyQHH8W8rr3UpOXqiM3FL1aSXXRvzlKJ9Pm6F8LqPhTBxzeunisezH/QjDfnNmCTJ+3FJacr3uaNs3CEuMDbYeW9vM0Gfwb6r1UmqOx2EYX0MtryaGTF06LJiFSNyzNE2Tm79chsSQ1Z2IRi8VTEw5aUe0N4seLzpLVWaUPzuGCFCsQOVQBaWT9EN7OjGAhF/mTxukW5FhczFm9D7rW9gaprlFhVt1SldouesawP4cPMWqsqMGVCpix64bi49GFmbN6f2WXLpa1W/+B8Zz9fKCUUeJ10v1UKfzzQtt0ua1NZwtTqIFZIrIjwiPipPBwBnaGBC8lWE2mMqpiPSYPq5mWvHQdqs4EPSnb3Z4iwLlicvofgJ7sYq6ydLSv9MKA3lV6QQwNOEnW/i52h7Uc4rZlGDZuKnox3ZKalkEOVfe2qRDIu1WCXWyja/eP83FdjH/n4Kwy84k/YR4EDuNgLFbmGgev3yzKUK7SCzVf7XukJwUlfi0bqGaWjz/wx78 A36rU0iK TRdURKrFAdSSqnlkDRUf9loID3lYdt5eAMlVIGA3zoiUKQHWiQY6GNseLfPOzKnevDQomGgsv9CaXCKItTt2UOCjXl3eCj1vkT5glJmsvAX117udbOdOz6MIGfaoEAVVycRUteyLgSsfR7xMqsiyt3ZIbJcpc7L5+C8diZzLpoVXxpB0BqmS6Rr3ottvEJNyTIAFn6aUJ97IrwnmkYpTcfqznxnNjqAS74Z01+RUA3Hlq8iJBkQpxtjJh0Tab8isaPoshj2WthQX41W+iN8fCNij/08cbd78JKU6NW+9uI4r/u4M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri Sep 20, 2024 at 7:30 AM EEST, Shuai Xue wrote: > Part of return value comments for memory_failure() were originally > documented at the call site. Move those comments to the function > declaration to improve code readability and to provide developers with > immediate access to function usage and return information. > > Signed-off-by: Shuai Xue > --- > arch/x86/kernel/cpu/mce/core.c | 7 ------- > mm/memory-failure.c | 9 ++++++--- > 2 files changed, 6 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/cor= e.c > index 2a938f429c4d..c90d8fcd246a 100644 > --- a/arch/x86/kernel/cpu/mce/core.c > +++ b/arch/x86/kernel/cpu/mce/core.c > @@ -1373,13 +1373,6 @@ static void kill_me_maybe(struct callback_head *cb= ) > return; > } > =20 > - /* > - * -EHWPOISON from memory_failure() means that it already sent SIGBUS > - * to the current process with the proper error info, > - * -EOPNOTSUPP means hwpoison_filter() filtered the error event, > - * > - * In both cases, no further processing is required. > - */ > if (ret =3D=3D -EHWPOISON || ret =3D=3D -EOPNOTSUPP) > return; > =20 > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 7066fc84f351..7984e0d99d09 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2199,9 +2199,12 @@ static void kill_procs_now(struct page *p, unsigne= d long pfn, int flags, > * Must run in process context (e.g. a work queue) with interrupts > * enabled and no spinlocks held. > * > - * Return: 0 for successfully handled the memory error, > - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, > - * < 0(except -EOPNOTSUPP) on failure. > + * Return: > + * 0 - success, > + * -EOPNOTSUPP - hwpoison_filter() filtered the error event, > + * -EHWPOISON - the page was already poisoned, potentially > + * kill process, > + * other negative values - failure. > */ > int memory_failure(unsigned long pfn, int flags) > { Reviewed-by: Jarkko Sakkinen BR, Jarkko