From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94E3EC78829 for ; Fri, 20 Sep 2024 11:35:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7A9E6B0082; Fri, 20 Sep 2024 07:35:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2A316B0083; Fri, 20 Sep 2024 07:35:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C18A86B0085; Fri, 20 Sep 2024 07:35:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9F0F86B0082 for ; Fri, 20 Sep 2024 07:35:15 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0C66E1A027C for ; Fri, 20 Sep 2024 11:35:15 +0000 (UTC) X-FDA: 82584910590.27.E81E3AF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 48C97A0028 for ; Fri, 20 Sep 2024 11:35:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BdWgq8SJ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726832101; a=rsa-sha256; cv=none; b=PXx8xuU0W43Vd4BXVkm87mOS1/6Y10TadwvWma0b7p7QJKC0TycM/dZ4qD/gMO4anwEBoy trKePhIQKWeL1pl2+6njSWvoPzWGOEZkUhSSi5E/M41AEGcxxqKEeDJogdNnIZs1tl9YGT wL9KthPJ6KLH863logZQ/hTXP3ilC1o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BdWgq8SJ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726832101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cX5yr23oaVWoX/p9VpwsfowzujVFq1/i0RNZXA7WCSw=; b=fBxtQWKYAcR4Ko6kQrt1Zq8xqCIGZ5yDTFLZOkyQrLzYc347ad4DwoCrVp82IAW4djwL6X r7xvjeH8J8W5lvq00KCYqA+qceGiwJrkiCmzQLYIkhpJyv2e95WS5ELebqPDyHiHK3Ggxm n63mmAN9tH/uLzkfKlEWWWnoLcSG+eI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 242275C5854; Fri, 20 Sep 2024 11:35:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E68DBC4CEC3; Fri, 20 Sep 2024 11:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726832111; bh=zQ5iM5k6GIU+AK5anD56YHmGTiqTiNOqalEcNMllZGo=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=BdWgq8SJ2lfmexGOinqSNJ7KTTER9GBlcMO1r2/mh0d5RvNRQltH0QGldPd83qHqz MAEO0XtNS+tc3F+4ngBm0HC+Ir7xxVhB1HFY+23UH5zRY3w81D70HOt8p2wlKbxfyx y4Mx4h9471GfwaNlK5fxw2BpV6uzeVnk7xPuUBohaE9vJYDmIINz4muvTeg979pqXP adE1/FxhvliYxUSfImsNiuu17FawHKd5MvHJKYtLgzIC7ia+llY9dvr6bkU6GhjUGD 144Oww8VP59IcX8tqiZhCussXXNjpN3ifVblloZFdzKZyS8HGbW9bJqhduYC1iThDy zJm/02/kjuFbA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 20 Sep 2024 14:35:07 +0300 Message-Id: Cc: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 1/3] ACPI: APEI: send SIGBUS to current task if synchronous memory error not recovered From: "Jarkko Sakkinen" To: "Shuai Xue" , , , , , , , , , , , , , , , , , X-Mailer: aerc 0.18.2 References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20240920043027.21907-2-xueshuai@linux.alibaba.com> In-Reply-To: <20240920043027.21907-2-xueshuai@linux.alibaba.com> X-Rspam-User: X-Stat-Signature: ns6rrycpdgmewkqu8norty8y9a6actuz X-Rspamd-Queue-Id: 48C97A0028 X-Rspamd-Server: rspam02 X-HE-Tag: 1726832113-49217 X-HE-Meta: U2FsdGVkX19mZEKCtp1gMm6mCAlVuRVIV8/ZI2lgKluXFlKoHDX/heEn3famdtPVIQ9ANtcxKL0wYqaOb1Ywg0NdBo4wM+YRFgk02kyDqKVgO0Qbs7iJVGJYuaBRENC7fO7epi2+T2c9n9RYLKIH52sDRxAsMgmwR36IuPxZVme5c8UxaMxkl0yoUXmEISFf7dUtoECVyV5Z7+gUGxm+XBrj4HDxz7+6LuhDxeENcRvjAB6MA+ic+f1ob5e/sngMT3bt+pWQ8kC6s/ig6ReBGEtfKNKETUIHcNVWnpbvB1slZ1o9iJj44ffy6cXMk2KmzBk+2FXhsNNXPYLT+FtPL7ocxZxCsWnnLUwuuVBzfOepG0PainLhykVjFprYaYweUb+MtpTHIHjvbKaYjY10/CkfMknafOHl4wjQPSbH7oU2xcxxtVaN92JInRFcd81+wDZppGUkuipurL+gKAokeiBz2cHqR6hYMhA2fr5rOdg9yCa2OFgBeWVgFwZDPk8gPtrrxRFGDEkFriYYb1G5/mi8UauiQTyJ1qWhRB3SDxLfklmLIUn811c6rqnU2qruOi3x9/PqaHTPeSW4WPcs2XtUrdlqKHlLDRMe0/P958Pdp0Yxflx0MH+exAZuYvjWnb5E80u1wNUtrpqhzI3wQ1piYVWZw4I0oKIBy8FAifjQigeHZ3zsSaKeYuZYVpz2kIGOoHKdn4BoILEKx/KdxqcWXKYw0j8WncBA9bD8z2JuC5LfTw81WhMQYb9FhJ8X3Y4MuYHxaFd6F4TY8HFFTAW+daPXDPPsBi8+YefkqBiWxAAFMrQaNW2Hv1sNfbfL9nOCtz3tDtksdOhu2C+H3FtjZmUCrOMXfEgs3fD8B+xsNEBVj8jxVNH5/y3Omwi4Or1OmdD9uiVOqCrmQ4kZVrq9ljlfCeihhKJ5dXvS8boBT57qJ/comcdRJa3mGiIS/yBHKhlYsWgzbjR4hxS Rr/kpd5l je/J2vi4z8ABww4QGqnkXGGQNC1o67s2PiFbOBnGCi3e6WWhO+r4p8SHqClGXn60f2d29+890ZW4efSR1DRlcMUQcnpJMd0ASLB3aD9iFJb3fFqK0EOPuVVm/019JJVS50XjlX/JRc2BXp+b/DWh2DXwnJm/G3SmfptNr4wSFcoa//WKNcfKwXhntogrk1y2rz7m7ommggP1Sw6mCIEK3djg9jCWbMaV9KXNyxOc3IM19s+yZGbONL68orSJRvFrK5quG62t/LNZ0UYZxCHN1unZIT4eWnbzbbjeiCgJAnFpzIRs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri Sep 20, 2024 at 7:30 AM EEST, Shuai Xue wrote: > Synchronous error was detected as a result of user-space process accessin= g > a 2-bit uncorrected error. The CPU will take a synchronous error exceptio= n > such as Synchronous External Abort (SEA) on Arm64. The kernel will queue = a > memory_failure() work which poisons the related page, unmaps the page, an= d > then sends a SIGBUS to the process, so that a system wide panic can be > avoided. > > However, no memory_failure() work will be queued when abnormal synchronou= s > errors occur. These errors can include situations such as invalid PA, > unexpected severity, no memory failure config support, invalid GUID > section, etc. In such case, the user-space process will trigger SEA again= . > This loop can potentially exceed the platform firmware threshold or even > trigger a kernel hard lockup, leading to a system reboot. > > Fix it by performing a force kill if no memory_failure() work is queued > for synchronous errors. > > Signed-off-by: Shuai Xue > --- > drivers/acpi/apei/ghes.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c > index 623cc0cb4a65..93eb11482832 100644 > --- a/drivers/acpi/apei/ghes.c > +++ b/drivers/acpi/apei/ghes.c > @@ -801,6 +801,16 @@ static bool ghes_do_proc(struct ghes *ghes, > } > } > =20 > + /* > + * If no memory failure work is queued for abnormal synchronous > + * errors, do a force kill. > + */ > + if (sync && !queued) { > + pr_err("%s:%d: hardware memory corruption (SIGBUS)\n", > + current->comm, task_pid_nr(current)); > + force_sig(SIGBUS); > + } > + > return queued; > } > =20 Looks good to me! Reviewed-by: Jarkko Sakkinen BR, Jarkko