From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4782C77B7C for ; Fri, 26 May 2023 05:17:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F20896B0074; Fri, 26 May 2023 01:17:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED0F56B0075; Fri, 26 May 2023 01:17:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D978A900002; Fri, 26 May 2023 01:17:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CA3606B0074 for ; Fri, 26 May 2023 01:17:49 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8ECDFC0CF5 for ; Fri, 26 May 2023 05:17:49 +0000 (UTC) X-FDA: 80831249058.07.B3A851A Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf24.hostedemail.com (Postfix) with ESMTP id 9C55E18000D for ; Fri, 26 May 2023 05:17:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="ULmbK/tl"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685078267; a=rsa-sha256; cv=none; b=xJNt7/R/t70yHvKP5qgiGXga1a53YtPjrKr9rqaQAsxtOGw9m6T+u7enqhTrE2wlzSqrHJ lrpTQjBwYk0gG5jP2ykVbeVT6RSkXrg/PlfMaiybFKx3WwiaY6GnWHq6Y86DqywhCH9aWN JoiYHnw22u1C7LR0PZQ2I138+o9n3jI= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b="ULmbK/tl"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685078267; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fWf9VwGyh647NTiZdevjn4fWRBDqPDisfVmvbRXRIfk=; b=wxQw+YZ6ZJEOicRPWYpeMgFiBoGglbTAD6KS5wusMOYNbhpNaAmbTVmIRMaj0vpLSpfYVR hBzCV8sYf/cdnYqPoRhnfdLVLey1S51xPSMajjJGxSoEtFPHLjiHOgBW4ZFn4SYMOX3lAC mVlgsnfpkAp0Io9ZDN2QUeTl1lxPqEw= Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-52867360efcso221110a12.2 for ; Thu, 25 May 2023 22:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685078266; x=1687670266; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fWf9VwGyh647NTiZdevjn4fWRBDqPDisfVmvbRXRIfk=; b=ULmbK/tlKpbG/0OYco5YqPz07KIeDGI392FrGQRRd5X/sGjlpCo4a87yBNW3cxtNbA W2eYVMaA2t0pOuXYqusBOn/RwRPfdTIvejBaNMhhow4WD5DWff30clr+pstQlXKttF/K y0XmmaqFR1A4GwpJGrzCyMMEfj/9kU1JV9qnr0dpR5r1F3wkHhws67vA2GZ6UfapwjSE cErl93ME80cFsBEwELelONHD/9FJXi6kqG7eMqMfQsHbSRWhOGG0S9nARk0sNKBS8RIe kAMfkfj91SW23srcdehbzbdpr8egtZf+vNR56trcxRm/x4dP1fjuuPgWYf/o64BehtCO +0jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685078266; x=1687670266; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fWf9VwGyh647NTiZdevjn4fWRBDqPDisfVmvbRXRIfk=; b=KsBKUeJcVv+Eu/+VnCVjsBt8ePtApacs2/47V43jhlSBYa6QfMg+wZRUop5efqJU1W eDXpq3X3IuDcaKjxtDFmOaNkzWMSBdMjUwsKh9pIgbLrrt5VXkY+733tnYv/tVGChkAp OaXnJf3/Rlh4JPvs05VuoJdyk3RJF5MzcUh8tVYVnKjbUsT8GMKmfcOHA+DNMSP+wdMd 09zPkSgBzuLp1mkx7JyXnBveW8rxVe0ux8BxbZs6Cjet2VBA27p9hjg1E5Arq7J6Hs+F 7cf6bT1R6qsgeGTAg1mUeaQdlGkeQTZ6mvb2Bcouz0nX6uWYM5SubzLyLFgEnhiRxj2L p92w== X-Gm-Message-State: AC+VfDy+8gkb+PqS/03oOIo+Rryp2nx55atUpyPrZp+zb4h1awR0dYEh q2US2cEwEWxiWpBplqPzaXA= X-Google-Smtp-Source: ACHHUZ6qj8+GYjFiOMejIOa+jxY/i8dC6DUy4jM2Qp7p/YGG0jjxM9Arj0MHjzHoPktoq+Tu9JxGCA== X-Received: by 2002:a17:902:7788:b0:1a8:ce:afd1 with SMTP id o8-20020a170902778800b001a800ceafd1mr1218262pll.20.1685078265673; Thu, 25 May 2023 22:17:45 -0700 (PDT) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id x2-20020a170902820200b001afd821c057sm2278222pln.58.2023.05.25.22.17.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 May 2023 22:17:45 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: [PATCH v2 2/3] compiler: inline does not imply notrace From: Nadav Amit In-Reply-To: <20230525222844.6a0d84f8@rorschach.local.home> Date: Thu, 25 May 2023 22:17:33 -0700 Cc: Arnd Bergmann , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, LKML , linux-ia64@vger.kernel.org, linux-um@lists.infradead.org, Linux-Arch , linux-mm , Andy Lutomirski , Ingo Molnar , Dave Hansen , Borislav Petkov , X86 ML , Peter Zijlstra Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230525210040.3637-1-namit@vmware.com> <20230525210040.3637-3-namit@vmware.com> <20230525222844.6a0d84f8@rorschach.local.home> To: Steven Rostedt X-Mailer: Apple Mail (2.3731.500.231) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9C55E18000D X-Stat-Signature: uwgxpyh5ik4kk5p4b8f4b8ueqdcj9sto X-HE-Tag: 1685078267-10505 X-HE-Meta: U2FsdGVkX1/1QYfULLbdzilHkJ2LDuecF5K1RWRf2DGjWA3mhI+NGOdw76VJ9Ogwi7NKax0la8tb76eJIiAGAb/k/APt+pFFwRH6pX3su3g8Z+GtWwenKWIFB3Cx6aOTh+EAKi8+STHtaIN6S4PsPjuUmqwZCUgVXe3XHYpSHKpDStLZn+2qMaKhMTR+ZSfSaX1SfJ0B7PUCmUBEMKzNdO1GTFp+0NQFNpqDjoHIVLikZy7pqZQ72HivyUAcCrYxpJaQEBSs+V24YXreRH/9udZXR1NIKk1smMgQvDoRlkwqvtTPT7pHbRuQKAeNok0hTgBgcPGTa/NC5Majdru3qR4g6mHlTHqHnmBa18cHgE+f4NlZz/o0sRsW7qiPr7SnrrEYw3C+YfYY7Sh7xxwoClFdHdyBv3eUWP7R+5TZDEHMqsBnYt35cgkRgEr82jo/Lg5vDE4QDLDn0mXsqxbKR2goelO9D5jswQ6pdRsXjsgi80jZ0t4ESuKeHzlW/vpMx1iPB1zBESWmGrCfFaQm4qOBjta5qfjz2iBeANjF1ZuZkTtzMsbKndsL83e6njnoU3cbeCIDUX88q8mPVABIKrC+pWA8jGJ0v+iRSeFrP24C9q1iioDmuG+whN75gipFbOZXHKLMRxJyhiQZHQ1vVtMjWOrQT9SBYxgyIPuza1hxfIk/d8NxmSJyWBs8p9D5nxV6olcRRa8zaFgqPSnT5/h/u47ah45ikYDrNUydmPrDFJIu3gGZuiN8B4NpFTRsqCaFvLw27qdBL+fxxLmHUyKs7+oBXfGDinktONUqh+o5at5wHqKbCllnnI9KfVvgVdLHupZAk9bg7zb69VdQ6Euy7+cUNp1lTga2mP4XSjJ/WZzUn+Tvo0R6LKX/kAv365MgnaD1wtVJOxBsw/iXP0G8Pfs6InU3fkYrjXsnzazI+jik9YV5QrcBswOwworw9uTdHoQp+35Imhy+wVF V3XvwAcq d/P6t8bYUDDOwKr4CRihojCu8cU6ddWxeGp0ybsdcF3x7KmPlEjLm76pnf/9gglo8D35ryrTKMs+obXnDtINmTGSNIVkVT5Bx6osHkr+DlR67zLiqRG+YvqWRYEP4ijDdwoEk9rMLRpCSXrMkKZ90qhlP2QN01Fi6BYMexm/xF6ojpB45UN/HvozrfUuvAU5akkAufOFP82VGdgWxe9KcgtAfYie/Oyt8uTF+yIONGlkA5aAEPba0Ixd3Z9ZycIDT08M0I7QZc8ypBE/pCCmUgA8fs8U/ByxcM9VRktOhwh4zs6tEb2YV2r1vd4RdbL0LsL2Obp7B6V6Md8uhtdwcGNPaiB74INb0SlthUlhMkLqstBr+Kp35ju0SOc6yn2U+VC3FecW0v3KWtLTlUQ0AV37Lub3NPCZkrGPqmo8XAmtna/qdMPG8USk0HHA/5kVP8CIDZUP0tJ6jnLHeRLO8IrTXDkA2dfyccLaZaBLOwFwnXG9AiXcRi+cRXf/Zqj3mrRRkLhgsIvZ38s8/AYNklNuauqYRiJdkq6mB38yDS2MP+RvQ3WAr29GNUoFeeyJ3MA3MXMRCtaEdWtpW7JyXOuxKQgsGG/2ZIvJrJNGBNHxd1fG9PZ5atTAktFDwIoDamDudujIuMqUmLWapL+GOv0HdKA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On May 25, 2023, at 7:28 PM, Steven Rostedt = wrote: >=20 > On Thu, 25 May 2023 14:00:39 -0700 > Nadav Amit wrote: >=20 >> From: Nadav Amit >>=20 >> Functions that are marked as "inline" are currently also not = tracable. >> This limits tracing functionality for many functions for no reason. >> Apparently, this has been done for two reasons. >>=20 >> First, as described in commit 5963e317b1e9d2a ("ftrace/x86: Do not >> change stacks in DEBUG when calling lockdep"), it was intended to >> prevent some functions that cannot be traced from being traced as = these >> functions were marked as inline (among others). >>=20 >> Yet, this change has been done a decade ago, and according to Steven >> Rostedt, ftrace should have improved and hopefully resolved nested >> tracing issues by now. Arguably, if functions that should be traced - >> for instance since they are used during tracing - still exist, they >> should be marked as notrace explicitly. >>=20 >> The second reason, which Steven raised, is that attaching "notrace" = to >> "inline" prevented tracing differences between different configs, = which >> caused various problem. This consideration is not very strong, and = tying >> "inline" and "notrace" does not seem very beneficial. The "inline" >> keyword is just a hint, and many functions are currently not tracable >> due to this reason. >>=20 >> Disconnect "inline" from "notrace". >=20 > FYI, I have a patch queued (still needs to go through testing) that > already does this ;-) >=20 > = https://lore.kernel.org/all/20230502164102.1a51cdb4@gandalf.local.home/ Ugh. If you cc=E2=80=99d me, I wouldn=E2=80=99t bother you during your = vacation. :) I think you may like the first patch in my series to precede this patch though as some of the function I marked as =E2=80=9Cnotrace" are = currently =E2=80=9Cinline=E2=80=9D. Let me know how you want to proceed, so I would know how to break this series.