From: Zi Yan <ziy@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>,
"Huang, Ying" <ying.huang@intel.com>,
linux-mm@kvack.org,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Yang Shi <shy828301@gmail.com>,
David Hildenbrand <david@redhat.com>,
Yin Fengwei <fengwei.yin@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent.
Date: Tue, 18 Jun 2024 15:48:03 -0400 [thread overview]
Message-ID: <D1935798-D0AB-4624-AAAF-660CCFEBDFD9@nvidia.com> (raw)
In-Reply-To: <20240618124417.08745f6c08f6ecb2c959a096@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On 18 Jun 2024, at 15:44, Andrew Morton wrote:
> On Tue, 18 Jun 2024 09:41:51 -0400 Zi Yan <zi.yan@sent.com> wrote:
>
>> From: Zi Yan <ziy@nvidia.com>
>>
>> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to
>> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when
>> calling migrate_pages_batch().
>>
>
> Thanks. I'll add
>
> Fixes: 7262f208ca68 ("mm/migrate: split source folio if it is on deferred split list")
>
> and shall queue it for 6.10-rcX.
>
> Please don't forget such details.
I thought about the Fixes tag. Since Hugh's patch fixes the
BUG_ON and VM_BUG_ON, I did not add it here. But yeah stats inconsistency
is something needs to be fixed. Thanks for adding it.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2024-06-18 19:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 13:41 Zi Yan
2024-06-18 19:44 ` Andrew Morton
2024-06-18 19:48 ` Zi Yan [this message]
2024-06-19 7:25 ` Huang, Ying
2024-06-19 18:13 ` Zi Yan
2024-06-20 1:23 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1935798-D0AB-4624-AAAF-660CCFEBDFD9@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox