From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA61C4345F for ; Tue, 23 Apr 2024 21:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E501C6B0096; Tue, 23 Apr 2024 17:36:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E00016B0189; Tue, 23 Apr 2024 17:36:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF01D6B018A; Tue, 23 Apr 2024 17:36:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B14CB6B0096 for ; Tue, 23 Apr 2024 17:36:34 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 59DA2A1631 for ; Tue, 23 Apr 2024 21:36:31 +0000 (UTC) X-FDA: 82042105782.26.9BF8149 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id B0674140017 for ; Tue, 23 Apr 2024 21:36:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N64hL5x3; spf=pass (imf23.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713908189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=27uuS8XnVeMLCUUMTCLWxfCa12Qrf9Y7FaKiKv4socc=; b=TOUbniaWEopiJAN3tOSRL7so9gjfaQF6+q/4CEehX7+clOErP5np0OT4Y78MA887qJFV0u d2KCo8kuYIB03v1wG6+iD63TvE4ciXAWLC/5Ar0JJfUzzU6L4YetVk6j2MyqJgJKtVhT9D M0hi7hqMNQ6Al0fFu2cOY51AQ9AfBNQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N64hL5x3; spf=pass (imf23.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713908189; a=rsa-sha256; cv=none; b=OjdclJXhztGIFgMMoK+0H/rjRf45NGnTgiD27kqces8bPPESRPjmonZF+1j1QKKLKGcBcH U4pxmIpxORrozDJyE562dvGGFPlboUsD4KYBzkR7Pvlm1zPJg4dRnkUFNVXCOAvBJ2OhvD BxzqWweYJR316kHd5VyVbo56JeN+mdQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8C1C561760; Tue, 23 Apr 2024 21:36:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FA55C116B1; Tue, 23 Apr 2024 21:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713908188; bh=kRU/X/dR1S85QfdEA379AVH9Oh6pbj0vz6VEE2p37BI=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=N64hL5x31SGXexnFBS8oye91xqW8qUmC4XtebvTle1CkwE2vK/QxH5HuvgZAj7qmf mTemwU1pQsIGhRf/RXiaZpSH2CO0ckAqN9UJnW1p/okvqvH9D5+f+iVIIukrx09DK6 EaYnwb8ioGwRK/ewhLyw2d/1wxBNc3DOupbttAw6dJDaAxblnKQIDeDqZPzrRxlid7 3T/jwcpBOYDgbb9S/nCF0rlPn8LyPH39Dgx65fAt0yyFdCY7QS4q6goRSIafjB73HM SrILFGr9P/iu+QHCpBrAuLs08JIOEBf+KTkfWkgm0jYMBca5mzyU2RCpHEj44Qhhtv FZtYXCueW4bSg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 24 Apr 2024 00:36:18 +0300 Message-Id: Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v14 28/22] [SQUASH] KVM: SEV: Provide support for SNP_EXTENDED_GUEST_REQUEST NAE event From: "Jarkko Sakkinen" To: "Michael Roth" , X-Mailer: aerc 0.17.0 References: <20240421180122.1650812-1-michael.roth@amd.com> <20240423162144.1780159-1-michael.roth@amd.com> <20240423162144.1780159-6-michael.roth@amd.com> In-Reply-To: <20240423162144.1780159-6-michael.roth@amd.com> X-Rspamd-Queue-Id: B0674140017 X-Stat-Signature: we6exj4q6y5adczwduegf3xwb5f8t194 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713908189-103210 X-HE-Meta: U2FsdGVkX1+rfSxGjmVXsdbXurv1pOYpt+APv5Bth8k6+BvBLd1BMGbtFFjuGTpmASzDFEgmwnbfRgePnIaeWE5d0joxRllnXmmTcIPqemFrymTz+dPH4xMqJpSRzPxtXeI5cHzf60io9KZYoTO6/eRqLcnVX28kj0Tsrl0pomwmToJLyTHihjQ9Rn0XEh2IOKnjL5CfeXTWcpcDqLx76hae99eFObM49zeZmVCGb6kJZpxhFrHz2WjiNLm0d9w8o3Jn+n3w3bWyuv02mhnc6Df9OUGjT57wG3HUtB/fbDWvHmcyBTxWsJE0tEZHk8k5HQJa0q/Mhm/S5YxF+1yhsv6XDE30ivxGrP7ai3G+y25paA9EO+HmFwxB8XMOb4q79ll+R9BRNxmE6u7fq6DJty1pNXhTxgiLzWJ00N081UIfsWa3zfzMtmN78rY0VNhsqNmRq0zV2XgTye0bwSMrA2Nmz5U2h9MZsjlfQSFRSdKAejE1TMSUz/cuaJZ9o7Xe349TnGrmOle+Gk/UGZAcC8aAGuH2ejE+u8TZFEbD5P7tWVsSn3XFehgXRQJUTpCK4NX/CV9I406bKeBRl6uOLznjgZNzOhHrQF1gxggZRnRjAYhRPAsWqUoVhHqN7xb4LOwhni68WNNV3IYkxG+GdrB5fv650xOXXBBXzBsZoR1i00pM/AFMR1eyUpsMNoMJCWHefZuL77v0e8rlppCj3p/UvYoYJfg5VkiaTUmSY5xAxlpfhI9o1IBhVz/eN3UPp7VjyBVpQDHzALZYrNDgKj1qj5a5fCZ6G/yl6I2IFiNIMHPdy6i/963IBl/gCbtDosp3zfOrtN9jkA1EmLstIULr2KUkAes6yGhrOS1bCs3KoF43OzHTa5v7mQGHrfBMv+hGBasoIiR/+51+HfbBvKYRM4StjZt7IyoZwJCO8w0aXb/Ja8o9Vsx0hJL34HULPr7jVVnpdlsb1qwMaY7 ccdN8SiH fMl/oryYCTxbiarXXTLKDgRhwftgENUmbZdOhLALEFCYf5p6J6/SwYRfOWF1LQEa8z/OxCIE+CbcoHpXzDyJFbZj1yjZqHYoOsy4Gc3cxA9hWiOdBgI6tXnl+4N83kawCpz/ZF6dFf4G+sFliq12FLH+0+7mJq65dSDIU3sUx1fnlGK7bzwI32jYgjTN0DuLZyR8mgt0ZUC7VY8w5juugFOdgis/gxm5bQF0ZP8JW1U/e09jBnBnL3gklXadStfBtJAayl5eeWTRUxRGhFXAs/HKXP2eVN7SZQKLo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue Apr 23, 2024 at 7:21 PM EEST, Michael Roth wrote: > Ensure an error is returned if a non-SNP guest attempts to issue an > Extended Guest Request. Also add input validation for RAX/RBX. > > Signed-off-by: Michael Roth > --- > arch/x86/kvm/svm/sev.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index 2b30b3b0eec8..ff64ed8df301 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -3297,6 +3297,11 @@ static int sev_es_validate_vmgexit(struct vcpu_svm= *svm) > goto vmgexit_err; > break; > case SVM_VMGEXIT_EXT_GUEST_REQUEST: > + if (!sev_snp_guest(vcpu->kvm)) > + goto vmgexit_err; > + if (!kvm_ghcb_rax_is_valid(svm) || > + !kvm_ghcb_rbx_is_valid(svm)) > + goto vmgexit_err; Hmm... maybe I'm ignoring something but why this is not just: if (!sev_snp_guest(vcpu->kvm) || !kvm_ghcb_rax_is_valid(svm) || !kvm_ghcb_rbx_is_valid(svm))) since they branch to the same location. BR, Jarkko