From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184EDC43603 for ; Thu, 5 Dec 2019 22:23:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B7DDD20707 for ; Thu, 5 Dec 2019 22:23:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="cZ6Nlkcx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7DDD20707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3CD646B127A; Thu, 5 Dec 2019 17:23:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 37C766B127B; Thu, 5 Dec 2019 17:23:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 291DC6B127C; Thu, 5 Dec 2019 17:23:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 171046B127A for ; Thu, 5 Dec 2019 17:23:48 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id BAC003D13 for ; Thu, 5 Dec 2019 22:23:47 +0000 (UTC) X-FDA: 76232516094.29.stone29_5b4765394863a X-HE-Tag: stone29_5b4765394863a X-Filterd-Recvd-Size: 4124 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 22:23:47 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id s8so5163783qte.2 for ; Thu, 05 Dec 2019 14:23:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=s9HuZFqazi071tR46CJtidfMMQKEUIWC1jwTBGYP1+w=; b=cZ6NlkcxxGeMFCfa3hNffYbt0adwBZu56/wsfc7GzrfjY7exDtzAzT69JkqoOcFpm8 f/DyD28W+DSoWxWBnipzKKfbHXYFVd1KXHBALe7U92Rlb0TUsWCVWecCbyZNfsdy5b+Q umBbiwYYXAJFbsr4PPSFRGm5XP7lnsOzGREK8bLhFcBl19HybxYqB34HQGQBygroaZYe KTHKnPrku21QGMQky2zEVpbt8qArb3r30PwDE6ztueSyGlJ4chmylOb3WfxksBOp/SdP 88RI15LyNSV036ykGPGm2olovdquCBRFsjwq8Y8+9XHkNtSjyAb5qjPcekWz2+rrhUQ+ omuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=s9HuZFqazi071tR46CJtidfMMQKEUIWC1jwTBGYP1+w=; b=ZSs11TtZ/Q1A7xsDkxxrAx3MdR0a5Ac76nKQRo8mChs82KgT6da6RIu+2bscCE97+v TwCrQLktdh+NhUkt2L6qehX2qEUhbNngeMgnf+G6r7/QDWW4BMGRQClaJ/S07YQRxBDO DjLCb1rpd5oBC6/5d3ZEz5atVw+IztbMDEewP/Vi8i3dI3pS31gVtUEgBLh1lRNmxGRl p5UicuEK1d1oCCTpiogxHAMQN/MBKcJoOTf4VHVJ6BbkmfLAo8XM18C2XQia5oAhrkJW lDWEatQXViw2RCjYOmSyiZLh5gROpySC1hsxNPo66mDaZRs6t8JRxBu7+Q4MTW0N81An +stQ== X-Gm-Message-State: APjAAAUb2wAC//CdT2VcO2+9zSuKmzgr4Vvhk8zWza+bsxiiV+kWRghQ 6KylOgQ4DG9E9J1ZFYXB6eAW1w== X-Google-Smtp-Source: APXvYqx7GJ9s3s0mo7mEDapHflc+9TKM5IVSvrVc5pjmpmXIK6z7WiQr0sZpTn3eRDhYfRmpclVinA== X-Received: by 2002:ac8:43d0:: with SMTP id w16mr10371261qtn.43.1575584626599; Thu, 05 Dec 2019 14:23:46 -0800 (PST) Received: from ?IPv6:2600:1000:b06e:b1cc:9498:2fee:3c1:2a4? ([2600:1000:b06e:b1cc:9498:2fee:3c1:2a4]) by smtp.gmail.com with ESMTPSA id k62sm3911034qkc.95.2019.12.05.14.23.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2019 14:23:46 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [v3 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node Date: Thu, 5 Dec 2019 17:23:44 -0500 Message-Id: References: Cc: fabecassis@nvidia.com, jhubbard@nvidia.com, mhocko@suse.com, cl@linux.com, vbabka@suse.cz, mgorman@techsingularity.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: To: Yang Shi X-Mailer: iPhone Mail (17B111) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 5, 2019, at 5:09 PM, Yang Shi wrote: >=20 > As I said the status return value issue is a regression, but the -ENOENT i= ssue has been there since the syscall was introduced (The visual inspection s= hows so I didn't actually run test against 2.6.x kernel, but it returns 0 fo= r >=3D 3.10 at least). It does need further clarification (doc problem or co= de problem). The question is why we should care about this change of behavior. It is argu= ably you are even trying to fix an ambiguous part of the manpage, but instea= d leave a more obviously one still broken. It is really difficult to underst= and the logical here. >=20 > Michal also noticed several inconsistencies when he was reworking move_pag= es(), and I agree with him that we'd better not touch them without a clear u= secase. It could argue that there is no use case to restore the behavior either.