From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDBCC47072 for ; Wed, 15 Nov 2023 03:26:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B991A6B0329; Tue, 14 Nov 2023 22:26:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B49AB6B032B; Tue, 14 Nov 2023 22:26:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A11476B032C; Tue, 14 Nov 2023 22:26:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 914456B0329 for ; Tue, 14 Nov 2023 22:26:12 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 574C2120194 for ; Wed, 15 Nov 2023 03:26:12 +0000 (UTC) X-FDA: 81458750184.25.8882581 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf27.hostedemail.com (Postfix) with ESMTP id 5918240007 for ; Wed, 15 Nov 2023 03:26:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RMBSVhTz; spf=pass (imf27.hostedemail.com: domain of npiggin@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=npiggin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700018770; a=rsa-sha256; cv=none; b=xpihJIinJC55CUNkncD+CrVMbquPOohqXNX31d/XSq6dvl5WMkaGiDPuZqyJWY4iVRUjft No9GUWTaJVDxVwHfRHuwvj/SsXoKghCwOOA9wBCkNLOJwub+AaIkgJFPWUec40R/LekdjX P/0K33S16Mr0b3B9cgoMQnd8tbGkkr0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RMBSVhTz; spf=pass (imf27.hostedemail.com: domain of npiggin@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=npiggin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700018770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FWp83f3xN+vRZTVZqePAo5Ya5BJKoA3UZKs4+uAYCk4=; b=yVMpLRQ3ZJO0sdqgrikTMrub5yJzV5PMqQITbq+8VPhHvGKHFtVIEtno5B2c/35KTx/JWj HKd5fa2zm7q+mdbAgsfqhCDYwwFgxt15ubi2eFjYXYgFRS/f9bn5ylmtpbmDTAu/AqxX5O kzoSWDNSgds/1eUAobqnJS2ZjpsVEd8= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2809b4d648bso79280a91.2 for ; Tue, 14 Nov 2023 19:26:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700018769; x=1700623569; darn=kvack.org; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FWp83f3xN+vRZTVZqePAo5Ya5BJKoA3UZKs4+uAYCk4=; b=RMBSVhTza/IHvdwpEdF39OGqM28CMqv8AOPkhTPi3XKK4JFDhzKBmr5GmpEbHg3U/R scXPmg0zffLR7R35LYeZ3MMcKXZTlPhq/1Yb0BBlC7nIlfNAx3KNYXrYIv1x0R4euwxJ 7ugnX3CSKqTYLecjVhkVoAIyhXzha+mDXQ1V176P4kFJvz1hyeOS7go1Ge4c4Sd9c9sK fzVIYX+7oILAfIAq2wb0zRWJVk4mvEqOfdC0jnvKxgHsjERnpzpXg1Clf6LfFu25QYqd Pru5Ou6dGkeq8Q4Y4Oem4CV1o9Q3bz4jbc8IpGzqTQlrs6RWZ4xvrLHwbXzdbD8i72B8 FJlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700018769; x=1700623569; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FWp83f3xN+vRZTVZqePAo5Ya5BJKoA3UZKs4+uAYCk4=; b=Z274S7aZ2HHMhddrwt2hfiGT7yu6uWjs1mFmdFR130iDP/xZLaRpeI5IFdlmm9toaE tOwUTFBW9URLplSzBcdMRhCcQUXtIHaW71xRbeRCzU5BmCM7KECquRHHyfPUt3m+CrNa oUmbJ8d4l3+YM/m2eCCYpH2cYpQR8gb2gfHYCdMhzTXe2+m9VZpZ7a6C9d3NgxJ6hwG2 Ykk+pkTy9PZ49KbTLCtmeZjosJNxuCmXtjGbRbp8bsxyIiYPffJbO/Gvk8kzxwcaEJcD cmuAodtTUYjCm+dKDY+meRAjl8/z/byx9tG46xVYvRYgSfU9FM5Uj57lxauEy1sYh/YH Q3nA== X-Gm-Message-State: AOJu0YwTZNsLfWKwg+k+mJXe9oh/oFrG9zPrrYpVJ2gtmornAKfwleHE VtZDObsFXS5+UmEcRWegyRk= X-Google-Smtp-Source: AGHT+IFNMfcHU9K1QYufxxpkJIZl/NZ5ISNR86vQx76QBRQiiG3/oN1R2EBwe5j2ciIyRkooGdBMFA== X-Received: by 2002:a17:90b:17c9:b0:27f:f260:ceaf with SMTP id me9-20020a17090b17c900b0027ff260ceafmr8975188pjb.10.1700018769086; Tue, 14 Nov 2023 19:26:09 -0800 (PST) Received: from localhost ([1.145.207.198]) by smtp.gmail.com with ESMTPSA id ga3-20020a17090b038300b00271c5811019sm5911805pjb.38.2023.11.14.19.25.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 19:26:08 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 15 Nov 2023 13:25:47 +1000 Message-Id: Subject: Re: [PATCH] lazy tlb: consolidate lazy tlb mm switching fix From: "Nicholas Piggin" To: "Christophe Leroy" , "Andrew Morton" Cc: "linuxppc-dev@lists.ozlabs.org" , "linux-mm@kvack.org" , "Sachin Sant" X-Mailer: aerc 0.15.2 References: <20230607005622.583318-1-npiggin@gmail.com> <340b4d49-df81-05ad-3753-c1e60ec0df06@csgroup.eu> In-Reply-To: <340b4d49-df81-05ad-3753-c1e60ec0df06@csgroup.eu> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5918240007 X-Stat-Signature: isb1dbmcerfdm9etnxznid185m4nyi5h X-Rspam-User: X-HE-Tag: 1700018770-778090 X-HE-Meta: U2FsdGVkX1+3klQ6VOveng29V9CQcQbUlBAkZ+6FjPwXFu5WSCNTQioyuxXIHmm9JD5FTA5kUQQzAbqx8MNxi+UPQ5rLBsvhmiCXFo5dSrD45h/HIo57gHMHy3s9eP41KfC3VfHexfsl7HmLifGo6sqkXGh3i769VBnQ+LgKQbvpMT554Im/+wvJO2HNuikJfM6n7VdU6T0dHhjiAOtT9yUylou0UL9B1GvHHShBYJipV4tIfk/jX5zpbaCg+26rOq+8QuU+1FpZGh77I2DxNfoHdOeV569VR3ey+5pHQ1af7rj8jZcnQ8JxKpjRBLaMocwMjhIgN20wf7oiUp+1d+Tv40AtnZ0bDGoH/mkRHr5QwotyejsTNvJPw8N8BC0rjZEEYpNvLqR+xqEMNoK8nNcdbwaCqWbvhAVBMfGQY/9gT55BryJwgnTcceLB35MtbUywrHUhwBz+jvYknBBzhD+bkUKlZrNm5pCgxLyGZHU1PQGqyFyDveyQXQkO5xEQ/vOat7gtyB0phNH3zl1tNxzOmJO0xFJMrT42MrrHisgb0vWhNdCNJBtwVfxun+YA0zjlrIniQ4HzCBIUh02eHEmO3mrcxcpXrxRnPBD5HnMdYBuIUNC+7grA6/czxCq5WHinZPQPEoiKPgmzC+Mf3iFAQwLPv6hNFL7I31HVzfR91S7xGAYUDaCCl4wl7UUaPh4s/W6nG4rrfl4hlK1bxcBSsQhmTDAtppsBvw4I4lHc5tV2dWSWQZc3NQxylwLFIvR3vWyHUTplr4netiQRIc0Nnm/Ll3seW/llWPwjyOdkePSexdkG5vj+f5B+9o8cCbeoqrt58ugFtFW7eUAA7xrivyxac9oA/fuMv+OHihlDgcht+NiARigAMs27cjgHa0eC70NVEKG5vohewkp/iypqLOfxOIbTIZxQLvybz6KlUSCFpAgmUd58omx2PqmwxCy9Qw4J+VOrh0cUCcO ivOeSTjG QpOpwsgof/1fD2sZiBppOxYGTlIGLCCyr7aimLCurajRB1CCqvJjhdifHkziAwT0VQM+SiqJqNfxWCd00aZszb2AKhCheXjm6ylyJtzY0bfEXo7mhJ3E1eau04QRfPlwtNucjXQaLKpWbG2SQ3gDHjmpVkwmGk52mtE9hUKOzBJFf8ch6eJ3o3AQomasXh2dkbeFbFsK1vLLOhyl2jVpIr8r2dnf6AwHH6RM5BRdRBjCq5gI7Wu+hxs/6nWRrK1S4lFgBrDyglrtvLcsUN2r0cyarrUa3DMERrmY+ktFXVePIGcBF7CrraOAJ/TvkB4egQkcQY3OvrB4Gyl91mItgreC1/VMAZETj4kKB+8CZd5emsyVQ3zQFGPoCdbENaCHa8bOU21Cp51yVT8RQ630mYihDB9VvYON01CUC53w2WIITWOinSy/ztxx7L2g89LShtgGJg3ouuORY5dbMF8PYIo9+4h1KJ9zBub0DPMVh1uBVyYCwvwkKECSar/BKTN8POC5TSfE3cxPMqpd+Kx+PgsfTsJ5zEOoI9sQEYc31LW+ekP4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri Oct 13, 2023 at 11:12 PM AEST, Christophe Leroy wrote: > > > Le 07/06/2023 =C3=A0 02:56, Nicholas Piggin a =C3=A9crit=C2=A0: > > Fix an upstream powerpc bug that was discovered with a WARN_ON added in > > "lazy tlb: consolidate lazy tlb mm switching": > >=20 > > Switching mm and tinkering with current->active_mm should be done w= ith > > irqs disabled. There is a path where exit_lazy_flush_tlb can be ca= lled > > with irqs enabled: > >=20 > > exit_lazy_flush_tlb > > flush_type_needed > > __flush_all_mm > > tlb_finish_mmu > > exit_mmap > >=20 > > Which results in the switching being incorrectly with irqs enabled= . > >=20 > > Link: https://lore.kernel.org/linuxppc-dev/87a5xcgopc.fsf@mail.lho= tse/T/#m105488939d0cd9f980978ed2fdeeb89bf731e673 > > Fixes: a665eec0a22e1 ("powerpc/64s/radix: Fix mm_cpumask trimming = race vs k> > >=20 > > I will send that fix upstream, which will end up conflicting with these= . > > The resolution will be to take akpm's side of the merge (with this patc= h). > > Or drop the patch when it conflicts and I'll resend it rebased on the f= ix. > > This seems to badly conflict at the moment, is it still applicable ? Been away, will have to check where all this ended up. Thanks, Nick