From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E3D5C0015E for ; Wed, 19 Jul 2023 13:39:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DF1928005C; Wed, 19 Jul 2023 09:39:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78EC728004C; Wed, 19 Jul 2023 09:39:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6588E28005C; Wed, 19 Jul 2023 09:39:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 59CC628004C for ; Wed, 19 Jul 2023 09:39:44 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 09D6B1A034C for ; Wed, 19 Jul 2023 13:39:44 +0000 (UTC) X-FDA: 81028469088.15.CF6F82D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf20.hostedemail.com (Postfix) with ESMTP id 1B3501C0016 for ; Wed, 19 Jul 2023 13:39:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gaqxW45k; spf=pass (imf20.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689773982; a=rsa-sha256; cv=none; b=UD+dVApkisl47OWTVVE3KnwbMEDFYS/HpLvOTrWt51FrDWfy4QtvBhATZEwhReY6g+o3JP JfHvMEFkoravKXF2RPeSoqzMHo7hvLs1NEjH6Jmpr8fXr+NwNKRTglVFfR33JAjiso2pOm 34m28OxsGgzR8Npx0fm++WCvpEZ729I= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gaqxW45k; spf=pass (imf20.hostedemail.com: domain of jarkko@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689773982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G8TAD6Msm31xfw2I6Ike7pT5Jie2K2DojfPgBuPefWM=; b=LAhfa1j4kaglQlkTJcyGu2Ln2h0s3SXu43docRtZiQavZPSDGElbX/UhjAXaQaa30DcCPH ofKdkhgDrtnSRBke51vPnipD4Tni0k98pcUfCgfLISsvW/dmKDTDtmsfxOy9NUiKqBWURj k3i4+UqnlCgSKhp243GP9pIieQKOcIM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1A793616F1; Wed, 19 Jul 2023 13:39:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 507F6C433C8; Wed, 19 Jul 2023 13:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689773980; bh=KIb7q+NtNE+KBfEiNJ0Q3nOHxWMm45lA4WVZ9SwBWF8=; h=Date:Cc:Subject:From:To:References:In-Reply-To:From; b=gaqxW45kGtoKFnDNNv629brjH/mey+u1zrY+JTYF+Xct1aygG1J4Cf6N5TAdbyf95 2UQ3DpMsJY9gZ/ErtakGGWIqjwaqOwsKcm2y3YVSYVrxM+2RWzCuF6bzEjT83PpAcr AGyWDI+pJBXz2XJ1m2wYil5ZnC85al8khQ/W4g+oUVReQT1yoreruC76NRb0RMublg +no2nvv+RqXbaCJv3KQVstHdVnFLcEEYeY1VCIjZ704OwGCykRUyhgj3tGnEgItJBD Kzs/75HMkiwCdVcTz9jVBoTVjf+xmRrTVbvZXW9OTzSwRub4koHl/Aq6fKSbtpIb+H H1gh8r1VAddMg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 19 Jul 2023 16:39:23 +0300 Message-Id: Cc: , , , , , , , , , , , "Chao Peng" , "Fuad Tabba" , "Yu Zhang" , "Vishal Annapurve" , "Ackerley Tng" , "Maciej Szmigiero" , "Vlastimil Babka" , "David Hildenbrand" , "Quentin Perret" , "Michael Roth" , "Wang" , "Liam Merwick" , "Isaku Yamahata" , "Kirill A . Shutemov" Subject: Re: [RFC PATCH v11 01/29] KVM: Wrap kvm_gfn_range.pte in a per-action union From: "Jarkko Sakkinen" To: "Sean Christopherson" , "Paolo Bonzini" , "Marc Zyngier" , "Oliver Upton" , "Huacai Chen" , "Michael Ellerman" , "Anup Patel" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Matthew Wilcox (Oracle)" , "Andrew Morton" , "Paul Moore" , "James Morris" , "Serge E. Hallyn" X-Mailer: aerc 0.14.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-2-seanjc@google.com> In-Reply-To: <20230718234512.1690985-2-seanjc@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1B3501C0016 X-Stat-Signature: taehn3mtuubg9urmzsf1zzdattdgp4ox X-Rspam-User: X-HE-Tag: 1689773981-857637 X-HE-Meta: U2FsdGVkX19JdozFV11U1oG7VqVUUCGZL+GOkSZlXkvx0W/iAcXDW86pIyyEsOxSkXtwy557xmOdmn8r3J2md+hPueeZTpqIkhD6fMAtwPdRfa/CflAERpmju741ERzel/YeNJlZrySlIlb7myldke8Fzu0jcT2RQeQMGUT03+EE/e+lKtcUgFiwsJjuxWxbHd1SzHhsUdohfTQNppo9N7KkMr+Yl2Vi9xLD+s8gh6eS3hiaYpJWuFdO3kGqXfnLhtkJ+l0byi8AS1QOx7AMCDcfTiEfoOUDuQvS9L4X9Ab2Axiop21oWGVLx33+wVGMzoODvknq33s+tuQGTrecPep4OoTjMnsl8ICRkoZ+CuO4G1ToiFOacWwhijmR19ynhkr53fB0qroaRLMC9PH94ROfrXZKJa0nIiTfaKJEezz9iHe3Nuw9IcOez2ZBbfVDgm0D1qwt3hF17KFsffclcv74ANClfiI5YzsHOyNv4oS9lCe1MyQFWhEsAsRdemMtkW7JBZZj0GmWYtyzlrnzrCNTDATaOuENusmcoHTO8KYQjm+/hoxXqq+fWLHFOFq0DvIGzEOPHbX/Ctm4C/mR7cgsCwwWvnTeqJrwvsKshT+P4SfG+a9dtjujE9NuPSatrdBg8t/Z72yrL7ArMXBiF7fF7w8H4E+YcbpxDloK9wtIyNNfSTO0XiTKiezZzYU3+Ub0D2cY22RsONC0Mg4n7fKfN4cA15kSlanWjiBskMnYUBkRqv9q2bjhhNuFSKsp3RiOkI05WjajKcKQkcZbCt9Moor3JwtfW8GoH8PqoYF7LEUWwx41jj9TLand9J/4brBrnTQpytR1x7s/UvTncLrCWV8arQtDn81VJVTYM1kvRATXKSDpdwvYN7AQ/BB6wqWruBoB2g0QFAHVoWT4QPpaM/jgqIA3Lr/LBUlDuAoLrLvQSVyCZXc/e4uOtHRVO8VSueq4fMt0ztRIWDI kZKh32nt XwnLy9fDsAl1DNLKRTkkPdu38rgQOU27d3Qzr1wVymblHMdXHvDhObwpgSi83m5W/zTSyWdEoSif1QX3vPaAHUss984xuJypO29H4mcjGKhEz0aYiLQ9W4q7saNrduVX1XrYtYUpkV+ukMi0xoId/j0/ONo1CIQ1SSPnqlfB0LVVfvdJcqQ8zqkTgFZAhBXI4VjlJyAy9V5FUCmHPUW7bDy9MLne3P+G1Mr1W0h609K3Dci15xmlDDAGkAkL02vuNSkvZ+YYfyUIZcDAgdzk5ZBDVAuLTO/VyxiORH1qciQBFwJYnwMDfv25+9Rij9MZBkN0Jyp9V6A7yx7PAAfKbz+TNyuyCSe+Cuy7x9yi732qSJ/WeWWvND1eeRk/Cdwy/ogfIqiAASPenR/EZxAZF3KMqa9MiVR3s1jDBphtLJg7d07wgYP0BWjGIc71daVnAe6RuHhAGRSe+CBQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed Jul 19, 2023 at 2:44 AM EEST, Sean Christopherson wrote: > /* Huge pages aren't expected to be modified without first being zapped= . */ > - WARN_ON(pte_huge(range->pte) || range->start + 1 !=3D range->end); > + WARN_ON(pte_huge(range->arg.pte) || range->start + 1 !=3D range->end); Not familiar with this code. Just checking whether whether instead pr_{warn,err}() combined with return false would be a more graceful option? BR, Jarkko