From: "Julian Pidancet" <julian.pidancet@oracle.com>
To: "David Rientjes" <rientjes@google.com>
Cc: "Christoph Lameter" <cl@linux.com>,
"Pekka Enberg" <penberg@kernel.org>,
"Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Hyeonggon Yoo" <42.hyeyoo@gmail.com>, <linux-mm@kvack.org>,
"Jonathan Corbet" <corbet@lwn.net>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"Matthew Wilcox" <willy@infradead.org>,
"Kees Cook" <keescook@chromium.org>,
"Rafael Aquini" <aquini@redhat.com>
Subject: Re: [PATCH] mm/slub: disable slab merging in the default configuration
Date: Wed, 28 Jun 2023 17:05:08 +0200 [thread overview]
Message-ID: <CTODJTSTD9WR.82GVFKOIDIUK@imme> (raw)
In-Reply-To: <48bd9819-3571-6b53-f1ad-ec013be742c0@google.com>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Tue Jun 27, 2023 at 21:32, David Rientjes wrote:
> On Tue, 27 Jun 2023, Julian Pidancet wrote:
>
> > Make CONFIG_SLAB_MERGE_DEFAULT default to n unless CONFIG_SLUB_TINY is
> > enabled. Benefits of slab merging is limited on systems that are not
> > memory constrained: the overhead is negligible and evidence of its
> > effect on cache hotness is hard to come by.
> >
>
> I don't have an objection to this, I think it makes sense.
>
> When you say overhead here, I assume you're referring to memory footprint?
> Did you happen to have some system-wide numbers for what that looks like
> when running some benchmarks, or even what the slab usage looks like after
> a fresh boot?
>
Thank you David for the quick review. I'll re-run the benchmark and
measure slab usage when the system is under pressure.
Regards,
--
Julian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 265 bytes --]
next prev parent reply other threads:[~2023-06-28 15:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 13:21 Julian Pidancet
2023-06-27 19:32 ` David Rientjes
2023-06-28 15:05 ` Julian Pidancet [this message]
2023-06-28 16:44 ` Roman Gushchin
2023-06-28 18:50 ` Lameter, Christopher
2023-06-29 7:21 ` Vlastimil Babka
2023-10-12 16:43 ` Kees Cook
2023-06-28 20:59 ` Kees Cook
2023-07-06 14:06 ` Christoph Hellwig
2023-07-06 18:27 ` Lameter, Christopher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CTODJTSTD9WR.82GVFKOIDIUK@imme \
--to=julian.pidancet@oracle.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox