From: Chen Gang <xili_gchen_5257@hotmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>
Cc: "kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"riel@redhat.com" <riel@redhat.com>,
"sasha.levin@oracle.com" <sasha.levin@oracle.com>,
"gang.chen.5i5j@gmail.com" <gang.chen.5i5j@gmail.com>,
Linux Memory <linux-mm@kvack.org>,
kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: mmap: Check all failures before set values
Date: Tue, 25 Aug 2015 05:58:05 +0800 [thread overview]
Message-ID: <COL130-W465CD26C1EF1D52CAD2FB4B9620@phx.gbl> (raw)
In-Reply-To: <55DB93B2.9010705@hotmail.com>
On 8/25/15 05:25, Andrew Morton wrote:
> On Mon, 24 Aug 2015 13:32:13 +0200 Michal Hocko <mhocko@kernel.org> wrote:
>
>> On Mon 24-08-15 00:59:39, gang.chen.5i5j@qq.com wrote:
>>> From: Chen Gang <gang.chen.5i5j@gmail.com>
>>>
>>> When failure occurs and return, vma->vm_pgoff is already set, which is
>>> not a good idea.
>>
>> Why? The vma is not inserted anywhere and the failure path is supposed
>> to simply free the vma.
>
> Yes, it's pretty marginal but I suppose the code is a bit better with
> the patch than without. I did this:
>
OK, thanks. The comments really need to be improved, just like Michal
Hocko said before.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2015-08-24 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 16:59 gang.chen.5i5j
2015-08-24 11:32 ` Michal Hocko
[not found] ` <55DB1D94.3050404@hotmail.com>
2015-08-24 13:34 ` Chen Gang
2015-08-24 13:57 ` Michal Hocko
2015-08-24 21:54 ` Chen Gang
2015-08-25 11:35 ` Michal Hocko
[not found] ` <55DCDF7E.6080402@hotmail.com>
2015-08-25 21:33 ` Chen Gang
2015-08-24 21:25 ` Andrew Morton
[not found] ` <55DB93B2.9010705@hotmail.com>
2015-08-24 21:58 ` Chen Gang [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-08-23 16:57 gang.chen.5i5j
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=COL130-W465CD26C1EF1D52CAD2FB4B9620@phx.gbl \
--to=xili_gchen_5257@hotmail.com \
--cc=akpm@linux-foundation.org \
--cc=gang.chen.5i5j@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox