From: gchen gchen <xili_gchen_5257@hotmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel mailing list <linux-kernel@vger.kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"riel@redhat.com" <riel@redhat.com>,
Michal Hocko <mhocko@suse.cz>,
"sasha.levin@oracle.com" <sasha.levin@oracle.com>,
Linux Memory <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: mmap: Simplify the failure return working flow
Date: Thu, 20 Aug 2015 09:26:28 +0800 [thread overview]
Message-ID: <COL130-W42419C917737D318BC8E6DB9660@phx.gbl> (raw)
In-Reply-To: <55D52C9A.5060705@hotmail.com>
<br>On Tue, 18 Aug 2015 15:57:08 -0700 akpm@linux-foundation.org wrote:<br>><br>> On Wed, 19 Aug 2015 06:27:58 +0800 Chen Gang<br>> <xili_gchen_5257@hotmail.com> wrote:<br>><br>>> From: Chen Gang <xili_gchen_5257@hotmail.com><br>><br>> As sent, this patch is From:you@hotmail and Signed-off-by:you@gmail.<br>><br>> This is peculiar. I'm assuming that it should have been From:you@gmail and<br>> I have made that change to my copy of the patch.<br>><br>> You can do this yourself by putting an explicit From: line at the start<br>> of the changelog.<br>><br><br>Yes, it is really peculiar, the reason is gmail is not stable in China.<br>I have to send mail in my hotmail address.<br><br>But I still want to use my gmail as Signed-off-by, since I have already<br>used it, and also its name is a little formal than my hotmail.<br><br>Welcome any ideas, suggestions and completions for it (e.g. if it is<br>necessary to let send mail and Signed-off-by mail be the same, I shall<br>try).<br><br>[...]<br><br>> So,<br>><br>> --- a/mm/mmap.c~mm-mmap-simplify-the-failure-return-working-flow-fix<br>> +++ a/mm/mmap.c<br>> @@ -2952,7 +2952,7 @@ struct vm_area_struct *copy_vma(struct v<br>> } else {<br>> new_vma = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);<br>> if (!new_vma)<br>> - return NULL;<br>> + goto out;<br>> *new_vma = *vma;<br>> new_vma->vm_start = addr;<br>> new_vma->vm_end = addr + len;<br>> @@ -2971,10 +2971,11 @@ struct vm_area_struct *copy_vma(struct v<br>> }<br>> return new_vma;<br>><br>> - out_free_mempol:<br>> +out_free_mempol:<br>> mpol_put(vma_policy(new_vma));<br>> - out_free_vma:<br>> +out_free_vma:<br>> kmem_cache_free(vm_area_cachep, new_vma);<br>> +out:<br>> return NULL;<br>> }<br>><br><br>It is OK to me, thanks.<br><br>During these days (2-4 months), I shall try to make some patches for<br>Linux mm:<br><br> - I am learning Linux kernel mmu, so I can re-use part of code to user<br> mode (add softmmu to qemu linux user in my working time). Then I can<br> try some mm patches when I am reading related code.<br><br> - At present, cross-building various archs with allmodconfig looks OK<br> (have no many issues), so for me, I can stop and start another parts<br> (e.g. mmu, loongson machine of mips arch, ...).<br><br>Welcome any ideas, suggestions and completions for it:<br><br> - Assume I am not quite familiar with mmu -- in honest, I feel I am<br> really not.<br><br> - Is it possible to build the related 'softmmu' as a module which can<br> be used by both kernel mode and user mode (if really it is, I shall<br> try to perform it -- I can do it in my working time).<br><br> - ...<br><br>Thanks.<br>--<br>Chen Gang<br><br>Open, share, and attitude like air, water, and life which God blessed<br>
next parent reply other threads:[~2015-08-20 1:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <55D5275D.7020406@hotmail.com>
[not found] ` <COL130-W46B6A43FC26795B43939E0B9660@phx.gbl>
[not found] ` <55D52C9A.5060705@hotmail.com>
2015-08-20 1:26 ` gchen gchen [this message]
[not found] ` <55D52CDE.8060700@hotmail.com>
2015-08-20 1:27 ` gchen gchen
2015-08-20 7:45 ` Michal Hocko
[not found] ` <55D593C2.3040105@hotmail.com>
2015-08-20 8:48 ` gchen gchen
2015-08-23 17:28 ` Chen Gang
2015-08-23 16:28 gang.chen.5i5j
-- strict thread matches above, loose matches on Subject: below --
2015-08-23 16:20 gang.chen.5i5j
2015-08-18 22:27 Chen Gang
2015-08-18 22:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=COL130-W42419C917737D318BC8E6DB9660@phx.gbl \
--to=xili_gchen_5257@hotmail.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox