From: Liu bo <bo-liu@hotmail.com>
To: akpm@linux-foundation.org
Cc: kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org
Subject: [PATCH] memcg: correct return value at mem_cgroup reclaim
Date: Sun, 6 Dec 2009 18:16:14 +0800 [thread overview]
Message-ID: <COL115-W58F42F7BEEB67BF8324B2A9F910@phx.gbl> (raw)
In order to indicate reclaim has succeeded, mem_cgroup_hierarchical_reclaim() used to return 1.
Now the return value is without indicating whether reclaim has successded usage, so just return the total reclaimed pages don't plus 1.
Signed-off-by: Liu Bo <bo-liu@hotmail.com>
---
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 14593f5..51b6b3c 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -737,7 +737,7 @@ static int mem_cgroup_hierarchical_reclaim(struct mem_cgroup *root_mem,
css_put(&victim->css);
total += ret;
if (mem_cgroup_check_under_limit(root_mem))
- return 1 + total;
+ return total;
}
return total;
}
_________________________________________________________________
Windows Live: Keep your friends up to date with what you do online.
http://www.microsoft.com/middleeast/windows/windowslive/see-it-in-action/social-network-basics.aspx?ocid=PID23461::T:WLMTAGL:ON:WL:en-xm:SI_SB_1:092010
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2009-12-06 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-06 10:16 Liu bo [this message]
2009-12-06 13:30 ` Daisuke Nishimura
[not found] ` <COL115-W12ECCA5335D3BFBB60D5829F900@phx.gbl>
2009-12-07 2:23 ` Bob Liu
2009-12-07 7:47 ` Balbir Singh
2009-12-09 0:28 ` KAMEZAWA Hiroyuki
2009-12-09 6:22 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=COL115-W58F42F7BEEB67BF8324B2A9F910@phx.gbl \
--to=bo-liu@hotmail.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox