From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8CAC77B75 for ; Fri, 12 May 2023 05:52:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8C7C6B0071; Fri, 12 May 2023 01:52:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3CAA6B0074; Fri, 12 May 2023 01:52:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB5FE6B0075; Fri, 12 May 2023 01:52:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 978586B0071 for ; Fri, 12 May 2023 01:52:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 69E89AEB72 for ; Fri, 12 May 2023 05:52:07 +0000 (UTC) X-FDA: 80780532294.30.496EDF9 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf27.hostedemail.com (Postfix) with ESMTP id 97F1240009 for ; Fri, 12 May 2023 05:52:02 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SHgbq2CX; spf=pass (imf27.hostedemail.com: domain of cathy.zhang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=cathy.zhang@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683870724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IJ6G90O0k/8zyctgaebftUI8Wl3O5eE9cpp7IT6csNg=; b=8SP+VKQXIzX1GMoKBFtCCy2Bzz5qHL9soEsLHmcLoNHroBYiCli5kr+ha6WMXLOIxUmBJg 7MW5Tdb/0x4LbcUdO8bWWbouLvKeg3013BDxmlp4Trp/RLF3FW7LH4rekrvB+s2DdTTEkB hhRNhr8WvfE3mZ6XplxN34Hot/2pBi4= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1683870724; a=rsa-sha256; cv=pass; b=cbN8A+xF/4PoSt7N3QLgvUfCrsnWYHd8vHDLq1amtubzqixVriW4v/YVHBaG/yfpA+qYFf PLvPZCfnrvMFIH3WoAT/rC9aCczNzD5IV9Ioy0uEwtrAK9TzBXdnFiXsiRt+9XOLj8wIBE Wc5kG8EzYVQ323d0Kgfd784EGLXUm48= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=SHgbq2CX; spf=pass (imf27.hostedemail.com: domain of cathy.zhang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=cathy.zhang@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683870722; x=1715406722; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=a0YRRNH6Jem08syi0+ULqPbhpNskb9dPUuFUAJrKZg0=; b=SHgbq2CXNWUyXBzjnXacLRyav1u08YC3Lp0IRnxiOUdd6+Rtn8I4SRie mKEDKilPV5TCgTAhbJdmcRO7hIju7o2DoUPnSm/tmsVx1x6EX3iEQvs0Q nAo4a8LnnO5vNiNYIxSjSx21ynMeyHtHbLAm8PabOfeHL+ICCFueEgMnD ocxxNb6hVI2BmauIqEEyTU3kNWjljeH7ORLXg+37/U6V0Id2pL+oPLTyc gOhYXNXb1bzZ3xwLHDYMkpUsbXnzzE8GGmI8DykZJxSMMNLQ57ErxoTp+ vNyDg6KBj1rFi+eF1tc/Z8LVZj1VwurXOUQtH+HweVV5U9gU0qW/0m1kT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="340018951" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="340018951" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 22:51:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="765039144" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="765039144" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 11 May 2023 22:51:44 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 11 May 2023 22:51:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 11 May 2023 22:51:43 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 11 May 2023 22:51:43 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 11 May 2023 22:51:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KclNdODIPB1/vIkNKpQBduHWXBt85ViyIOWLRR5gLolZ42pyaO/4P1roW7oQif/6ny1Yq4qf1DYkCapLUY8oCyFrhMrn30QOSoif7YB7l4v1wQoWG77Bu3QR/nlh4KkivJ10nLLB5VX/YN0wiOA/N0OS2x8N4RmMyTKRDQEBsX0f/qReC43i6zXosICe0Xovqf6ATlPLH8ROjtzC8ddENg0y7Og2xtgMTyGubv2FNTx4va2wQimLAI2AlRum80noTJBwheGjuUWfkLLbo7PITz07KbFPezeDP2Q6YX7U2KjSE7Y9Nk4FHEMVcarnxWzNdfW4Q0jAvNHj0lpSXEWrBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IJ6G90O0k/8zyctgaebftUI8Wl3O5eE9cpp7IT6csNg=; b=nalyapn6cRhXGnvfTLmdzJ05ABwWD6V8qm3fYycZIpVHO9OSu1hk8K5OzEHwBlfvr4nsgiTrYOBaHOshZwBBLGg1rYkqEK2sLvT/JVfpPRWLNSE3sZc9cXu88tcUcYMFfIF/1GfQW4fwurLK4buEpSWw4UIt/470gZ490MLaAQfTfpsNl//fRlrrhL1y04k07PmA4BPK4hjacInEhv90iJxB01giujMMEEAAyScK6MzV6+rEI5U2hSVvAlPHLkf/5jwfF5Bg1TsARsHVatJ253Q6tx0TG42viKVKjMqbfiMrYGIFkfASyxmtH1CyS/QeFXgtagT8jq0nrfBwl1cXPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB7345.namprd11.prod.outlook.com (2603:10b6:610:14a::9) by SJ0PR11MB6717.namprd11.prod.outlook.com (2603:10b6:a03:44f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Fri, 12 May 2023 05:51:41 +0000 Received: from CH3PR11MB7345.namprd11.prod.outlook.com ([fe80::242e:f580:7242:f039]) by CH3PR11MB7345.namprd11.prod.outlook.com ([fe80::242e:f580:7242:f039%5]) with mapi id 15.20.6387.022; Fri, 12 May 2023 05:51:41 +0000 From: "Zhang, Cathy" To: Shakeel Butt CC: Eric Dumazet , Linux MM , Cgroups , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , "Brandeburg@google.com" , "Brandeburg, Jesse" , "Srinivas, Suresh" , "Chen, Tim C" , "You, Lizhen" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Subject: RE: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size Thread-Topic: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size Thread-Index: AQHZgVHu7/SNtT9IvkyNelU1xcwWA69RtOMAgAAGxOCAAAwNMIAAEO+AgAAwgdCAAA4vgIAAB2YAgAEwMBCAABKHgIAAKNbwgAAVVACAABAwAIAAMNEAgABhfVCAAGbfEIAADugAgAATvZCAAM4SAIAAWFPwgAANFgCAAB1pgIAAB41g Date: Fri, 12 May 2023 05:51:40 +0000 Message-ID: References: <20230511211338.oi4xwoueqmntsuna@google.com> <20230512050429.22du3gt6rrq6e37a@google.com> In-Reply-To: <20230512050429.22du3gt6rrq6e37a@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7345:EE_|SJ0PR11MB6717:EE_ x-ms-office365-filtering-correlation-id: dce5cbd0-c8ba-4e0d-4ab8-08db52acf548 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cuuSgZ10Yy2KMQRxp2NNOYRRN75P9RoSPqMgn581a3xniHc07daBAiJvuHWmfYcXauGWCZYHanigE1HU8dkcXGc8u7rpfqR2kufYnpGMEfVriy1IsidMDUSTfSXguumN4ku5wDmNRP0fCIHqJEIR65ZW+6CThi+77c3iHe3Avfxw9onRZMCP+dw6X9gBAweQ4kdN+Y2ovJGBCbDrHQzAQTPh7p+3kRMTMgetHLi1V3F+qxiFtFC4I91TWl+RE5dJdCZgxpcQFFOJ9+D6o5kuNrIAU1cc17kh7UlDXN8Nxvl7cc9EuW2HGW9tnak5askLXLJ8WdKzPBcZEVIo3icZcXNh6tNfQdb9ljp9jGGItTcgG8N0oyF1HgMh4TDlilPMhLJs9Po7AMq6Ts6GJ/mhRmZoJQzacPSiId0hI4FBOgG9RuhPSduO5SSKl/4FEuy1a2Mz+hOZl7xobSnE7Z7OnYI6lGdv2dfGqFwK6zcQNasC71k87z1kT44FFNU5Ngudx11ggFiAlrdQYXaKIyoCV2DYF3kqgSSsxiliVSBaz8LtFLZswuFa9ktKczKwVJ5hLH76GVr64gxmDYTR9vorvO06T0jmM+hH6YAvv55a34+0Ij2VQ3fzDuULi/s4NEGQ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR11MB7345.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(39860400002)(396003)(346002)(376002)(451199021)(86362001)(66946007)(71200400001)(7696005)(54906003)(478600001)(33656002)(6506007)(53546011)(26005)(9686003)(186003)(7416002)(83380400001)(66556008)(38100700002)(122000001)(52536014)(38070700005)(6916009)(2906002)(66476007)(4326008)(64756008)(5660300002)(82960400001)(41300700001)(8936002)(66446008)(55016003)(316002)(8676002)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DNRVLFwJicfo8cT4QiAIUKUuhAsmrYXXs5E8ui+/Xeogv7+/S+eL/5jqRqqe?= =?us-ascii?Q?SARLV1z66NBBDxqur9r34iHObSIrIzXLPJ1vf8GKk85RnUL1a/nHIilFXPJc?= =?us-ascii?Q?Qkgw+Ft7Rxq0H0G7jTccH3JwHKEtsTwCmV6mKrTocuIfVJULlh9iffm1fe9O?= =?us-ascii?Q?/KQNjXduek0OGCe+b7yV+dpNht0esGPKls4DFWnWaG1CjMX+tCrq03Cg7WMO?= =?us-ascii?Q?P8gdZejnrBoLbk37/yqbMHi2IKlhclI68I+pHbilSE0Nz5E9U440SC4nkBcB?= =?us-ascii?Q?sTzv6njU6S7ZGvn3LxlpUjmCm94ljPmDxXF/0Dt06KIsUcmxiIx6SZmqsr9T?= =?us-ascii?Q?WlWetOlJhvgCTQQhM8nCvpoEoq/UCP6M6eIhTctn3iICK45FK6QYIYN9sqpy?= =?us-ascii?Q?YWgpoAZOp8bjwFT3uYtv54/U0wfp/omXIq8adQAnBJv3mmE1B1LAUv+8WooF?= =?us-ascii?Q?pyATTs2IRZMOIHL9fqk4AwFlHz+NSdSL6HiBs8FDMbalcIMYtcKwLzB0WqFO?= =?us-ascii?Q?64zYSoPCltnAJjyx0bMKEFvpoTjm2CNzvW+7Tm18efYofbOrjb20saOP3VvJ?= =?us-ascii?Q?jdAJf8r+4Ty7TNnxx5tnSZybwbof9U8oPqVI+y4QqQJFp4OlFEmca3RZBZDe?= =?us-ascii?Q?muGDdExn+GG8uJtMhWMksR87T8BZ7iMpvpFPlYo6O5GOykFZVWIQfS/iF/DF?= =?us-ascii?Q?EjKsTkTSzssJtxsYdQNS51RlpU8nny9Kx9J+LpQGLhuvMek6PJqP6s2XaYY9?= =?us-ascii?Q?x29Z6vIpQ7auTXcatV07IrBWhSPhzKlAaieOrqdbZr9eL4Ed/L/rBWeGMmzT?= =?us-ascii?Q?rStX6aqtuKBBY55DdNOvZZemUo6xYG5gkrElARZYjxcktIRZsqGcl0XLl8Gl?= =?us-ascii?Q?RjsORWOkjj5wHJ2HvfvuObk56NVhf0PitSBt9TP/K+w2w5rA8T+3xBFifTeG?= =?us-ascii?Q?8PkVoPncIGygez+QbkYbQ1gREUNPeJhyvs6S60FSbMCMV9Zo7rsfL7hthD5/?= =?us-ascii?Q?mK5qBYJkIFC1FJQeJy5FFSiTILu5mTQC/c5VA9u5HdA/O6KEDIm10LIenV4l?= =?us-ascii?Q?hwdMLNUGeSj5fWxWMTLRLBtq5B2uUL4lfMkxyTfOkUvRS6IT2S7+bo6oktDD?= =?us-ascii?Q?NsEvd3LlOi3jsZoI8ka1z6TtM5ptjpr1VTD6RT6Cw713LMMGLBxtv04g0hAG?= =?us-ascii?Q?OTWwJYOwnLYhtQTMGxURhdToFpwxbcwWNrQfynFTMqRyOFI88R3Af2shFEK0?= =?us-ascii?Q?QLbEGy4uhdezL3kgq7sCfVG6GG2pudKOLp3wOmZLx8+NGY4k3ahLLXx8/C7h?= =?us-ascii?Q?smVJTZ3/UWM6xXKOrl11qjFtxkFmGgv4sMSn2xN0pZXczjpuVtyIzXGahksP?= =?us-ascii?Q?faVks4UrZTXmgJmzSUTbtDzD/GKnoANCV7IcU1JpUjcyh8j3dZH9nknjKB8S?= =?us-ascii?Q?YgEut46TgRswwdv6yYI44S0peKO0sdlaDRDhz2Cg0l894nQVrbSohpbwaKAJ?= =?us-ascii?Q?WNBb+CWvxp1Wf3OYJVEF030Gsa/kHmCxAdxllJzVxdLdiOWLRynuRaIOrm2L?= =?us-ascii?Q?liTJLDdMPl6YJ9pWczWoKKeDBlxhS7NwzzSDIudr?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7345.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dce5cbd0-c8ba-4e0d-4ab8-08db52acf548 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2023 05:51:40.5906 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e+dqaPvdoWP3E93DKw4otJwyATW7WOgigcWODXbfL4lHbq0aIJA+7kWB65DwbmS/8glDtpLPph5phxolSvm37Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6717 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: 97F1240009 X-Stat-Signature: tummezog5kbfjza3hot6uzz1rz14gacc X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1683870722-34628 X-HE-Meta: U2FsdGVkX19DGR4EqmH15ebPv9piwTjRvcl8prybKUgv8NvNLp49nuEGVqCGDroy4GKkXMFy4SkoXofLeDb+uPJEVKT31W6ceGK0YQB4iT8IEah/eSxJlg/JeXLiEUQj5MLGqnAEzeIREuHJzJqZ9Q5LxXmsEhzpoH4RcCTAsihpglVW98CIJTwm+iZrq3EuTzKUikz0Py9z1Zzju3WyOiGtW9w3LIfTPnmR3yh9JETAeaDj10cxzuUPqMBC0guVYpcR3eVIl825LUDBGFK0Zl0+DsJVtl7uVytTTaXtTFKNTX4hI77UL21CAaUrjqPs7+KbhIKnVI2l6SsZ43H+xxaLcP13wJImE5qCD5HbbvxLrDEPIiyZSyJYuSQYVePGb4eTFOJlpDLb4wtYvp0eQqASdxIUR4R3Tou3rq5luywrwb8DGadxNEvmxM5qncWH4rAlvO1xvi+hsJLMuLh/RLpWlirejJZfsA72NGBvHtr/G1DUXXdCM/Ll2MNMViXZGJtQxrw7XWBH9flM7dnhACfRkQkl8e4b1I3TfyvdC7LJrWv9YplvTOHEPCPISsIIBF3DLZxMT42qHjs8qWcUMeAaAHddaySw3Ig2S40ELGa+UPmkqlawiNmimIbnMcPHDNxodWIu/Nu/x/4qf4+Ne2l8VoyLCxReYKbFfc2ireuxHlvq/Il7tx9z2nRQw/El7vQZEIJZuLrcfRC0Q+8/LlyDvi51gN/WDocasYrbasQm4zBhZ2TuJCgVXTYPVhWFoxhdguj/CDda2Ib7TfY2/Ts1Ri5QSlY2uTHQZi+uizO8H4cVkKWukhZ/a/WvM5pcVUGR5HYCBbMv4IyWb7BAFzQiIz9KLr39K+T5p/ZEptQMwXd1vrnLJMdwNqosOLAenfTFMlsRJUU1JY6DwP1z5cqDukBSFs3iyHGeDbeFBy1Djw/TvGsbqpQB2gCa4qvhrdDbtWzfGvURw6LHNBC 9Af5B+Am IJQk5mFDeO6Xqy2e96orYQryCTX7892qGRzcbXYU0MNQdoS8HrHtoK06/fyjf+M+QR8+qAK0j9E4QZPnQsnOYScMXngmyx/MYW7P/FMPByi+EQLKMazEr0pKKboiJMyrfsCZpYXwamknXp2OVFU/94ynhAfIxTuOgAUcHIq+CHUrtwnvy2LSyUR3v5C3T6vL2adtKgt/Xo2H2W1L+3eFzfEqWKfq1I2qkmJDypYOhM69p2wWgGDtu4Zv+Tf3+rIwxV+L1HfsDrubjr1bmzLVVdNjR5CpTMdz/Ag/5UNO9HtZFEkQa3YGvfsNyTWFwWBtXKRnrHEnxv5hBHZON9EmGH+UqwUMnjs8wZkogzX8dcluiq/b28e2BjjQHiRbp0K53JWrtRuhm+xeuF8gGstC0+M2uYnRDRAlM8ibYkwuLAXmno4TLcD1CVL7W8jx17K+9lVCECjGEHXF3W6qQWxjCrWCQQCC5eVfwRAx7wCt+bzHZFhYFWTQEjVVKAVcHkpkm5JoSB/oEsaIcDx5IE003PvK0WbkHErYG3X6m7N38sqIQ1sQgIJaCVizxcYDr5vAJKJAP+ft5gZa82RqwEERsyx86+Ky1x1CKbPexdtjADRWlxHheAf0856Zw4ZvNrylKKVl/rzoiuw/ixvpnZCm4MNsGZp+5BMfK/+4oUg5LsNcieMT0NDRIMvPnl/I1ZT5ypPITCRXo5KtMTvZNAshN3+AU03dLknca6oY4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -----Original Message----- > From: Shakeel Butt > Sent: Friday, May 12, 2023 1:07 PM > To: Zhang, Cathy > Cc: Eric Dumazet ; Linux MM mm@kvack.org>; Cgroups ; Paolo Abeni > ; davem@davemloft.net; kuba@kernel.org; > Brandeburg@google.com; Brandeburg, Jesse ; > Srinivas, Suresh ; Chen, Tim C > ; You, Lizhen ; > eric.dumazet@gmail.com; netdev@vger.kernel.org > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a pro= per > size >=20 > On Fri, May 12, 2023 at 03:23:45AM +0000, Zhang, Cathy wrote: > > Remove the invalid mail addr added unintentionally. > > >=20 > Sorry that was my buggy script. >=20 > [...] > > > > > > Hi Shakeel, > > > > > > Run with the temp change you provided, the output shows it comes to > > > drain_stock_1(), Here is the call trace: > > > > > > 8.96% mc-worker [kernel.vmlinux] [k] page_cou= nter_cancel > > > | > > > --8.95%--page_counter_cancel > > > | > > > --8.95%--page_counter_uncharge > > > drain_stock_1 > > > __refill_stock > > > refill_stock > > > | > > > --8.88%--try_charge_memcg > > > mem_cgroup_charge_skmem > > > | > > > --8.87%--__sk_mem_raise= _allocated > > > __sk_mem_sche= dule > > > | > > > |--5.37%--tcp= _try_rmem_schedule > > > | tc= p_data_queue > > > | tc= p_rcv_established > > > | tc= p_v4_do_rcv > > >=20 > Thanks a lot. This tells us that one or both of following scenarios are > happening: >=20 > 1. In the softirq recv path, the kernel is processing packets from multip= le > memcgs. >=20 > 2. The process running on the CPU belongs to memcg which is different fro= m > the memcgs whose packets are being received on that CPU. Thanks for sharing the points, Shakeel! Is there any trace records you want= to collect? >=20 > BTW have you seen this performance issue when you run the client and > server on different machines? I am wondering if RFS would be good enough > for such scenario and we only need to worry about the same machine case. The same test scenario is tried between two machines which are on the same network but with network topology, both of the two machines are with 1Gbit = NIC. There is no hot paths observed, but it might because that the systems are not so busy, for memtier shows the average transfer speed is down to a few tenth of original on the same machine.