From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3A1C77B7F for ; Fri, 12 May 2023 02:38:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D723E6B0071; Thu, 11 May 2023 22:38:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFB0B6B0074; Thu, 11 May 2023 22:38:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFF3A6B0075; Thu, 11 May 2023 22:38:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 990DC6B0071 for ; Thu, 11 May 2023 22:38:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B605120836 for ; Fri, 12 May 2023 02:38:57 +0000 (UTC) X-FDA: 80780045514.03.0C673A5 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf10.hostedemail.com (Postfix) with ESMTP id 50068C0005 for ; Fri, 12 May 2023 02:38:52 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Yqy+i5ri; spf=pass (imf10.hostedemail.com: domain of cathy.zhang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=cathy.zhang@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1683859133; a=rsa-sha256; cv=pass; b=1/uN5bOO6RwHhT98c7FHUgfXARiVjBwVvY13ctnh4F5Ca/uMSkJGkOI71d2NCwjmdmGWKc 5wqQOIlErR/Ic92PxzrVGJI7MUEf5alFekdP2Ql7qTk2hsJ9EWnL7n86hYZqiVVDP3BjLz KozVk4KAJPYcR/YS5l9egvduhL9m0Eg= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Yqy+i5ri; spf=pass (imf10.hostedemail.com: domain of cathy.zhang@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=cathy.zhang@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683859133; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hUsW7iKqZkGMl3UHu+GErzeE6NpTg0GM6HPNCt5Kq28=; b=tD2TvHUOmF+jndKcv3g4E4DZxvRVIZJxW17ubPAy1JqydfGFWcbi0yMl0pdKYG7nGOE6a+ m+ZVvRc2HCvk4xgeIuvu+gSKnr1ZhvA4JUdc4yaKZhdfxs5Rb5OJ7wdgv3J/FyI7YNwdSW 1mVTyUsZw0SMkzngzY41FXSb+SsxKyo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683859132; x=1715395132; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=YpSODKnMTBnfb3N0AHUEPGQQ8u9heGeBOGBq9g5+d2A=; b=Yqy+i5riIc+6iXZ4OdT3BzKr1YeRmFWtMYSG0J/z6ynFjE4dL6+BTdog zWzMHl7raCqHxqfaIzPI7HO7GAL8YLFlGachZaAy0zjtL0t4eNyTrQGHt 8y1QjGGbTZD9PbTRWhmY3lwqoNivgoVJvL7mb6TEtRb2VcdsN+jdCiIU4 qLcQXnO0YeOlgkGrieA1wFR8JIaouZe+AnT525wutRL2mnv9ujdYCfU+q KJHTH7rln1EYqkbjYnT1/up1GAqubhFog1koNG4MznVM3xSrVPJYFfDfc IfUilQsRZgsLnxgxTJaT5ew43YK5i+30FO3Qb3OuIpKDu4G9gqpCyT3Fv Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="335202131" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="335202131" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2023 19:38:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10707"; a="702998854" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="702998854" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 11 May 2023 19:38:49 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 11 May 2023 19:38:49 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 11 May 2023 19:38:49 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 11 May 2023 19:38:49 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 11 May 2023 19:38:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MNZMtxDtkNaTcphf1a/nu/h7ucNUq3/6QPeXvnwWeT7yoVthU31HworwlhAig/1achRbsYr12KBsQoU/OIdQtd2/ugztUCFXCF1m53aibKnU1RsvIUWuvRAE19azfuGnsU6bbqvP6qJVr/2m/MipcG560gbgFgNsVvhcSlNYKZPLzv65Qatin7cqprClivXVwaK9Fhxa06HRB9ud5r8GblK5SsRI3zwz1XX6AbymEGvzxPkjm3tIKjW/NZ/hZ+BJw7dyNfN4AuKJROsxsxAjQtzYglUriaWtnyIN96ig5WH7Cnn+uptezreza43qIto4Ir8o7EdZhWKCp24sxKPkAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hUsW7iKqZkGMl3UHu+GErzeE6NpTg0GM6HPNCt5Kq28=; b=hqJ8H1elYLp+eyV/fUNWIfdXaZ/QiQ81dOCJg9dClIqgI3XYgMteDbrgeiiJFqIBeo/ztAQruqvfC1yWDS1RvX86mGHeeu+GyctlyGLnJ3HPRP1+oJjaExKbdMUMCFNHSALqUAl4odqa//rzYWwtBH0IDKq/QJIkDt+GzK0hpAwLXgGnmTfsCGqb3Aw2FawoB63qP9XYGH5nBgtlFILrPhwzyZtY2BUxglji0seIO+FqHQ4gR8bajlbtQWGtbZagUncvOSd2kk3Ld7066vgh4yHCiiWcxhTf0C2aHhV2OuiVKk845/VgweytjOSQ+dGWs8J1iztbYi7Yh1LxD84xpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB7345.namprd11.prod.outlook.com (2603:10b6:610:14a::9) by MN2PR11MB4757.namprd11.prod.outlook.com (2603:10b6:208:26b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Fri, 12 May 2023 02:38:46 +0000 Received: from CH3PR11MB7345.namprd11.prod.outlook.com ([fe80::242e:f580:7242:f039]) by CH3PR11MB7345.namprd11.prod.outlook.com ([fe80::242e:f580:7242:f039%5]) with mapi id 15.20.6387.022; Fri, 12 May 2023 02:38:46 +0000 From: "Zhang, Cathy" To: Shakeel Butt , "Zhang@google.com" CC: Eric Dumazet , Linux MM , Cgroups , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , "Brandeburg@google.com" , "Brandeburg, Jesse" , "Srinivas@google.com" , "Srinivas, Suresh" , "Chen@google.com" , "Chen, Tim C" , "You@google.com" , "You, Lizhen" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Subject: RE: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size Thread-Topic: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size Thread-Index: AQHZgVHu7/SNtT9IvkyNelU1xcwWA69RtOMAgAAGxOCAAAwNMIAAEO+AgAAwgdCAAA4vgIAAB2YAgAEwMBCAABKHgIAAKNbwgAAVVACAABAwAIAAMNEAgABhfVCAAGbfEIAADugAgAATvZCAAM4SAIAAWFPw Date: Fri, 12 May 2023 02:38:46 +0000 Message-ID: References: <20230511211338.oi4xwoueqmntsuna@google.com> In-Reply-To: <20230511211338.oi4xwoueqmntsuna@google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB7345:EE_|MN2PR11MB4757:EE_ x-ms-office365-filtering-correlation-id: 3877a517-e6ff-46ef-3c21-08db5292028b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1lejx0Y/fDES2rX6OMKetfTqOITYj3+nANTESSu1UhaNMR+47HjXAroa9FV8Uf7DH431XuZX/3wGiTII+yZ/ln1yqBcIP60e9b17RCqCTI0XaX1mh95Q+NJvplO41mj9oR+Pq16FZosxceMAgJYYbZaRsFKc7Dji92+rGxsLsTt92kvc6OjvbFCMvIX09sgiKggU6rHx07ANtef1kLkJ5O+9ja5KPxG4PAcd+32NQrqkh2yq7bC2vKdLGGW+6U0fMh4+wVWk5Vk3h1jpp8v+eVFxMMRMM5mdcANSnEuCZPJJPnjNTO1nRLC1giSNr1gdTdXKVtWI3ye6T+Jrhu2X8ML5d6WlbykIK4oG0q2HsvGH1eMqKpBRLChCMg8w3RVfIpggNwYwNkXnQl8kTIlJKhpN/hGU2F/bVsPKDNTny9gkFRO+9kO9slpuFaCc7zXGQg+zPVALp67QnLXmyDjWRaiiF1jwz4kDcPzFEUJZnRzm3sbrLP4iwQ5SgmjZX5QFHH0iVhwFwvrN1oxQ2vAz0YkQ7BfHbmQSFwGWrF2+deZlZlRGGP7mFG3iRw2ktXrQKcdwwkZfKkfSpQHl4VCO3U9cO/Zo4KL3MIzxT1F/s4zgvNGAiUGiSJR670Z+6HS/ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR11MB7345.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199021)(53546011)(6506007)(186003)(8676002)(2906002)(26005)(71200400001)(8936002)(7416002)(5660300002)(52536014)(9686003)(83380400001)(55016003)(122000001)(82960400001)(33656002)(4326008)(66476007)(86362001)(54906003)(316002)(110136005)(66556008)(41300700001)(66946007)(76116006)(38100700002)(64756008)(66446008)(478600001)(38070700005)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aR3/PfUXET41RhYklSLqSRAgIko5+X1JeyO7UcdGxTRqAp+cYBXlA2pQTomw?= =?us-ascii?Q?+uTgoCkzKJrxFAB8KJEB5rl6BeNn6F1p8LW7pR+lfHnfNeHRvLfUgeuS/Kvc?= =?us-ascii?Q?kX/E+j0V+KUXirWBHZ6qHKnV1ITW7HqkW2U1v6KKtR28MPvCxyox5s4AybPT?= =?us-ascii?Q?wUZm8lWfgc32oh12wV3107J1yNR55+sa6lyK2B3FM7NsynnTJe/U2hC08C+t?= =?us-ascii?Q?1+Zmbf0QfKcGnlGG578fnrc/qg+bET6aRIzSJmrkt7mnEyogiYzcUgwySpyn?= =?us-ascii?Q?Y5Kv78nnUwnTx4QWeMArA3vPCYjTpeZUfnR5ASyxvMq3u1B0ldw6jUP4an8A?= =?us-ascii?Q?iTXuIcb5ELAgWdjU0/7RelnGKDXaD5yEC1xd3OKoymNCMxmOmhU4eZO31RIr?= =?us-ascii?Q?WJBPA3jAuhy25qeFvpLGKAZNepqFgf2m2jz19LYYSfiw/IMBa8Eu8RrtUWJ2?= =?us-ascii?Q?APCe69AnA4uRS8fbAUb1Pe7cESTCTP1rj9YvtkcbXQXkAGQq8Xh80rKBKmKW?= =?us-ascii?Q?l8y68u8Ha932RK5tIHz1f+fe20sr7wjyM5x72lbpG5Xz3JaO+7xFAVKEMQ6j?= =?us-ascii?Q?K39A8POeY9KuHQhlWhcxxWmBkrmQCmPAoUqW09kSm40d8xDR+8toeTBsKIy1?= =?us-ascii?Q?lFgQ91HyXeQKwcqsxLPEQgwxdU5EDkr4TbRsQ1aq+w05D7tvPcWk1O6Z32o8?= =?us-ascii?Q?OFGXLSN9cVEzPwh8+KPJXDo6S7k2hVdj2HtL77mrgK2aSef84bmqsmEdmht2?= =?us-ascii?Q?2ZlNfuDSig7w8dEKCnBP//iTrYmdIbxEZ5BXlUzBqk+d1yOgPncU46o5mV+f?= =?us-ascii?Q?3r4UVHAiKKYr7lTMWxlNX82ZtNQG/L4beYLHyq4Butj27sWBOBWMwpb5WAu9?= =?us-ascii?Q?1/0uwOmOuafJ5dRrWIPnpat8ZmNa6uDB77Z6BMnuIkWaqZdKeHuyAcNprSE/?= =?us-ascii?Q?vbjjkIudVozCcW8kJHDlTMlnh8cxy4fxN398YNMcLbTNwdKu05Qq6p+jNoaL?= =?us-ascii?Q?eqljsrIYR66QRyR+cZDatHfT06A5rLTDueJmMZatLebXe80eI2/ozDVqHvjp?= =?us-ascii?Q?E/QKj31tV1ztHp08yAmzyjbkbiS5Qh9dxJ0gxewpddWQr9aOqHA5WQNw3Ng5?= =?us-ascii?Q?Hesg3NnzqQrfty3EsqrrpI1cga+2+DiLlsc6sbMVEIICYpi+/ezBAQWK47oi?= =?us-ascii?Q?XMPg/eHxozz151/MaUrpvDqusrtbXnesVx6JZzwihrcEEUCepYXpW1PgQJcl?= =?us-ascii?Q?3QYIKjMUk6N6735onCbsx3vH3mYNqtGR/ZiVPbESjn4tXrn4FzDH5gK1l0Fh?= =?us-ascii?Q?AmB2RMR7sl5+0YthwkUFiGtRr1SlhbDeacYvI/Qx54KAL0apo6VNcsj6KCdr?= =?us-ascii?Q?VRs3gcbzqDbu+G5QjfzN6vAdInbt9ueaE4e+RSpeZNwq6hMIK3qYo/P5nVM4?= =?us-ascii?Q?GNvkyuyW7gX7Jpmc1RBfLfRT22Vk7mdlooU8joxW1kPtWQzK3WWOEQ06WW3f?= =?us-ascii?Q?xcIouOnOkIQa1IW4dzPH/RMXLBe4lpQCIV+blXgNLAuoVt92rIN5GexfXpCa?= =?us-ascii?Q?3MB5kaM5EfKy/cTbHKWkwH/PrPzojIL8GkNSSQbZ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB7345.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3877a517-e6ff-46ef-3c21-08db5292028b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2023 02:38:46.3890 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /uV9kS9+MhBpBaHQHPcOvaF8LoslOsaJ4K9EXkJBOPKIXawvdIuEW9myvLXp6YKke2XxyQicwuATt1/iCezJxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4757 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 50068C0005 X-Stat-Signature: rsmktnog9xqt8c8mige1q6dw9bfr7kjk X-HE-Tag: 1683859132-113859 X-HE-Meta: U2FsdGVkX1/WxvzjH81zv0UURHRYfebQUQQ+N09TkVQ+16H5Vzd+qvBKT0t+JOI0R1FTXYG9gcf/82KJe4H1A70jTF4EEbl5yqK0yVpmW7MbTebZTE8jsyVvRAEtQ73BF6QHlBgSaZPHeH0eBc7iZPXtn1ZhqBEJJMPFTBsUFh/87QupJUAAUJF4p9GlMx8K2dk9du32jfffKdDzni1W451TGQjQ3OhcX/9hcT3Wzup8hX4YJ0N52bE6H/llhOOQqlIEOl2bZXdwRN3T6we1Bi8kIt+SSQvityWhn+xUgLtbPcHV6IR9jANpqWRixSugzfFLBfap9jiP/cF+qcf3PpfWCvjUiis79+MJb2isgUcw4rV9Fqv4+FadhwLPNE4P36Yy6PdB2q1ZXYq6ySwx1lBrqvcGNV5qW6B9oIQhFZV5tpLJP+9lr//eg2JUSGGrSb0B0FrsdpltNgGYKhQFzHMVBrD+BePr2SlqcuXzoqjMMNrGWpDWF8q7Dq0I2iWtDtQUnonGU+A8h26GVKzZs+txJNULKXd8WWn/npk80k/cTzdbrYbaZenEKpH+V+CfXbtSUdaWGsYm8QFQDiBcpmfHzXH/NDTsPasugc9yavWIVPPx1sStM05KBQ5a6RjQ+Kmtn/kwdaaI83pj3xWF7qOTJhhmSLuh5fNJXgzJmXGGqvO2bT1fGlQnLwR9YCzsSfpAiQttsKqnHJyjPxlSzud+ZPKSWi5U654ldNbAPxKrJkNwAnyViY0280fw8dlSScB+eIX+6ujSQRXMwNXn9uel9d6Hw0Rtzhe2gHY/RREbdDM8STtdaKZtYevXRR/T9mpbzE6tJrZZfmM74ymzdwOhhID1p1RpUUjfGYCrcmE4ZmogZx7/tltbex/t280qptY9FEYXygvr7jqHeQ3vOdKrjKy1T0S7RbHhYzD+vgZb6XTXCFAtlzmgt7o54uC9yLk04jpQCsb9qwwYikq LiFtUWOV W7tJ9OiNq6Mo+qEigQ6/7xzouk6scTIzJJQZCl91zTbv0pBmn3NttRFevt9E8mYtNpasvtdGj21k4qwELMAASHkwJQZRiT5jggoyu6rEDIKrYeF364C91/apbYWOJlApilFA6JAruoXF1idNytNx134SqUFAOGuQgqm9eTSfM1Fa9u9rlh5Rx28tV3zyKbAKDuk/Sb8HjOXU1kivt864d4nBf6kt+gupb7jlB8/NgRL8M+K1BG8UKSnVSQmq4djRJ0ghsCytr8UHAhxwquKURWUbe8rEO2hGFYCmRJrttB2vhZd85LR1ILrAIBDsEXxnOh6+5T7zndEDrskynojWQnL8hAdRb2i4+/wcprOgdHmDRTseXAYVbMke7byYr9mawvu/8IOJChD5hy7e+kh0ehweKbFgJVlQPeCCTxRIS9Ov1gjoXG/KeaohDqSf9kPkHfgvO8Zt+wvGBl3ztqDm29wqYBf5pe2HpZigdoGxl3QA1MUyPg/nkHGwSg1KIELU1EVHHoQH3fKenhefQ7XOkKGtwn8sFwQLZv3etmBT9pOrxQc6KBBE0k0WtGgV19IY+HBdKrK75TKY7KtFBU35YmhIhWecRI6WpR9tpA8ME7HWhC4chvKXzkzWSEkoV8rbm/r5CnCVyqBIRZ+7ls7WuI7PxpjuLGkHGH6cFHS6/QdzXz8PEGUzRBgH0IHJ+/Aq9U4EGJ+sRm7MnWjaebwKno0DHn8OhYfo94D8t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -----Original Message----- > From: Shakeel Butt > Sent: Friday, May 12, 2023 5:19 AM > To: Zhang@google.com; Zhang, Cathy > Cc: Eric Dumazet ; Linux MM mm@kvack.org>; Cgroups ; Paolo Abeni > ; davem@davemloft.net; kuba@kernel.org; > Brandeburg@google.com; Brandeburg, Jesse ; > Srinivas@google.com; Srinivas, Suresh ; > Chen@google.com; Chen, Tim C ; You@google.com; > You, Lizhen ; eric.dumazet@gmail.com; > netdev@vger.kernel.org > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a pro= per > size >=20 > On Thu, May 11, 2023 at 09:26:46AM +0000, Zhang, Cathy wrote: > > > [...] > > > > 8.98% mc-worker [kernel.vmlinux] [k] page_counter= _cancel > > | > > --8.97%--page_counter_cancel > > | > > --8.97%--page_counter_uncharge > > drain_stock > > __refill_stock > > refill_stock > > | > > --8.91%--try_charge_memcg > > mem_cgroup_charge_skmem >=20 > I do want to understand for above which specific condition in __refill_st= ock is > causing to drain stock in the charge code path. Can you please re-run and > profile your test with following code snippet (or use any other mechanism > which can answer the question)? >=20 > From f1d91043f21f4b29717c78615b374d79fc021d1f Mon Sep 17 00:00:00 > 2001 > From: Shakeel Butt > Date: Thu, 11 May 2023 20:00:19 +0000 > Subject: [PATCH] Debug drain on charging. >=20 > --- > mm/memcontrol.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/mm/memcontrol.c b/mm/memcontrol.c index > d31fb1e2cb33..4c1c3d90a4a3 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2311,6 +2311,16 @@ static void drain_local_stock(struct work_struct > *dummy) > obj_cgroup_put(old); > } >=20 > +static noinline void drain_stock_1(struct memcg_stock_pcp *stock) { > + drain_stock(stock); > +} > + > +static noinline void drain_stock_2(struct memcg_stock_pcp *stock) { > + drain_stock(stock); > +} > + > /* > * Cache charges(val) to local per_cpu area. > * This will be consumed by consume_stock() function, later. > @@ -2321,14 +2331,14 @@ static void __refill_stock(struct mem_cgroup > *memcg, unsigned int nr_pages) >=20 > stock =3D this_cpu_ptr(&memcg_stock); > if (READ_ONCE(stock->cached) !=3D memcg) { /* reset if necessary */ > - drain_stock(stock); > + drain_stock_1(stock); > css_get(&memcg->css); > WRITE_ONCE(stock->cached, memcg); > } > stock->nr_pages +=3D nr_pages; >=20 > if (stock->nr_pages > MEMCG_CHARGE_BATCH) > - drain_stock(stock); > + drain_stock_2(stock); > } >=20 > static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages= ) > -- > 2.40.1.606.ga4b1b128d6-goog Hi Shakeel, Run with the temp change you provided, the output shows it comes to drain_= stock_1(), Here is the call trace: 8.96% mc-worker [kernel.vmlinux] [k] page_counter_c= ancel | --8.95%--page_counter_cancel | --8.95%--page_counter_uncharge drain_stock_1 __refill_stock refill_stock | --8.88%--try_charge_memcg mem_cgroup_charge_skmem | --8.87%--__sk_mem_raise_alloc= ated __sk_mem_schedule | |--5.37%--tcp_try_r= mem_schedule | tcp_data= _queue | tcp_rcv_= established | tcp_v4_d= o_rcv