From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35064C021A0 for ; Thu, 13 Feb 2025 19:34:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFA74280002; Thu, 13 Feb 2025 14:34:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA9FD280001; Thu, 13 Feb 2025 14:34:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7199280002; Thu, 13 Feb 2025 14:34:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 88D0D280001 for ; Thu, 13 Feb 2025 14:34:13 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 28A9D4BAB3 for ; Thu, 13 Feb 2025 19:34:13 +0000 (UTC) X-FDA: 83115922386.08.6BB0AF3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 71CB616000E for ; Thu, 13 Feb 2025 19:34:11 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=habiQrF5; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739475251; a=rsa-sha256; cv=none; b=buXCuN9tSoLp8fmdWZ/zOT2wCwYUTg5vy4SIe0VM7w8BMa75MQR4Iktkqs8eu8/B2QMO9o cTDxD6H8fp/fkSQ1aN73gIa4zw+vpdSkhh+2qjOgteuOYCSCavYoaraKvTelGZrhCvJ2e2 a5TlUFtd8YRbfPB2nWNbMYvx5yvmP8I= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=habiQrF5; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739475251; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aAsAYp5qdA7qcM6N66OGFgv1XSJW3NuMEz1anWx4yCM=; b=TnEFzP/W7ch8fn6433TYubYuwxOJdiAuBeIJNM5ExeE0rQXMhoood6k0bS6wU7nC+v0MpL OD3LQJUxE6arH5W+mretYDxjjx2OUoQK1iF2TTn49UibeSiCDBA26BsOMh6ttKwpkSIlzB Wojdge0MMjDO2Iz8QbpEXpc6PB9hhbE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9740D5C57FC; Thu, 13 Feb 2025 19:33:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A09A9C4CED1; Thu, 13 Feb 2025 19:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739475249; bh=uxvsjaNh82I1/Ai/fST6DXeHd9m7K/+qT5V12SmKNto=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=habiQrF52mK4Y+HokO0aZIYhVrmehI3PnkD7DXVK+BH104wyltvtNsLqAQbsv+GuX pBc8FSHmfH1ASrLHv4YgiSJH7vszpoEYe+jvILWUFMgNBd43DxQt19t36YCXCYCFmc VFnmHc0ygvHs94FD6NRMlukpe1dcVFQFc0rbF1RhHee+x4hZJWRcg1nouRL704l44n 4mE2LPZAbSBvanFTpP3ZhUKZ49u0zDR/cxCkLf+nTwldPBpW8IjWvcWL6TxfL7kCDB SEQD7I401n7ANI8/jz10ufHNX6gbPETFzw3A/cQZ4ZKjudj1deJ6nVL0SfdywK+WnG XylqhC58Ip4Zw== Date: Thu, 13 Feb 2025 11:34:07 -0800 From: Kees Cook To: "Liam R. Howlett" CC: Lorenzo Stoakes , jeffxu@chromium.org, akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Subject: Re: [RFC PATCH v5 0/7] mseal system mappings User-Agent: K-9 Mail for Android In-Reply-To: References: <20250212032155.1276806-1-jeffxu@google.com> <202502121401.B6EF2D4517@keescook> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 71CB616000E X-Rspamd-Server: rspam12 X-Stat-Signature: 48j9ug345ox99nyt18ny1pk1erptqd9o X-HE-Tag: 1739475251-874595 X-HE-Meta: U2FsdGVkX1/2DW2Gzd9TyJAWoMIQG4JjvjzlaEO3Xu/ZhXZIC1woLQ/Cd0CoLlLK4ZBNUBGvDgwXNcZN/o3xw31pSWc61FPSc05nb5q4bBOK+exIPEVHwHUbCvZRpszyCet7/JHJldG+QxoWo00v9aWJ7wzBTuo6dicwIhJx379KD8z69SVqywuDOLoGJj5hdSh2QKvDppdZ7kRpc0vwu/70+Fd6Wpuo3QN4+/Lmh7yE+IqCLRRflxYn33mIF4RRNk4KVOgzUttcldS0oRG082F/rv8NHNPRGK1oor7Okvqkwb3fDxp9Ek00uybog7nCdPxamIfTqFP7C3UVYX8Am2RinosKSLbVHJ83TBfUjPWwoH8tZmQRffgvFEiwWF7prmR/GyrPFnqMZShWiadVMLgve0Igol5nRDRwpLOPx0j+qcpXTRu9w22Y7Gn0tc3S5Ad3nN3qOJz0qHpJUvG0uRFeS5KhfxyHx7l8xApLUuPKrKnVXO9xj1ZFkbB/eoMHa1pZygNQYI6fLtd2yln/wOmLx52VdnMbSvoVLo9flEWpfd5LexbeEv1EUHZt0QXlPYFlPwIqYYmdJyPhc1Mp7FJoVYa1mpw89pLcaWlZHdC6SDDNWONAAMCOxpmCdTlA8BycTAw0X/iJtnjX2dFeiHJCV8IeST+KwIIVFt66Yb2YKXjlQd/X+OEioHouSzxCZmxTegPf85uvkkyXCSluzSjdG2QAKXLkX6it1gez1s+jVYwux61Ohqf1Bg6Ut88mApFoSFLiZei6rtKdYULOqiCV9zo/ts/n+z/5IM3EIZcaSpWrMD5mNM0Rne6W/AppZoDJuapAlpfq8GtfYkSuoc8q6mwqO08WVqmeG8M6nz4JDXxGaK2oToP1hf52Zz3Nc7HPoSPKgF5VgcKCPUkSKsxccAkQiO+dAJGVGz5K5pz2TQvM2/kBNNszC1FuyEnI0pW12RysdnMAVA8AUR5 ui9RACkm hnM7WKcM6SMa5kFq+IIruWDGD1+iHmvm+L2I65lpi/FIOMlQe0h4h1IOfuXwcTCGj1Cw+5pEpSyV+G43GN1DfOZsp0wys3vk62YT/xITS/wjGFl7sY3x98AcN+4iH9Zu/ihk9U+ZAMvuEn9vjFwZZ0wRS1fIWFef0yIO0fVUfRxY/3BozPCw211DlMLU+xicDfibpFh09tYAf1ek3usNB/ZF5/UVADTJwksKoyXfe+CCA9ZtvvcNdpk7Ce6apMdDPD1ZiFaJf3pGH70/rFWZs5JDxo29Z64SUBHGiRNF//2eE+BOMqJte9Rs6zMoTMZeTM0cpIESJBYN3qv9Askrb+FKIpoxYZ9khzGscR4o3LWknlvU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002329, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On February 13, 2025 10:35:21 AM PST, "Liam R=2E Howlett" wrote: >* Kees Cook [250212 17:05]: >> On Wed, Feb 12, 2025 at 11:24:35AM +0000, Lorenzo Stoakes wrote: >> > On Wed, Feb 12, 2025 at 03:21:48AM +0000, jeffxu@chromium=2Eorg wrote= : >> > > From: Jeff Xu >> > > >> > > The commit message in the first patch contains the full description= of >> > > this series=2E >> >=20 >> > Sorry to nit, but it'd be useful to reproduce in the cover letter too= ! But >> > this obviously isn't urgent, just be nice when we un-RFC=2E >>=20 >> I advised Jeff against this because I've found it can sometimes cause >> "thread splitting" in that some people reply to the cover letter, and >> some people reply to the first patch, etc=2E I've tended to try to keep >> cover letters very general, with the bulk of the prose in the first >> patch=2E > >Interesting idea, but I think thread splitting is less of a concern than >diluting the meaning of a patch by including a lengthy change log with a >fraction of the text being about the code that follows=2E > >I think this is the reason for a cover letter in the first place; not >just version control=2E After all, we could tack the version information >into the first patch too and avoid it being in the final commit message= =2E Okay, so to be clear: you'd prefer to put the rationales and other stuff i= n the cover, and put more specific details in the first patch? I've not lik= ed this because cover letters aren't (except for akpm's trees) included any= where in git, which makes archeology much harder=2E -Kees --=20 Kees Cook