From: Zi Yan <ziy@nvidia.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/thp: Update mm_struct's MM_ANONPAGES stat for huge zero pages
Date: Tue, 18 May 2021 10:12:11 -0400 [thread overview]
Message-ID: <CCC1BD4E-F6B2-4833-94F9-6AD4C5D46950@nvidia.com> (raw)
In-Reply-To: <1621313300-1118-1-git-send-email-anshuman.khandual@arm.com>
[-- Attachment #1: Type: text/plain, Size: 990 bytes --]
On 18 May 2021, at 0:48, Anshuman Khandual wrote:
> Although the zero huge page is being shared across various processes, each
> mapping needs to update its mm_struct's MM_ANONPAGES stat by HPAGE_PMD_NR
> to be consistent. This just updates the stats in set_huge_zero_page() after
> the mapping gets created and in zap_huge_pmd() when mapping gets destroyed.
>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> This applies on v5.13-rc2.
>
> Changes in V1:
>
> - Updated MM_ANONPAGES stat in zap_huge_pmd()
> - Updated the commit message
>
> Changes in RFC:
>
> https://lore.kernel.org/linux-mm/1620890438-9127-1-git-send-email-anshuman.khandual@arm.com/
>
> mm/huge_memory.c | 2 ++
> 1 file changed, 2 insertions(+)
>
LGTM. Thanks. Reviewed-by: Zi Yan<ziy@nvidia.com>
—
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2021-05-18 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 4:48 Anshuman Khandual
2021-05-18 14:12 ` Zi Yan [this message]
2021-05-21 2:17 ` Hugh Dickins
2021-05-21 4:18 ` Anshuman Khandual
2021-05-21 5:56 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCC1BD4E-F6B2-4833-94F9-6AD4C5D46950@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox