From: Muchun Song <muchun.song@linux.dev>
To: Oliver Sang <oliver.sang@intel.com>
Cc: Yu Zhao <yuzhao@google.com>,
oe-lkp@lists.linux.dev, kernel test robot <lkp@intel.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Frank van der Linden <fvdl@google.com>,
Matthew Wilcox <willy@infradead.org>,
Peter Xu <peterx@redhat.com>,
Yang Shi <yang@os.amperecomputing.com>,
LKML <linux-kernel@vger.kernel.org>,
Huang Ying <ying.huang@intel.com>,
Feng Tang <feng.tang@intel.com>,
Yin Fengwei <fengwei.yin@intel.com>
Subject: Re: [linux-next:master] [mm/hugetlb_vmemmap] 875fa64577: vm-scalability.throughput -34.3% regression
Date: Mon, 15 Jul 2024 10:40:43 +0800 [thread overview]
Message-ID: <CB8E06DE-0DB7-4605-AB19-19CF4F0F17B9@linux.dev> (raw)
In-Reply-To: <ZpPD4Mz3t5xT87aN@xsang-OptiPlex-9020>
> On Jul 14, 2024, at 20:26, Oliver Sang <oliver.sang@intel.com> wrote:
>
> hi, Yu Zhao,
>
> On Wed, Jul 10, 2024 at 12:22:40AM -0600, Yu Zhao wrote:
>> On Mon, Jul 8, 2024 at 11:11 PM kernel test robot <oliver.sang@intel.com> wrote:
>>>
>>> Hello,
>>>
>>> kernel test robot noticed a -34.3% regression of vm-scalability.throughput on:
>>>
>>>
>>> commit: 875fa64577da9bc8e9963ee14fef8433f20653e7 ("mm/hugetlb_vmemmap: fix race with speculative PFN walkers")
>>
>> This is likely caused by synchronize_rcu() wandering into the
>> allocation path. I'll patch that up soon.
>>
>
> we noticed this commit has already been merged into mainline
>
> [bd225530a4c717714722c3731442b78954c765b3] mm/hugetlb_vmemmap: fix race with speculative PFN walkers
> branch: linus/master
Did you test with HVO enabled (there are two ways to enable HVO: 1) adding cmdline with "hugetlb_free_vmemmap=on"
or 2) write 1 to /proc/sys/vm/hugetlb_optimize_vmemmap)? I want to confirm if the regression is related
to HVO routine.
Thanks.
>
> and the regression still exists in our tests. do you want us to test your
> patch? Thanks!
next prev parent reply other threads:[~2024-07-15 2:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 5:11 kernel test robot
2024-07-10 6:22 ` Yu Zhao
2024-07-14 12:26 ` Oliver Sang
2024-07-15 2:40 ` Muchun Song [this message]
2024-07-15 4:08 ` Oliver Sang
2024-07-17 7:52 ` Janosch Frank
2024-07-17 7:59 ` Christian Borntraeger
2024-07-17 8:36 ` Yu Zhao
2024-07-17 15:44 ` Yu Zhao
2024-07-18 9:23 ` Marc Hartmayer
2024-07-19 8:42 ` Oliver Sang
2024-07-19 16:06 ` Yu Zhao
2024-08-03 22:07 ` Yu Zhao
2024-08-06 3:01 ` Oliver Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB8E06DE-0DB7-4605-AB19-19CF4F0F17B9@linux.dev \
--to=muchun.song@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=fvdl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=peterx@redhat.com \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox