From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0E0C3ABBE for ; Fri, 9 May 2025 01:33:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45EBD6B000A; Thu, 8 May 2025 21:33:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40DCD6B0082; Thu, 8 May 2025 21:33:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 287326B0083; Thu, 8 May 2025 21:33:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0AAE36B000A for ; Thu, 8 May 2025 21:33:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D0DC6140228 for ; Fri, 9 May 2025 01:33:32 +0000 (UTC) X-FDA: 83421647064.20.EED316B Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2052.outbound.protection.outlook.com [40.107.96.52]) by imf10.hostedemail.com (Postfix) with ESMTP id B7951C000C for ; Fri, 9 May 2025 01:33:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=s6j7Hv1q; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf10.hostedemail.com: domain of ziy@nvidia.com designates 40.107.96.52 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1746754409; a=rsa-sha256; cv=pass; b=tHGm2PB2uHomWFBRaC5Y6gPHZcsqlRYyvhBSA6VBVFa3JOO7FbTRGa37BKtENBf34ooigg HBovNe2buOntYjqHxPbquz3VEH49MbVClNmfSzPf8JAoydzxC2tn4I/bS6jiGimGGe04iV VJGq1+HqEtW+RbUq6SWtZroYeaG8Wzc= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=s6j7Hv1q; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf10.hostedemail.com: domain of ziy@nvidia.com designates 40.107.96.52 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746754409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FkayOtgP4XP3K+uLWM+5PLbGDpZLfnrx6G2TcMxNVtE=; b=zPQJcbD/ZQY3fOWS13RoxN2PDKg0w7mwlVz/D/gHKc3je2LY62rR2sNQ2Dvr+FwBd4loPQ 8HKQ2kVYr3EVvh5GutmqX7qjM2oyxJ5z+8QXLwVzYQVT4Np7K8xRC+tc09nMlfaBnj7L/1 IZDQABbKSl4TPOqFOo22dglJNADKg7M= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yDf4Q/QLbSWnpLJectXAP6oBsoZwRCu6qQIK+lnOSmwurubFQbXs9On6dR2/NtYz6ycdlXpUTg2AVPR9hrE64a3D8PWSKMK6M5wmNe2+Y7trjjghmp5DQKgb+pX/13IUZh+caQpTbILhJyrVge8P6Iqs2K/AVTYUAbHRmO7LSNuW19f/PNArF+nKeI/KDyO4Ze58cMakas9mFb432unWUw8hFbY7SrNRn23YLq5/lT0faK4jr8MbmMeQ2m+mRVC501npwXhs0Jo5+HHmkrnBKilg1JG46LJptXdRyQjWXGSneJCDiVgO88hPaqBaFUJtWwMm3Z8IaeuBMF7lM+IvMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FkayOtgP4XP3K+uLWM+5PLbGDpZLfnrx6G2TcMxNVtE=; b=mKajxDqVSflkPcLHeDt8znS3X4CLa9+btMpkFfRoiwRKEioW8s4f/iZzMSjB4JLXafbQ5h5OkrcvAPR69KvlLBSGUR64AofdH4O1JG3QYxPQ57ltKKaD3l/xbGV27/E8/Lgpyv3OvhgnnTlHD8l0+TgjAX6ET2vCjweP5/iJBErfWA4kWotY51Kbmf+5cJk+Gk9rDcIhxG1dQfiw9wiPNX5UWAOLmAwzL/2BsVGVLoj/w0G5Z9aIPJ+nOhlW1cD8M7oP45VIDwF6YHQ+X2lcLSf19Nr97XGnUYeiYQP0w8TWFwbRIb0nWqzY1qmpsh/imhLFeHF/EAAZlhqIwFD7JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FkayOtgP4XP3K+uLWM+5PLbGDpZLfnrx6G2TcMxNVtE=; b=s6j7Hv1qkJoHkAYPHngCfo+0HD5yi7Xg7DExvAn63jT12C+WE1cuMo2aWi6E0hns+SIneGCMrZWnplczghXO6ElefYSqXuNA6Aj3G2g9lUyG13wz7DC6zIWPf7XMoPctJzvsF69X8zZu1Gw2zc9UZ9E04GJ7bRY7fyQorlzIRALEacI2llagcLCIT7FZ9jiH2o1nvkPD5feYESx1P4E6s9mbSa4PgQ0QWr6nOUNNibNB9aVUgPIE2rTMC4f2xWdVtMDnUqVh/IhUH1i9DrNr5cRSn36/WxpJgjZgZLNP5nL3fjZzAOF3rnVS6ZfeKBw5zcV0m8CAZZzHAEVrkjrofQ== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by CH2PR12MB4120.namprd12.prod.outlook.com (2603:10b6:610:7b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.21; Fri, 9 May 2025 01:33:22 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8722.020; Fri, 9 May 2025 01:33:22 +0000 From: Zi Yan To: Johannes Weiner , David Hildenbrand Cc: Andrew Morton , linux-mm@kvack.org, Oscar Salvador , Vlastimil Babka , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] mm/page_isolation: make page isolation a standalone bit. Date: Thu, 08 May 2025 21:33:20 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: In-Reply-To: <10C2C1DD-A6E2-4745-8C2E-D09886F4104E@nvidia.com> References: <20250507211059.2211628-1-ziy@nvidia.com> <20250507211059.2211628-2-ziy@nvidia.com> <20250508052409.GB320498@cmpxchg.org> <13898284-B62B-412D-A592-856406F7D7C0@nvidia.com> <20250508204644.GB323143@cmpxchg.org> <10C2C1DD-A6E2-4745-8C2E-D09886F4104E@nvidia.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN9PR03CA0687.namprd03.prod.outlook.com (2603:10b6:408:10e::32) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|CH2PR12MB4120:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d2b9ada-c2ae-42fd-a8af-08dd8e997c3e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?dUgEkSX8PxYNTXih/ukfMkUN83wxDwXyU5ytpjkWgzxt5WsUiLIiHc4tFT+v?= =?us-ascii?Q?R5iM5q8gv/OCkyG3ylIKtRD8jjF6E9uRXDBFU8aBL1PPWx6tn8Whc0SEE8CN?= =?us-ascii?Q?J5kYNELhaiusR9KS5SASbCL1lhyPXeTQqN+++DY+NXvvXM7VSNYSb13O8wun?= =?us-ascii?Q?gXQPBc5xj8SEvZeRga4Hj8i5CCDMjirLST3x+cwV/9EWKeY+FH4NO04TqLas?= =?us-ascii?Q?bvBZiY1Kcy0LQNfTmtWGDGILWt+pITCLleJF5JWHWi3kRAK0ymlZQ/Co5jdE?= =?us-ascii?Q?9Q3A8UDAnbcIC8pwlULegJ5b9w/aOc0jMKB43/4cpTMhldpJvw1SEBMhPuF2?= =?us-ascii?Q?R2RqCbSjFv8zJXUSrW95s0jy0cL86OGvgNFJmhB0AKGsCRVOnBClONqAJ10o?= =?us-ascii?Q?bXi+zr8zHRxX+BaXhyt0kqAwqyNXR31rtDu9hyG2df+Rzud+Ni/ls8cyptZQ?= =?us-ascii?Q?k5PuXOoJZda/VF4OjvRd9ptz6U/OH7SxEL9i3rEauPlxWTGi4OQYjWkRAV8a?= =?us-ascii?Q?updLjVctDoV8qPAbwkJlODJ5kl8f2Wqel30B+VVaqFkSHuXSdlsrJP9+pqqI?= =?us-ascii?Q?7fF3QaPWr5a6Zq1XR1pyPz4jyvFKRT4aRxH6GPn6cvjOq1zprsWUsbEsw4N+?= =?us-ascii?Q?+O7tFpdQWmmH4VW/mNzmy10GOp7VBTGh10BAknrXyTyOm3Nq0CbKkWLSMrAF?= =?us-ascii?Q?N684EWOS05eHtkCQsiZWQEHDGf5vwup4kTlr7aEopYiku8/GsIa+QQXQnne6?= =?us-ascii?Q?hNUNc5/k9tQ88PX2ZCt/RfZzoLk1Ctvr+ij5d8jrtKq1LADeNHzlKTZrElBI?= =?us-ascii?Q?W5RIBvBUZ+S9wv23zDLbohHmK/vV7pgnYij45fG2Yh5k7Tuy9Om++J2HERvC?= =?us-ascii?Q?73gVTJfL32FIGYYik68o/X+fCwy0i9rfFTifrV4clD0VQW5Av/XM8bfbYopq?= =?us-ascii?Q?evyHn8v396pByMLhgWNOJqMVFFNOkS20HmZQJpuaJtxPTLkEMcE95Reb01a6?= =?us-ascii?Q?XQcummLjzEX66fCrUDpuPupghnyV9yFJ0LQpz5OnjUcjis73o/8Mblollp3o?= =?us-ascii?Q?LA/5hEmXGfQAPpxJ2n5edN0V6Sbn+ZBvxLKEyofGrTn+BMIN5ZU8udzALXbR?= =?us-ascii?Q?qUX3GL2gfMDX9wHk4ERxQAhBKUJrRb5To6OP7otvNmzEi4Y1npF53DS31d7k?= =?us-ascii?Q?5nkYzw+zkLSTqwo9IWqIehiaFVqjkGGXSejdtGMjd6/mZRVrMUtyjRjLRSO+?= =?us-ascii?Q?3Am0xhbeWZjrkLaFUz7qa25HGxRQBmAdy4pUwfdDqnPwLboZl2zkES3Xeuxl?= =?us-ascii?Q?nNUVg2E54Lrk0fN/6uyBm0LjygFEv8laBWEyMN34BjkAx0NNUTC/EjjJ0KoU?= =?us-ascii?Q?WqB810legxlo5meTUZNigDcSzk4i58nOUvqlXHRK6Ei3y+BQ/z20khg4WM1+?= =?us-ascii?Q?aempxHNJsCs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Mt2OE7ceS0DYMgxH9CGtxQM3fpzXYZ+SkXLUvlEvNOnWtkApnfmyLOEC1Jk?= =?us-ascii?Q?JmQIBkavPkWIiiJ4okNov3/wOcktCG4odKPaXEoj55xFmjvt3Kn2zf9OUYsC?= =?us-ascii?Q?jpl84rvFKdxt0+GCiOM9JkPZHm9yUz0o0vpOVt3ZMv6H/BLeXvr5PFo2GuJT?= =?us-ascii?Q?NS+PKag6ke/7YVfKyGUWIkm/yNDB1pETNN2Ul+mEFMDWBlLJ9veNplCiIkhC?= =?us-ascii?Q?cpLAr2ChBrgJeBZ/8+gzx6cOmheOFJxTTyhfe14v0/GUxYAgOcMYUZFuF3Oe?= =?us-ascii?Q?25InMdjbgIAMdoixwFCpl2Eso/XFWkBPHvpzc7ZbenwdhIrtUAWckXK9Y8mf?= =?us-ascii?Q?jV8Im4UpDOPA+k4Et2Qfbd0wLTW6+XYWCKFUe0dnVBx9d/TZhG1987f/tX2i?= =?us-ascii?Q?qr1H6iOqpu0FYT4C3SpRfI0VLBTeUerK4YfY8w2Z6znJQstfJWnSJB2oVVLd?= =?us-ascii?Q?q6RGez/PrTy9o0feLwhAlJDiKnxfg4p02HVF8VZCpXIqea1sHY6YkruOTj6U?= =?us-ascii?Q?GZXzIzygOZqOIZvGwMR0FO/DvmSLEtsmpY/t0hFhjH9GLLHN4p6je5Jb1rvq?= =?us-ascii?Q?+kwFhA+sn+9Vyd2qSeRnSbKbQYo13JSO+41hNA7LJVbD7sdU2KhvDkjuPi50?= =?us-ascii?Q?8m/CUib6/lz6o+jqeCxf32UwJSkvBsAukVa1s5ouWAE5FkuQqOGS7TOvDIgk?= =?us-ascii?Q?WryWS2bYt007EHyZKmrzmmpD6JJ0m/p8uKYxSAVhQQw20TIUGKyFH5DqX4Fu?= =?us-ascii?Q?nM0maU0S90J0OWd3Ye2RduN6Ob1jf655HjzRkTOW90rmPm1YLfazm/JMWcCg?= =?us-ascii?Q?jH8yh4lZZFgd3rH4eNz1Kp7XoZhJrGOma/XknLHWI3fsuXAR3xnHOCfq0i5G?= =?us-ascii?Q?wrYpS0V1mxJTP/B8elskhvOFphz07GEUfyrcwVsfx1h9ko2lnamNVNtTQTD7?= =?us-ascii?Q?zYxYmBZwQRRoClwClu9sEg6T78clWUmfaRK/dMarwjXe8N77i/AAmx34fMIc?= =?us-ascii?Q?mVUtYSrzYWq2Wqb1wrOBujGvb7JFdtLa4dxlqJykCFmVb0xJqx2OwfGf7fGs?= =?us-ascii?Q?VD9/qFq9pMa9nkQrbBnB09QQKnEoEVnm08LYurVenqdIXpM3U4IXw8iqq7Vh?= =?us-ascii?Q?XRY/W7Ru0eIBcCnAQ/fClaVmBFCuMSeKfcvPiKjoLvVZIff/jOTuBbZ3rtVt?= =?us-ascii?Q?l57rcw7BlbXtBiqoHOBIrWSEQingey2LJPIkP1FiSmzTm2O0vYh8CLCzw2Wr?= =?us-ascii?Q?aDW1KiUzVDGg0EgOEh7jPFT0YtFJ/5ZtntycpjxmfDV2brwnJ0AzGwcWCk1Q?= =?us-ascii?Q?LqeS9Ga2PsJ8NwRPc0TVShL8M53ligxKCl62rE1Mtb7WP0377zSxMP5jWsQC?= =?us-ascii?Q?CCv9fAklK65kkY63GdT7C9GpGkihAUpl22RPcKAOwhXzWDRTeteNTE/8DDmZ?= =?us-ascii?Q?+RgXwYBHhHAmPXlgSPlWykZsE/HcjPKulfbFuBN5ThNqw+ZWQoFna6ceGANu?= =?us-ascii?Q?L3zfH9oKDzG+pcU6xNmQAmkLvVolWe8EPypkHjBbBHFSxTCM6MIDpOFFx3eq?= =?us-ascii?Q?OtqeeJA8dwwcuB0WKsGarjvT68sG91ZZTKYpzF1N?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d2b9ada-c2ae-42fd-a8af-08dd8e997c3e X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2025 01:33:22.3334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bNVrvzXatKxDFiiJ9y1Z/K9lSKIlrb9syLlFROvIm5A1zfJTUXTiXQh76Wr/5FAX X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4120 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B7951C000C X-Stat-Signature: duahmodftz59p4rwew3mw9zpo6c9uzfk X-Rspam-User: X-HE-Tag: 1746754409-610219 X-HE-Meta: U2FsdGVkX1+SE1erhjDqLwdyiGhOt7WkKiiNeTXy8k7WiC+rMvxgU71ZkFik/1CqL7x3T63CUXdVVZqe6RSdNqRyva9dDSFRuljyL2kKDOzxUChLqw6C1RLa0Qd4UXj/2OOkT4aFyhtgrm3vlePumQiCqx+Aeuy9yXCl/thvdOZjq9jyWLlFaQlsRil/Y/P00CkQNO2/8hAxmchgnJzr6IJ8Hkvuo6gpXpwU1GXzIana2h2DcLVMSUZlqtRmpnqukWR1Zu9ri982YYs7TkqaNCQDTN7iaoj3DNHV32AwZOmnXVEVblS3MCReB/wAsqy8cNkr8qtUu9rmn87qRq7pwaZlHQ+QybAoOVrF/TE63j6kosSmabHGW06xQIoKzlQTmCu2HKdhdSNtRekFvl/Ky5LCMmxONaUNYmIGfnfwP25zXP28uCT4CZAOAPw6ch4F3fJcPsGL1WgjlN4EcB0+Nl93eP2XNX4QgsoIfhvcqu3w42kNeh+DjH0tHzv67jI+LtC3uthk/1N8FsN7ATksF4dw+Ps0A4w4lq/IPuY9+syKG72uVWwqT9oUWZ/lvopuPWZ1La6AXJEbi1+AkrFUt2SVYWbo9ZshRrc21LIvPCsypnZUX+pBF388X9dn3OCZkVD8tbOd9OsjCnwQgymFDg/d2g4s5EZnu6eZdRmLHNxGH3EHvlT1up+BBz4recb6+ZqiT+3e3xNBG/9PGW0MnP+4T8SQjYnXQEjk7u0mNbPmOkbNi/8jiTdzhSni2JpdjqBh+v3FqOtM8VxFlNk0BPGPDIWUyYaV1wd+BtwAk8Ll+BHtX4pFkzHPiaTrgsACBkB2sTBesXQYeLwTKwH1B5mvUHwU0wdlXaS3ZA6IwJH4xHi+s75rRfMtFtjpGVXXbRihcIzxgoUxIxlM3IAr6IjfOWk0vi1vFkfN8DK7OLs7W5XJGhd0zxunwTzX2AOkmV5jr0YGq04hwN0FN+5 0/5ES1AS ZSHUwpqW+/U8wEN0qNT3Ug1rMuTlZkL7u7tlA3Yy/srKSRhumKvBhmHPapAMj4GTW/46nCCYRgN+641/eMhP6qT+34IyFwcM7/vRa6rHfBFnnU0q8goA4LARQi0qaF3ZCfVaCOwLLgLHkWQPODTys/fxvLYB6YNsmdQ2s+JajGCMmeVPsxUqteCbkv/ZjneTxNStJpC7xvviQ5jMynUwP+whvQSXsW+YOHqhZ3AeE5EqrqaOTM7kWjmzEB7nqIuaYqVYwYABsXmAmjCOi0DgMfy+J3YqVgMWh2BT/8qBCdtkedNE29hQM0uiVw+KiplX1BaP9TE7rrlLnfYI/Uw7lzCxhzHEyX6ICbJJGchfOlBtA6HCKAG25EJpAgXRQurXUm5gDXGu1yxary+7Vj3YU1kjGTFZiH89EL1ko X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8 May 2025, at 16:53, Zi Yan wrote: > On 8 May 2025, at 16:46, Johannes Weiner wrote: > >> On Thu, May 08, 2025 at 03:17:05PM -0400, Zi Yan wrote: >>> >>>>>> @@ -426,7 +460,12 @@ void set_pageblock_migratetype(struct page *p= age, int migratetype) >>>>>> migratetype < MIGRATE_PCPTYPES)) >>>>>> migratetype =3D MIGRATE_UNMOVABLE; >>>>>> >>>>>> - set_pfnblock_flags_mask(page, (unsigned long)migratetype, >>>>>> +#ifdef CONFIG_MEMORY_ISOLATION >>>>>> + if (migratetype =3D=3D MIGRATE_ISOLATE) >>>>>> + set_pageblock_isolate(page); >>>>> >>>>> Are there paths actually doing this after the second patch? >>>>> >>>>> There are many instances that want to *read* the migratetype or >>>>> MIGRATE_ISOLATE, but only isolation code should be manipulating tha= t >>>>> bit through the dedicated set/toggle_pageblock_isolate API. >>>>> >>>>> If there isn't one, it might be good to enforce this with a VM_WARN= >>>>> instead. >>>> >>>> I checked all set_pageblock_migratetype() callers and do not see >>>> one using it for pageblock isolation. Let me replace the code >>>> with a VM_WARN and add a comment to tell users to use dedicated >>>> pageblock isolation APIs. >>>> >>> >>> Actually, move_freepages_block_isolate() calls __move_freepages_block= () >>> to move free pages to MIGRATE_ISOLATE pageblock and >>> set_pageblock_migratetype() is used inside __move_freepages_block(). >>> So the branch has to stay. Will use the suggestion below. >> >> Ah, good catch. But looking at the callers, it's: >> >> move_freepages_block() >> move_freepages_block_isolate() >> try_to_claim_block() >> >> The last one would benefit from having the set_pageblock_migratetype()= >> there explicitly, as this is what this function is supposed to do. It >> also should never set the isolation bit. >> >> move_freepages_block_isolate() has two set_pageblock_migratetype() >> calls already. And after the series, it should only manipulate the >> isolate bit, not change the actual migratetype anymore, right? >> >> Maybe it makes the most sense to move it into the three callers? >> >> And then fortify set_pageblock_migratetype() after all. > > Sounds good to me. Let me update my fixups. Hmm, hit another roadblock. In online_pages() from mm/memory_hotplug.c, move_pfn_range_to_zone(MIGRATE_ISOLATE) calls memmap_init_range(), which uses set_pageblock_migratetype(MIGRATE_ISOLATE). I could use set_pageblock_isolate() in memmap_init_range(), but that requires move set_pageblock_isolate() out of mm/page_isolation.c. The change might be too substantial for a fixup. I also would like to get some opinion from David on this. So I am holding this fixup and will send it out as a separate patch when I get more information. -- Best Regards, Yan, Zi