From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yh0-f54.google.com (mail-yh0-f54.google.com [209.85.213.54]) by kanga.kvack.org (Postfix) with ESMTP id E1CDF6B0036 for ; Wed, 14 May 2014 04:34:16 -0400 (EDT) Received: by mail-yh0-f54.google.com with SMTP id i57so1398236yha.27 for ; Wed, 14 May 2014 01:34:16 -0700 (PDT) Received: from mail-yk0-f179.google.com (mail-yk0-f179.google.com [209.85.160.179]) by mx.google.com with ESMTPS id a63si1250364yhk.189.2014.05.14.01.34.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 14 May 2014 01:34:16 -0700 (PDT) Received: by mail-yk0-f179.google.com with SMTP id 19so1290689ykq.38 for ; Wed, 14 May 2014 01:34:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <53723ACC.7020500@codeaurora.org> References: <1399390209-1756-1-git-send-email-steve.capper@linaro.org> <1399390209-1756-5-git-send-email-steve.capper@linaro.org> <53723ACC.7020500@codeaurora.org> Date: Wed, 14 May 2014 09:34:16 +0100 Message-ID: Subject: Re: [RFC PATCH V5 4/6] arm: mm: Enable RCU fast_gup From: Steve Capper Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Christopher Covington Cc: "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , "linux@arm.linux.org.uk" , "linux-arch@vger.kernel.org" , "linux-mm@kvack.org" , Anders Roxell , Peter Zijlstra , Gary Robertson , Will Deacon , "akpm@linux-foundation.org" , Christoffer Dall On 13 May 2014 16:31, Christopher Covington wrote: > Hi Steve, > > On 05/06/2014 11:30 AM, Steve Capper wrote: >> Activate the RCU fast_gup for ARM. We also need to force THP splits to >> broadcast an IPI s.t. we block in the fast_gup page walker. As THP >> splits are comparatively rare, this should not lead to a noticeable >> performance degradation. > >> diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c >> index 3387e60..91a2b59 100644 >> --- a/arch/arm/mm/flush.c >> +++ b/arch/arm/mm/flush.c >> @@ -377,3 +377,22 @@ void __flush_anon_page(struct vm_area_struct *vma, struct page *page, unsigned l >> */ >> __cpuc_flush_dcache_area(page_address(page), PAGE_SIZE); >> } >> + >> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE >> +#ifdef CONFIG_HAVE_RCU_TABLE_FREE > > This is trivia, but I for one find the form #if defined(a) && defined(b) > easier to read. (Applies to the A64 version as well). > Thank you Christopher, I agree that looks nicer. Cheers, -- Steve > Christopher > > -- > Employee of Qualcomm Innovation Center, Inc. > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > hosted by the Linux Foundation. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org