From: Shiraz Hashim <shiraz.linux.kernel@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: Michal Hocko <mhocko@kernel.org>,
akpm@linux-foundation.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>,
hannes@cmpxchg.org, penguin-kernel@i-love.sakura.ne.jp
Subject: Re: vmstat: make vmstat_updater deferrable again and shut down on idle
Date: Thu, 21 Jan 2016 11:54:49 +0530 [thread overview]
Message-ID: <CAPub14_S6swU_SPzZjx_OwyWhPBzXsfaoQ4Xc4qAKTDbtmjPSA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1601200910480.21388@east.gentwo.org>
On Wed, Jan 20, 2016 at 8:42 PM, Christoph Lameter <cl@linux.com> wrote:
> On Wed, 20 Jan 2016, Shiraz Hashim wrote:
>
>> The patch makes vmstat_shepherd deferable which if is quiesed
>> would not schedule vmstat update on other cpus. Wouldn't this
>> aggravate the problem of vmstat for rest cpus not gettng updated.
>
> Its only "deferred" in order to make it at the next tick and not cause an
> extra event. This means that vmstat will run periodically from tick
> processing. It merely causes a synching so that we have one interruption
> that does both.
>
> On idle we fold counters immediately. So there is no loss of accuracy.
>
vmstat is scheduled by shepherd or by itself (conditionally). In case shepherd
is deferred and vmstat doesn't schedule itself, then vmstat needs to wait
for shepherd to be up and then schedule it. This may end up in delayed status
update for all live cpus. Isn't it ?
--
regards
Shiraz Hashim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-01-21 6:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 20:45 Christoph Lameter
2015-12-10 23:31 ` Andrew Morton
2015-12-11 1:41 ` Christoph Lameter
2015-12-14 18:32 ` Christoph Lameter
2016-01-20 13:52 ` Shiraz Hashim
2016-01-20 15:12 ` Christoph Lameter
2016-01-21 6:24 ` Shiraz Hashim [this message]
2016-01-21 15:41 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPub14_S6swU_SPzZjx_OwyWhPBzXsfaoQ4Xc4qAKTDbtmjPSA@mail.gmail.com \
--to=shiraz.linux.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox