From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0841DC433FE for ; Mon, 10 Jan 2022 22:13:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 836A46B0071; Mon, 10 Jan 2022 17:13:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E6E26B0073; Mon, 10 Jan 2022 17:13:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AE2F6B0074; Mon, 10 Jan 2022 17:13:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 5E5186B0071 for ; Mon, 10 Jan 2022 17:13:11 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 19BA88248D52 for ; Mon, 10 Jan 2022 22:13:11 +0000 (UTC) X-FDA: 79015778982.13.9EFE43E Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf30.hostedemail.com (Postfix) with ESMTP id B0D888000B for ; Mon, 10 Jan 2022 22:13:10 +0000 (UTC) Received: by mail-ot1-f41.google.com with SMTP id g79-20020a9d12d5000000b0058f08f31338so16686884otg.2 for ; Mon, 10 Jan 2022 14:13:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MQn3m3RVdskh1I2ejTr5iTDRKenU/xGmVID+nKXoVF8=; b=AsdpoRnJJ1CZ0PyF+bGL2Q2BE5W4GCuZ37egNIqBd9FsRWTj339kk3vvnXl+2EGREB TjDzwE4v9kr8NfZuGXdiT3w/2iNOMo+8W2PP+d4F/ZvO13gH0dEgDQ3uyTjJbcF8PQfa u9PUygHoc5VdOK4k35n5E8vSbRPP2eZIYlUuFiVA1HqQQtfmJ/3MX9fhkE0hCRWSYVpK bcbosDffTOKmUoD7ta+Xz2ad1TrHNAF9vYy9qonVxrAlBXxd+i9VyBv6ydE0Z4F0c6wv Ca3/M6VZyxJA67Q161RRyosORwGtyp3n3ZLGkZDY6+nMAn2So3zqxYuu59b1EhgNqyIN volQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MQn3m3RVdskh1I2ejTr5iTDRKenU/xGmVID+nKXoVF8=; b=bPidHaWnNQ/kKZCu1LbA41h/89mMjp5cvoyr5fFu0wDjIDEt6roabGsbJVTfd8hbmf LNV79EEW5gLQxyWlaltklYOs9Vx3Ga3MiPPNNpGwN3LkPhRHxGoBR2Oez44lOSakLm+6 FPywJqofG+hT4q0G/jxbYADcT+MasB5mvkDwoBxmgxKn/1geNt2K72EASIaEotHbgkJW iFx6y3Lq3qKcbuvDa+xGMDMRT/fX0ZuAGrLN8EiGwPIJqxPjpRp5JhhoVjhjp1DuKEHQ vTin/MCj4Ohtf6pZQgA9O8E9jYXmbAIBJH6TQvRY/knhljYs/dLo0Mz2+tNif0j2qHXb f9Dw== X-Gm-Message-State: AOAM5337h1SKiFpQQFVtZVMHa+CTk1I8fe3uJFI1F+uRM9aGGIZFEXC7 X+O7GHqqPUM9ckTIRMSAveSE/Xrm57jUG7a9cYU= X-Google-Smtp-Source: ABdhPJxhg8AFiAWbO2SIimhZ3qp/8PEiKubKqry0oWBJJUF+8L4zWen+9WIyk4k2RCINejq/sAsB5+tdp5vqGHaRURA= X-Received: by 2002:a9d:8c2:: with SMTP id 60mr1384719otf.174.1641852790028; Mon, 10 Jan 2022 14:13:10 -0800 (PST) MIME-Version: 1.0 References: <202201060848.nagWejwv-lkp@intel.com> <20220108005854.658596-1-christylee@fb.com> In-Reply-To: From: Christy Lee Date: Mon, 10 Jan 2022 14:12:58 -0800 Message-ID: Subject: Re: [PATCH bpf-next] Fix incorrect integer literal used for marking scratched registers in verifier logs To: Song Liu Cc: Christy Lee , Dan Carpenter , Alexei Starovoitov , kbuild-all@lists.01.org, kbuild@lists.01.org, Linux-MM , bpf , Kernel Team , kernel test robot Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B0D888000B X-Stat-Signature: 3zphzj5mcdbgnk1c3ttpep9m71cez1q6 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AsdpoRnJ; spf=pass (imf30.hostedemail.com: domain of christyc.y.lee@gmail.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=christyc.y.lee@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam07 X-HE-Tag: 1641852790-841976 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 10, 2022 at 1:52 PM Song Liu wrote: > > On Fri, Jan 7, 2022 at 4:59 PM Christy Lee wrote: > > > > env->scratched_stack_slots is a 64-bit value, we should use ULL > > instead of UL literal values. > > > > Reported-by: kernel test robot > > Reported-by: Dan Carpenter > > Signed-off-by: Christy Lee > > The fix looks good to me. Thus: > > Acked-by: Song Liu > > However, the patch looks corrupted. Also, the subject is probably too > long (./scripts/checkpatch.pl should complain about it). > I just checked that even with an absurdly long subject (more than 200 characters), ./scripts/checkpatch.pl doesn't complain. It only complains when the commit message body has longer than 75 characters but not the subject line. What's the maximum subject line length? Christy > Thanks, > Song > > > > --- > > kernel/bpf/verifier.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c > > index bfb45381fb3f..a8587210907d 100644 > > --- a/kernel/bpf/verifier.c > > +++ b/kernel/bpf/verifier.c > > @@ -616,7 +616,7 @@ static void mark_reg_scratched(struct bpf_verifier_env *env, u32 regno) > > > > static void mark_stack_slot_scratched(struct bpf_verifier_env *env, u32 spi) > > { > > - env->scratched_stack_slots |= 1UL << spi; > > + env->scratched_stack_slots |= 1ULL << spi; > > } > > > > static bool reg_scratched(const struct bpf_verifier_env *env, u32 regno) > > @@ -637,14 +637,14 @@ static bool verifier_state_scratched(const struct bpf_verifier_env *env) > > static void mark_verifier_state_clean(struct bpf_verifier_env *env) > > { > > env->scratched_regs = 0U; > > - env->scratched_stack_slots = 0UL; > > + env->scratched_stack_slots = 0ULL; > > } > > > > /* Used for printing the entire verifier state. */ > > static void mark_verifier_state_scratched(struct bpf_verifier_env *env) > > { > > env->scratched_regs = ~0U; > > - env->scratched_stack_slots = ~0UL; > > + env->scratched_stack_slots = ~0ULL; > > } > > > > /* The reg state of a pointer or a bounded scalar was saved when > > -- > > 2.30.2 > >