From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C67C3DA61 for ; Sat, 27 Jul 2024 11:09:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EDAB6B0083; Sat, 27 Jul 2024 07:09:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 276C16B0088; Sat, 27 Jul 2024 07:09:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 117B46B0089; Sat, 27 Jul 2024 07:09:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E69C66B0083 for ; Sat, 27 Jul 2024 07:09:05 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 91B1D16028E for ; Sat, 27 Jul 2024 11:09:05 +0000 (UTC) X-FDA: 82385260650.13.E23DBC1 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf19.hostedemail.com (Postfix) with ESMTP id D303C1A0009 for ; Sat, 27 Jul 2024 11:09:03 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R39ckkML; spf=pass (imf19.hostedemail.com: domain of flintglass@gmail.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=flintglass@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722078493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dyGA8AZ76ZW0HaObW7gN6aW+eUP6r9Fonmffm6ZPj2k=; b=E3CAqJkgzav3HVB7PLJ6Go7dt/VaIcb7oa5J79GLsFdh3lmvq0aG8iE5j8ZEqiquO3W8Vt QgsYIX6UxAoJdPUoCJAQdg+L/hKhJyWsVS9e3nekP+3QJdaZBABHMDPmS+zp0zCKH11hJG HiMkswKpUIchjkTw3MUcUY1O+3/Gr0o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722078493; a=rsa-sha256; cv=none; b=niW53TAb9QSNWdV00qtHTXgmtjdqYY/khnUBVevyLnU6RTYwKZIl5jfT/2QigqlXwd4bRp CbyMVyTaI0nYp19pYsfWIcHQyjdA0WBDKi5ssxmm6NsEo9CqlhQDj6N5RbOcjU+RT29WlC G9nZeF9id3keveX6mU1OsU9IWWZBfWE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R39ckkML; spf=pass (imf19.hostedemail.com: domain of flintglass@gmail.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=flintglass@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-e0b167da277so438666276.3 for ; Sat, 27 Jul 2024 04:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722078543; x=1722683343; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dyGA8AZ76ZW0HaObW7gN6aW+eUP6r9Fonmffm6ZPj2k=; b=R39ckkMLi3u/QOZWq7IDEOJriJyQq78mHyciAAeKEvBF2ySPbX23aeULeJXrIDjrnz IFjNHseUWfzbeRN1toJ3wqInQyTLWfFMDoDLZiOD2UfAnhX0/sNcwGxD23A7BXor+mu0 ffOCYrA+394JvWORDL0HQn5R7t/6AaJnCEHGEtc7+JYUmnBKbtO6vgLIDtudo+dMQQF+ 4XvQl0vTkhdVDU7Zl/OgZaCNyBOBN0+JTmUapPi9xZZpZFZchXYkUyfZv9y+iuMnfu45 2aMCZ596s1+Rycbyk2wEf8IuNYGbOwQcJbh/GAYNhjj420qkT0DS9h14Ei2/rkbAyTPB DZ5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722078543; x=1722683343; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dyGA8AZ76ZW0HaObW7gN6aW+eUP6r9Fonmffm6ZPj2k=; b=oj2hBhNKz8OSL0BRjDQrbpWpnUpmAzKxX4x+SRw3zMunTU86zy+6Sx7ERhzjn6w2CP E8zUkLAr5UzT3faDXDBxAkhi8GO3dhvfuCq2v6H4Esg6voOPKWGoOujUs2ybmk8C9H/E nBoLTpv9yMU+bHlahvH6OgDav9/x2+/8V2WcF/aoaj21v+Wq2zV2YDOpBodIiTMcnqUo SnKdaQBwk+qh72cRY8Mj4p1pkYK33O3pJI2L4gyMCWYt8H6yiUYR1ptfEuZtGfENX04S bb1HlYnk1Idd1ZY5KlYctZPdKkY2P0NAIn6mctc5FWuHxpLRI2kGaKYCC3NsX5jpKNh3 G2Lw== X-Forwarded-Encrypted: i=1; AJvYcCUNSP//Gs67dvNc1af6RtJk5cg6qUCJuOK+O9fysfd4+mRedIS3SsKybcanQBzq3mOhpzmUFq9zwSe8457cojmNHI0= X-Gm-Message-State: AOJu0Yy1X9B6CzfBjAWp4rIml4VIiqlKtluQ9ZlmzTWjI2h/gJ7+Ro4K uSiTFopuYMzQgzcC1sBuCKzGmlV04aCu9NkVk+WRQN493zHtgkaShTC0rmB+/lqrGnGzP1mpAOf pp2CfH1pJaxuo5aErrNAld5xyJY4= X-Google-Smtp-Source: AGHT+IE4cUNs4fbYBQXXFf7cmgW5NJUB50nK5n8y91z/Rt1CbICJX8KXJISgkM7W+4dH01efPZcByAtB5rIvEKGZHAk= X-Received: by 2002:a25:bcc5:0:b0:e0b:46b5:2247 with SMTP id 3f1490d57ef6-e0b5449c832mr2386720276.12.1722078542865; Sat, 27 Jul 2024 04:09:02 -0700 (PDT) MIME-Version: 1.0 References: <20240720044127.508042-1-flintglass@gmail.com> <20240720044127.508042-3-flintglass@gmail.com> <9ac88791-54e2-4f7c-9171-5a1d44e01657@linux.dev> In-Reply-To: From: Takero Funaki Date: Sat, 27 Jul 2024 20:08:52 +0900 Message-ID: Subject: Re: [PATCH v3 2/2] mm: zswap: fix global shrinker error handling logic To: Nhat Pham Cc: Chengming Zhou , Johannes Weiner , Yosry Ahmed , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D303C1A0009 X-Stat-Signature: jphtw5z44jcjtw9stuy7z7gckmcapnwr X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722078543-34368 X-HE-Meta: U2FsdGVkX1+t1Ii0esXTiGCJ+/7vs/YRF8pvcy0Gz9qz95xtB0+fMEyT7RvEUAZHFN5wiwGv/ZLh80COmixOitnuqK8v/Jr4y4tbAiJpPelfI+d04X8piD4SOeLPobpIiMPpNRLFm6rIplga5sPiT5zLcNq5iEZCDphStEtxTAuZPCTmCpljSkz4fylbDQXhFSeHux5mcLESLbEZ7kjjZDgMXeCp74rvQqxAyjZoEuS6nniTIX2joCiJ+VW5L+zaaL8aRpoVKc/Lwg/K1OJ08U6upgetiBCTy2VeNUNUpUbkHmjqp3BvQXbw1JlpKU/sOn8YRgM1xvCv+JYIybbITdTZpx86O0pm+woyDE69E8dUuh/4g9nNi0q43p2iCdKhFX6ihMZ3lPoSecznGl+klFeXGj04qFrwm0mxcox/+ifl1Yo8qmwlm8QFg/HclfImGaPoHQJs4a49FiekEaPq3GNTNE2kTV9F32mj3HuvfDBNwiNLeZf5TfKqPV9CT3GE/xUw21OeOhkuegDSWOTmREsEN5H5Ts2mZ8U8sCMwgZRpqR5kd6P0fRa5yqtCfg4rImmS3i07WfHXCb92JGpfn5M7XLaWDiSf5soSHJwucnOcpIrT+nC1HkVzgdWMmyOMVpWg4OPM9PPoUMh1ttnyE828lMfYgHtWfHSMTRdOhMhWajvcb0AWhOm+sXB88uyboEfS8pcWXg7G54leKrArLpxYikcF8dM2Zg33RygKu0NT7MNnLkAUnSBpY86ztkhU6NbGMvu6slSUI3HgUWy5R+IvEHBrpg7YQQgt+BSUUPz/p6Up9smF+wMzT55h8Z6rJY/8PNsTwpg4SU6bncoMZ5EdnMBJ+TCJjyzpN+/xQs0Mvp075AA+9T7tGoYZsB+UTIHTHElumggcu+fJakZYX0P65Sd/JUbVoad3064DSjaYwQJVLrJNQkYPO9911lus90oqPV/7/9gYE8dgUTm 70L/678Y roJht7SsLiKWdKdiWubtU/lCxSllZLyeJviNFYJBo+LZh+35ANbfoADc65kRiVTozPZGOG7eTU0mFZCCywJvuJ4w8ZZ09JkBRZejjRFCnWONIX8oBfZBAfjHgnbH/rDCT4fVJ6Z9Yj/zbSP1GFZaKZ1+Az4hTlYFDpMzd0x/GHlUKl89m3i0mP9bBml3F19c8cg2oy3ugafqTOCDhtLmG/ZCZi2VsaE53OSvARS2YJ0rxfRLv4Ql4FELt4Ie50AvBGcxbpGuw9IG6iNP2s+bLk0VbFi15w9tp6qoGG9UEb+TB12Jny5AE91JY0Z4/tgnPGHy33chlsk/iclHh+/qYrN5FyOjcfuzCUS7DXzbHhC4sK+P6a2FcDZWn8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001736, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 2024=E5=B9=B47=E6=9C=8827=E6=97=A5(=E5=9C=9F) 3:01 Nhat Pham : > > On Fri, Jul 26, 2024 at 1:54=E2=80=AFAM Takero Funaki wrote: > > > > Yes, the `++progress` counts both error and success as an iteration > > progress for valid memcgs (not writeback amount). Incrementing only on > > success will overly increment failures counter if there is only one > > memcg, one from writeback failure and one from tree walk ends, the > > worker aborts on 8 failures instead of 16. > > `++candidates;` would be better? replacing the name and fixing commit > > messages for v4. > > How about `attempt` or `attempted`? Naming is hard :) Thanks. Rewriting with `attempts` in align with the `failures` counter.