From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E79C433EF for ; Wed, 20 Jul 2022 07:05:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B2646B0072; Wed, 20 Jul 2022 03:05:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 261C86B0073; Wed, 20 Jul 2022 03:05:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12B716B0074; Wed, 20 Jul 2022 03:05:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 007096B0072 for ; Wed, 20 Jul 2022 03:05:42 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A398BAAD4B for ; Wed, 20 Jul 2022 07:05:42 +0000 (UTC) X-FDA: 79706592924.18.EBBBC48 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf29.hostedemail.com (Postfix) with ESMTP id 5A3D8120016 for ; Wed, 20 Jul 2022 07:05:42 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id e15so22584353edj.2 for ; Wed, 20 Jul 2022 00:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WppMfwLGRwNjAXO/HIfr6DsSf5LAYKkxw8k/p1IhbYM=; b=G9HmqzHBvZa1Om+TbiEeBvH1jSF+eJbCzVp7lP5rG86jZeslmEnyRszVWd8TyvlG4p rBXwJwE+AF/kqxB0zwuvpKY3Ug5KnoEEWXOx0olyk3ZpdPBxXhYEkB8o6MpfHjvPmYZJ LkXD4JJxB/4C2mX1l2szTrY6QjfpGR3I0OwnnJ73rHy8FkIN+tDC+6KPShaoLoeD851c ZvUN36/9YNMSrR3euNyXrgngS6kg/5ncBXp0qGdF866GspYN0g0e5AYaUiWpIscRka5e nBxHCWwmVZd+HcRMNoljVxvalB0QwvXUJQBLJM7W9KEjF2MTq4mjGXduT8mBgMGlTsor RgNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WppMfwLGRwNjAXO/HIfr6DsSf5LAYKkxw8k/p1IhbYM=; b=49w2XG+/kZA9uGX5Npm3zHZBzh6m38mGrDisXMWGFVt++U9vo4cjG+u5rewIwtix9p G9U7GF/qOH1IfhuXM5QWzAt5zFBOR0xb9KZKV1LLDK4SBnWDYZ6jAjllFkLjzV9WkYL7 CxG0WUM8HdaojQEs1xoJ8viia4UKagoIbuDMyJOy3fZ0LOB5njmKbafCWLi/1c1jiJNo u37Vy/KLc6KC6w2zIGCxkQnusDlCGkAW2z9o5sS6lqxaVj0zLyUQRTTSvDiCkANchcV3 Gu+TKMhbIfPLFV1VMeceEqczGsm+VqhjH3I41yjYsUyY1AIq3ARcVsCySxlEfcOFE94c eOog== X-Gm-Message-State: AJIora+HL2JpMKj7mRc1+dSJWtWKpoZvwpVjg85zFv3jMpGIvLWtmmoY wGnmDZgys/4yYvQuBjoww4cTKSSGUHZsrin8Ays= X-Google-Smtp-Source: AGRyM1tkhyZ5VNKIW8xVpDaMC8fdp953QHSFStl/BwCZKIWB/gTwzRb8b2h365Kdi3o9aObYTS+YuCUcVcL1qUZMF5s= X-Received: by 2002:a05:6402:2816:b0:434:ed38:16f3 with SMTP id h22-20020a056402281600b00434ed3816f3mr49082161ede.116.1658300741078; Wed, 20 Jul 2022 00:05:41 -0700 (PDT) MIME-Version: 1.0 References: <20220720065744.1006305-1-zengjx95@gmail.com> In-Reply-To: <20220720065744.1006305-1-zengjx95@gmail.com> From: jingxiang zeng Date: Wed, 20 Jul 2022 15:05:30 +0800 Message-ID: Subject: Re: [PATCH] mm/z3fold: do not unlock in z3fold_page_putback() To: vitaly.wool@konsulko.com, linmiaohe@huawei.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zeng Jingxiang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658300742; a=rsa-sha256; cv=none; b=x9szBsj0d3tTXhfCtDcZshfe5ncklf3l6qXhJuYbbTE1Ie4BLO6L23F4SAuMeQgTVw7r9a BPFvi+c39qG1PL+ZuwQmJS7puwJFLYzDsjS+sh8ZamSqT0ThPQ1SQwFOV7amHGZK48yWso ZSjavFR39S/EPxFJ6TnKujiZRoUCosQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=G9HmqzHB; spf=pass (imf29.hostedemail.com: domain of zengjx95@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=zengjx95@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658300742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WppMfwLGRwNjAXO/HIfr6DsSf5LAYKkxw8k/p1IhbYM=; b=TXH3ibrdUsah7mFl29tqMJOLZl+dVXBWx3TjRxxtxhJGvyWMsB50j2S3NapdYW7As1wfce gVHi9IT/RlpTek6IiaJWHhW0NYZlWlW5QZMgAz2YZaM8MM3Rn65gn6iNxIyPSExCTZ/CJG qHXRhmQSaUmZi3VIscCjHfjM3usH37M= X-Stat-Signature: osp4wrc4pjgtjd78gb8sgyxra3s647z9 X-Rspamd-Queue-Id: 5A3D8120016 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=G9HmqzHB; spf=pass (imf29.hostedemail.com: domain of zengjx95@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=zengjx95@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1658300742-489304 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E4=BA=8E2022=E5=B9=B47=E6=9C=8820=E6=97=A5=E5=91=A8= =E4=B8=89 14:58=E5=86=99=E9=81=93=EF=BC=9A > > From: Zeng Jingxiang > > z3fold_page_lock() will lock zhdr->page_lock > 1630 z3fold_page_lock(zhdr); > > return without unlocking zhdr->page_lock > 1634 if (kref_put(&zhdr->refcount, release_z3fold_page_locked)) > 1635 return; > > Signed-off-by: Zeng Jingxiang > --- > mm/z3fold.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > index f41f8b0d9e9a..03785832ad47 100644 > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -1632,13 +1632,14 @@ static void z3fold_page_putback(struct page *page= ) > list_del_init(&zhdr->buddy); > INIT_LIST_HEAD(&page->lru); > if (kref_put(&zhdr->refcount, release_z3fold_page_locked)) > - return; > + goto ret; > spin_lock(&pool->lock); > list_add(&page->lru, &pool->lru); > spin_unlock(&pool->lock); > if (list_empty(&zhdr->buddy)) > add_to_unbuddied(pool, zhdr); > clear_bit(PAGE_CLAIMED, &page->private); > +ret: > z3fold_page_unlock(zhdr); > } > > -- > 2.27.0 > Sorry, I just misunderstood the code logic, please ignore this patch.