From: Robin Holt <robinmholt@gmail.com>
To: Philipp Hachtmann <phacht@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Jiang Liu <liuj97@gmail.com>,
santosh.shilimkar@ti.com, grygorii.strashko@ti.com,
iamjoonsoo.kim@lge.com, Robin Holt <robin.m.holt@gmail.com>,
yinghai@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/nobootmem: Fix unused variable
Date: Thu, 16 Jan 2014 15:25:04 -0600 [thread overview]
Message-ID: <CAPp3RGp2qi0mLnbZv1ZZuKnz+1yqV2gC1LfP3xxhmhosoBNhzg@mail.gmail.com> (raw)
In-Reply-To: <20140116184121.34d1e97c@lilie>
If the definition of the
get_allocated_memblock_reserved_regions_info() function when
CONFIG_ARCH_DISCARD_MEMBLOCK simply returns 0, the compiler will see
that size is defined, the optimizer will see that it is always 0 and
that the if(0) is always false. The net result will be no code will
be produced and the function will be less cluttered.
On Thu, Jan 16, 2014 at 11:41 AM, Philipp Hachtmann
<phacht@linux.vnet.ibm.com> wrote:
>
>> I would think you would be better off making
>> get_allocated_memblock_reserved_regions_info() and
>> get_allocated_memblock_memory_regions_info be static inline functions
>> when #ifdef CONFIG_ARCH_DISCARD_MEMBLOCK.
> Possible, of course.
> But the size variable has still to be #ifdef'd. And that's what the
> patch is about. It's just an addition to another patch.
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-16 21:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:33 Philipp Hachtmann
2014-01-16 15:45 ` Robin Holt
2014-01-16 15:49 ` Philipp Hachtmann
2014-01-16 16:37 ` Robin Holt
2014-01-16 17:41 ` Philipp Hachtmann
2014-01-16 21:25 ` Robin Holt [this message]
2014-01-16 15:51 ` Robin Holt
2014-01-16 22:43 ` David Rientjes
2014-01-17 21:38 ` Andrew Morton
2014-01-20 11:28 ` Philipp Hachtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPp3RGp2qi0mLnbZv1ZZuKnz+1yqV2gC1LfP3xxhmhosoBNhzg@mail.gmail.com \
--to=robinmholt@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=grygorii.strashko@ti.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
--cc=phacht@linux.vnet.ibm.com \
--cc=robin.m.holt@gmail.com \
--cc=santosh.shilimkar@ti.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox