From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12EB0C433F5 for ; Mon, 1 Nov 2021 03:42:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A28D460EE9 for ; Mon, 1 Nov 2021 03:42:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A28D460EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0E2776B0080; Sun, 31 Oct 2021 23:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09D906B0081; Sun, 31 Oct 2021 23:42:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9C1180008; Sun, 31 Oct 2021 23:42:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id D9F756B0080 for ; Sun, 31 Oct 2021 23:42:23 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9C76A3C7B1 for ; Mon, 1 Nov 2021 03:42:23 +0000 (UTC) X-FDA: 78758963766.15.3DEEA39 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by imf16.hostedemail.com (Postfix) with ESMTP id B9064F000091 for ; Mon, 1 Nov 2021 03:42:16 +0000 (UTC) Received: by mail-pg1-f173.google.com with SMTP id g184so16022381pgc.6 for ; Sun, 31 Oct 2021 20:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9m/T3tEE9AvFI5AF08ENDg30EutivubHbOiZ6LEULFw=; b=HAIj9FNozVwsZkatx/GkfIaxyXiWJMRhr1uW89NCB5A8zv6Ev1xYp8+Ohab6FmzYSy WvshEsyNfKi3hBjsvQtCnuxIxgFXrrJiMUbP9kvB+zUcPKJ+x/Y1rVOaa0IG51wruhhY PmklhSmkygYeQZ1JrwwjvEtu6C3QZPZVtx+/HLUqkrT6XoouQLkSzETkm38G1hIVdQrW AyvyT5yl3ELUZYWQX13lRKh3zqGT9nCsHxhBwHyxCmBZUe7li3TWlSX5JJNU4VhQ/G4u fhOYm+AZDdzfI4q3ClzAAV67OtC9bvHo9E/jdZZ4IbOMFbElv3AfTQXf489lkqOD4RHg jb1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9m/T3tEE9AvFI5AF08ENDg30EutivubHbOiZ6LEULFw=; b=5hGlA8lnnKzIBzoMrcLdBoiSFciytkx3bFgRPn/ChzJfLFQInNncRhhVgjwCEqgXjH kDZaDX9RM419apNHU9MzsLsRavJ4TMCPU2v8WA0OkStnc90NeWl5pXfwrs56rAdgm+Oy RYWcZhgZ9r2lrXOIth0Kv1O7MrtSrpVfMx8kSYCMQEPAE/sSNMls8lsjz9whwoxuR3uB fqLD42WxBHcEVjAH5C5k1xyCV+AiyDgZRAkQKq77bFAgazhs9asGWHcBESRe0zIAymaw l4hoes8oXUcr6Ny/odjO2ny2VIhvviO6igyLXcXtEGo3FBpxYzZbsFia7QKxpVexiFd+ BLxA== X-Gm-Message-State: AOAM532hYOEXvY2YGwPq3FbQpsXcwA09H/U1bb7jduu82g1klD6kYarY RCE8hRC5Gppe2/vNZzw3FOeIVxUtKrdQKt4uPWk= X-Google-Smtp-Source: ABdhPJyEIn3u/2Smy0EsjXBK2U3Bz/5JUKne34pHeqNy90R6t5ybdnqjBvBskngEzyg0K7TlXMsDg6m7gnqzcFF00I4= X-Received: by 2002:a63:6205:: with SMTP id w5mr7963347pgb.105.1635738142349; Sun, 31 Oct 2021 20:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20211031060302.146914-1-fuqf0919@gmail.com> In-Reply-To: From: =?UTF-8?B?5LuY5YWo5Y+R?= Date: Mon, 1 Nov 2021 11:42:09 +0800 Message-ID: Subject: Re: [PATCH] writeback: Fix some comment errors To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= Cc: "akpm@linux-foundation.org" , "cl@linux.com" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "vbabka@suse.cz" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Content-Type: multipart/alternative; boundary="000000000000eb9dde05cfb1f6e6" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B9064F000091 X-Stat-Signature: brjb4ddhg8ihqyxz3xtecopazc6tz9t1 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HAIj9FNo; spf=pass (imf16.hostedemail.com: domain of fuqf0919@gmail.com designates 209.85.215.173 as permitted sender) smtp.mailfrom=fuqf0919@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1635738136-525646 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000eb9dde05cfb1f6e6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, I agree. I will make a new patch. Thanks. HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3 =E7=9B=B4=E4=B9=9F) =E4=BA=8E2021=E5=B9=B411=E6=9C=881=E6=97=A5=E5=91=A8=E4=B8=80 =E4=B8= =8A=E5=8D=887:53=E5=86=99=E9=81=93=EF=BC=9A > Hi Quanfa, > > > @@ -1653,7 +1653,7 @@ int memory_failure(unsigned long pfn, int flags) > > > > /* > > * We need/can do nothing about count=3D0 pages. > > - * 1) it's a free page, and therefore in safe hand: > > + * 1) it's a freed page, and therefore in safe hand: > > * prep_new_page() will be the gate keeper. > > * 2) it's part of a non-compound high order page. > > * Implies some kernel user: cannot stop them from > > I think that the word "free page" is common enough and you can find it > in many other files, so it makes little sense to fix it as a typo? > > Thanks, > Naoya Horiguchi > --000000000000eb9dde05cfb1f6e6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, I agree.=C2=A0

I will make a new p= atch.

Thanks.

HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3= =80=80=E7=9B=B4=E4=B9=9F) <naoya.horiguchi@nec.com> =E4=BA=8E2021=E5=B9=B411=E6= =9C=881=E6=97=A5=E5=91=A8=E4=B8=80 =E4=B8=8A=E5=8D=887:53=E5=86=99=E9=81=93= =EF=BC=9A
Hi Qua= nfa,

> @@ -1653,7 +1653,7 @@ int memory_failure(unsigned long pfn, int flags)=
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0/*
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 * We need/can do nothing about count=3D0 pa= ges.
> -=C2=A0 =C2=A0 =C2=A0 * 1) it's a free page, and therefore in safe= hand:
> +=C2=A0 =C2=A0 =C2=A0 * 1) it's a freed page, and therefore in saf= e hand:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 *=C2=A0 =C2=A0 prep_new_page() will be the = gate keeper.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 * 2) it's part of a non-compound high o= rder page.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 *=C2=A0 =C2=A0 Implies some kernel user: ca= nnot stop them from

I think that the word "free page" is common enough and you can fi= nd it
in many other files, so it makes little sense to fix it as a typo?

Thanks,
Naoya Horiguchi
--000000000000eb9dde05cfb1f6e6--