linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: 付全发 <fuqf0919@gmail.com>
To: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"cl@linux.com" <cl@linux.com>,
	 "penberg@kernel.org" <penberg@kernel.org>,
	"rientjes@google.com" <rientjes@google.com>,
	 "iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
	"vbabka@suse.cz" <vbabka@suse.cz>,
	 "linux-mm@kvack.org" <linux-mm@kvack.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] writeback: Fix some comment errors
Date: Mon, 1 Nov 2021 11:42:09 +0800	[thread overview]
Message-ID: <CAPnsg35Y5GucgaSCC_ze8PPKzC7mNmuVa_LYbAd3fOdkPPDgHA@mail.gmail.com> (raw)
In-Reply-To: <TYWPR01MB8591801586B7D2335BE623EEE7899@TYWPR01MB8591.jpnprd01.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

Yes, I agree.

I will make a new patch.

Thanks.

HORIGUCHI NAOYA(堀口 直也) <naoya.horiguchi@nec.com> 于2021年11月1日周一 上午7:53写道:

> Hi Quanfa,
>
> > @@ -1653,7 +1653,7 @@ int memory_failure(unsigned long pfn, int flags)
> >
> >       /*
> >        * We need/can do nothing about count=0 pages.
> > -      * 1) it's a free page, and therefore in safe hand:
> > +      * 1) it's a freed page, and therefore in safe hand:
> >        *    prep_new_page() will be the gate keeper.
> >        * 2) it's part of a non-compound high order page.
> >        *    Implies some kernel user: cannot stop them from
>
> I think that the word "free page" is common enough and you can find it
> in many other files, so it makes little sense to fix it as a typo?
>
> Thanks,
> Naoya Horiguchi
>

[-- Attachment #2: Type: text/html, Size: 1288 bytes --]

  reply	other threads:[~2021-11-01  3:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-31  6:03 Quanfa Fu
2021-10-31 23:53 ` HORIGUCHI NAOYA(堀口 直也)
2021-11-01  3:42   ` 付全发 [this message]
2021-11-01  4:02 Quanfa Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPnsg35Y5GucgaSCC_ze8PPKzC7mNmuVa_LYbAd3fOdkPPDgHA@mail.gmail.com \
    --to=fuqf0919@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=naoya.horiguchi@nec.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox