From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB1CC433DB for ; Wed, 17 Mar 2021 10:09:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BEF2E64F6B for ; Wed, 17 Mar 2021 10:09:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEF2E64F6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 214466B006E; Wed, 17 Mar 2021 06:09:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1ECF46B0070; Wed, 17 Mar 2021 06:09:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B4A06B0071; Wed, 17 Mar 2021 06:09:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id E5BBC6B006E for ; Wed, 17 Mar 2021 06:09:57 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9ED555DF1 for ; Wed, 17 Mar 2021 10:09:57 +0000 (UTC) X-FDA: 77928945234.23.103CC93 Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by imf15.hostedemail.com (Postfix) with ESMTP id 1EBD9A0009EE for ; Wed, 17 Mar 2021 10:09:56 +0000 (UTC) Received: by mail-vs1-f45.google.com with SMTP id d25so717771vsr.11 for ; Wed, 17 Mar 2021 03:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=htUt+GurGJpgnsnU+fyL3V2T4SB+f+UCiAL03abf9N0=; b=oZlUYhGhgHJDT4V0mX8geQmjH/d6ITJjRfU0ZONWtOFMG7iKZFRbZYwz8GGxnkVht2 Vkxd6lAJr19Y7w1WLrUERspUKpVEV1hx+8wrwALVpvOHaR8F8TVP4ckqJgzE55etd/gP eDTb8GTcM3B+CmB63G57ve+mCtU25G8s3ID3vLmv5hD7hMumOFldY/D9o1GCL2Mv7UDd diq0kuJdnWChnYgPsMNk/QUMjUIB88xl6t4KpJ+jSnKp1cxirTEFn0y0wqtXmfwO3AJB n53qzzqj+kHo0lQjgJ1mZNs+lE0ECOBveAIHu3JvOTVEy/dlF2gBRSkvQds1IgBjvo+7 bshg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=htUt+GurGJpgnsnU+fyL3V2T4SB+f+UCiAL03abf9N0=; b=nzb5nMMKJpyY+Y8t5/yGIgQbmGqm70y6G4l3QKaip4dZCSVyygumWnd2ocZBrX4EvS B4tMaOrxudqlWwv78bC8P4el9WyfKy73Mf2XplRfqf7XLSyPF2AZg75bGikbxJE72mNA 2AoyQY+mvKxiR8QCYudAbu2zr8oCHqaqfPrZdgeGYOiknI2EvzNwTUuT+iqBtvdu/9KB Vdc7kTqfHAxanyJgZhGHHAyAIbUMCNI9cRJQAlmWE4mH8ymAVTb7SAx4VFqqpS/eG8Sw YbxZcj+XzWgxVhCNa3ZPakY6qiRofQ7d2bhdKjyDP9+Rf4Wsd6eN5uhmn5e4D9eNGYw3 4CxQ== X-Gm-Message-State: AOAM5307sLftJqos2d4G0vDav2160V1G8GrQMbsOMsug8n+rPy1IRha5 5JFJ84fy5+D0NpJXsCaNxzaVmmC3beWhJ0YGhhw= X-Google-Smtp-Source: ABdhPJy1lcGrNU23BVsh+CJkNEWtl0dyjG0VnN3CFc50o/5/StM8Agr88HcJbVQm8e63PWbuXogLBNql1TJoWtv756M= X-Received: by 2002:a67:cf8c:: with SMTP id g12mr2349192vsm.10.1615975796378; Wed, 17 Mar 2021 03:09:56 -0700 (PDT) MIME-Version: 1.0 References: <20210316124237.3469-1-jarvis.w.jiang@gmail.com> <20210316143756.45ef6d91@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210316143756.45ef6d91@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: =?UTF-8?B?6JKL5aiB?= Date: Wed, 17 Mar 2021 18:09:44 +0800 Message-ID: Subject: Re: [PATCH] Add MHI bus support and driver for T99W175 5G modem To: Jakub Kicinski Cc: davem@davemloft.net, rppt@linux.ibm.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org, cchen50@lenovo.com, mpearson@lenovo.com Content-Type: multipart/alternative; boundary="0000000000004f135b05bdb8af91" X-Stat-Signature: b6aqbenyq4adkdwgde6fbzzqcam9n53h X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1EBD9A0009EE Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf15; identity=mailfrom; envelope-from=""; helo=mail-vs1-f45.google.com; client-ip=209.85.217.45 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615975796-649606 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000004f135b05bdb8af91 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > There's already a drivers/net/mhi/ It seems the latest kernel supports mhi driver, but there is no mhi driver on the 5.4.44 kernel, I want to add it to 5.4.44, is that ok? > Virtio drivers don't sit under drivers/virtio, and most certainly not under drivers/bus/virtio Thanks, however, I will put files into a more suitable location. > Ugh, can you clarify what's the source of this code dump and if you're coordinating with others working on Qualcomm drivers? The source code is ported from IPQ8072 arm platform, including MHI, MBIM, RmNet. No, I have no cooperation with the people working on Qualcomm drivers. Thanks, Jarvis Jakub Kicinski =E4=BA=8E2021=E5=B9=B43=E6=9C=8817=E6=97= =A5=E5=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=885:37=E5=86=99=E9=81=93=EF=BC=9A > On Tue, 16 Mar 2021 05:42:37 -0700 Jarvis Jiang wrote: > > drivers/bus/mhi/devices/mhi_netdev.c | 1830 +++++++++++++ > > There's already a drivers/net/mhi/ > > Please make sure the drivers live in their respective subsystem. > > Virtio drivers don't sit under drivers/virtio, and most certainly not > under drivers/bus/virtio... > > > drivers/bus/mhi/devices/mhi_satellite.c | 1155 +++++++++ > > drivers/bus/mhi/devices/mhi_uci.c | 802 ++++++ > > Ugh, can you clarify what's the source of this code dump and if you're > coordinating with others working on Qualcomm drivers? > --0000000000004f135b05bdb8af91 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> There's already a drivers/net/mhi/
It seems th= e latest kernel supports mhi driver, but there is no mhi driver on the 5.4.= 44 kernel, I want to add it to 5.4.44, is that ok?

> Virtio drive= rs don't sit under drivers/virtio, and most certainly not under drivers= /bus/virtio
Thanks, however, I will put files into a more suitable locat= ion.

> Ugh, can you clarify what's the source of this code du= mp and if you're coordinating with others working on Qualcomm drivers?<= br>The source code is ported from IPQ8072 arm platform, including MHI, MBIM= , RmNet.
No, I have no cooperation with the people working on Qualcomm d= rivers.

Thanks,
Jarvis

Jakub Kicinski <kuba@kernel.org> =E4=BA=8E2021=E5=B9=B43=E6=9C=8817= =E6=97=A5=E5=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=885:37=E5=86=99=E9=81=93=EF=BC= =9A
On Tue, 16 M= ar 2021 05:42:37 -0700 Jarvis Jiang wrote:
>=C2=A0 drivers/bus/mhi/devices/mhi_netdev.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 | 1830 +++++++++++++

There's already a drivers/net/mhi/

Please make sure the drivers live in their respective subsystem.

Virtio drivers don't sit under drivers/virtio, and most certainly not under drivers/bus/virtio...

>=C2=A0 drivers/bus/mhi/devices/mhi_satellite.c=C2=A0 =C2=A0 =C2=A0 =C2= =A0| 1155 +++++++++
>=C2=A0 drivers/bus/mhi/devices/mhi_uci.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 802 ++++++

Ugh, can you clarify what's the source of this code dump and if you'= ;re
coordinating with others working on Qualcomm drivers?
--0000000000004f135b05bdb8af91--