From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EECBEB64DD for ; Sun, 2 Jul 2023 17:55:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCC2C8E007B; Sun, 2 Jul 2023 13:55:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7C8C8E0059; Sun, 2 Jul 2023 13:55:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A44398E007B; Sun, 2 Jul 2023 13:55:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 92B7B8E0059 for ; Sun, 2 Jul 2023 13:55:26 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 68F2C16087D for ; Sun, 2 Jul 2023 17:55:26 +0000 (UTC) X-FDA: 80967423852.25.1C9A38F Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by imf13.hostedemail.com (Postfix) with ESMTP id B75F420018 for ; Sun, 2 Jul 2023 17:55:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=HS1Xpu8R; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of safinaskar@gmail.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=safinaskar@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688320524; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=B/346nUIZErMaap4Xzifysw7agxmNBKblpAJllVen+8=; b=ey5yybfgmNhaWHRa5d+JUMLU7roPV7Sp0v31U9mmrWs/YQPiGOS2VqPY+x3ULhfLnicgzh tLjLZthZOKDQnf9/oYMpdNwKlFlKlOVNbYnGknTfgUv/qDHJ/A0W00TSthLdgIKMOHMfSz 16sOkNalP+rsFA6dP0PxT2UED4m8ECc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=HS1Xpu8R; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of safinaskar@gmail.com designates 209.85.219.172 as permitted sender) smtp.mailfrom=safinaskar@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688320524; a=rsa-sha256; cv=none; b=7DJsDkjNe9/kfIO4Zi1hv6cOTd7LPTLdsKaPhghV3bInhbL7KALd2JYbT5pyD8+YnSH3cr NGsfSHDDltNaUV07vxspBDNMOktrfn8CG1inmuM9SDkIcbINd4vntdPXIpBB5ElfiEwqop z2+ZxhWwQ7Qra28+8saBFuie3+LhGSY= Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-c13cb2cb428so622376276.0 for ; Sun, 02 Jul 2023 10:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688320524; x=1690912524; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=B/346nUIZErMaap4Xzifysw7agxmNBKblpAJllVen+8=; b=HS1Xpu8RutGjzNf2cNefIvO40PuyEyyWN1lXpuUm3Zm6tYXGDXwbDrBzDuJeX7KOHr q1UGGgd94SVTRefQw+1rgl1gQ50uEoBHL2OdSUILUjvF+1ATH9gvheGUN++hFOwLNLid 1XMjRZLU+9Ge2en4fJbD50bjnQdqOwyoXZfvhIPbUVY/sq6Vm6BAvUYZPRqmTRzyIG2n JWXOYS2flIDtpE0mu19bw1MyMQp5M6uow+iO1HWzOXqc6Z90+aO2nBs6Bf+FGR5IBS25 laBmv/H9uClBFT1isqMjJFlPY+WcanwzxZg1N8ZxZIN6sqfmOEIBN1yT1YF0buNY5Ya/ 4xig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688320524; x=1690912524; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=B/346nUIZErMaap4Xzifysw7agxmNBKblpAJllVen+8=; b=PCunTdZPmDQjzwfWR2DCUZpW6tWxYgkVntvqEx8ltPGwjOUXEyXt5LuGW+6K2I/CdV OicyP4svxIJpG4ga5A4MZBBlPBWpqCr7ZgH0W9gGOxzd37BUdIDq9RSPIET6hyE/ZCrh aDFpNNM5lqDfa9NL11ylKNr8YWRQYyaO0tG0jAkdpR+3H51sGH/8YnLpfus7HQKV7Ycb WaEqNb8ljKz7AvUPP/d0CfgS2g3PDvFx6bsNxcfl5kDvB2BNY4ko2FZ4cXgUrzUwJ9Zu a767CbXB6yU5rPfRdqn6znF77SEkwiNsFSvSfrL/+ruat6RkfK+V1b5ZoJeh/2IOe1S7 Y+Hg== X-Gm-Message-State: ABy/qLZYnMcA0shtnMQBtVd0GaJM+vg75cAkFAoGQmMVMke29/zXP2Yt ls+hv835k0GuLBeoI2cnSAt/pCa/+zFuFFgH19g= X-Google-Smtp-Source: APBJJlGKLhOT4Bu7qJ+9PV6J1mFibevhHpEsj9SgVNCYM6WTAos06S2LRQMzHrHXF1fE6Av0kYh7XbCZNh0JTIxm3q8= X-Received: by 2002:a25:2b88:0:b0:bd6:6e3e:3af3 with SMTP id r130-20020a252b88000000b00bd66e3e3af3mr4285143ybr.3.1688320523798; Sun, 02 Jul 2023 10:55:23 -0700 (PDT) MIME-Version: 1.0 From: Askar Safin Date: Sun, 2 Jul 2023 20:54:47 +0300 Message-ID: Subject: Re: [PATCH net-next v3 17/18] sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES) To: David Howells Cc: netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Marc Kleine-Budde , bpf@vger.kernel.org, dccp@vger.kernel.org, linux-afs@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-can@vger.kernel.org, linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hams@vger.kernel.org, linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, linux-sctp@vger.kernel.org, linux-wpan@vger.kernel.org, linux-x25@vger.kernel.org, mptcp@lists.linux.dev, rds-devel@oss.oracle.com, tipc-discussion@lists.sourceforge.net, virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Stat-Signature: u5dox1uksrt77w9szu6hj5jnosrdm537 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B75F420018 X-HE-Tag: 1688320524-176061 X-HE-Meta: U2FsdGVkX1/DEgmQAUw3x8tdcrFN3USiQQFcto1jMwaTUA7To8FzNqoAk4hOXF31pHd/gHofmqHd/gga4RgCzXP60lC175+9vqhOR0uy44lz0ZJ1a0RNdgTFzhyBWW4C/YOazc4vGbQCXCWbrRVvwd9G/ECZ79knvcWuwP3r2Pb6Ywtw6Khr8WOVIs3Yda2uvvP33Okpw2BerRm/0Q4SDgJB8PlZv++69pNL7R+doILacrKU8JJAXyNezsaWY28oJyZ8BtmQOohsxt3Nnz83+Pha7u6McAZ/nGQUkXGQN6bvZrMIdrR18gUIqbK0F5Jbrqn3FFGNUantpXXYBoXrOZsPbvFBi7AuhJ84/uyJ4WOcdmqkYl0PmdIppn418/rJkKfOZktPM9fZhFi2Nehvr8GK+iG/ib//awTvz+9qH0zsJTC2fqc6t3U6qz/DggWpsfQaVe/Cu/IVvuQ/k8i5jF/24HMQLhgNO1QS+buOIVxd1z5xpVvt+RNwOZ1inkWnphP9A4Ja6EU3pUwgTSs9DpxsD9oDbTvF1OlMASI/qboqN83H9L21+Tc3SIvFVPGekmmNkDEYInniaOoPjn5VI+BXuwo+BeR+52l6UOVoT54Rr97IbUF2FKHEwhCnRVY3k4ZjwjCiCaU188pSTCtrljmbo8gu8ZjFlLYMb0dT52DXAskOmLOwSXhlXJRZ3IiyxqOaJ2mT8PmHgJbPzDAPKORya9NqGtpUWLcb4VPVjqoukuvjw6KbzZo1N+JnQqGNIH9xQWRBgD2TVr3RQRS4as2zJBHy99OXCb5bMQHEeXWpAc0YLD5/VLjIPdp98G/AlzINQJnZph7EvyMv4ecbxY3ht5cxnNpbFXrmvjM/xIomS5gKRqex6GwRS3o81EX4MvlX0LKd9iDN8kAww5NLTNQ6azuAvXg8x8cMdzsSSMm0iLgtwl+JcAT8/nmTwha/upt0TtvrbQ01r+1imO6 IeQFeElP dD93KSi19JXt6Nm2rOYEKVTlzrPJvsgffvqslZyRFKnedDAtBjADXmCQOKqKuWyP8Sxv00Ct2PHqogJuiMwq828YWioBnVaI0+Tw+YOKULXDoNvcHIcKSN80VLGAZEHCJSZbisQLsAufomck9Ma21EzYXhNdfBAl+zqoHZ6AqF7LgdRCe5yocXcl6jvrngOBiXFkN6urf2uYrPsMmoDNKtfml2LGrUNrHYnyV70bUomigwic5AnDJp4EYI3HmasGv9uoqfmI5BtTyB3ijO8+5qL8zyHUiigzJOLqLa7D6Dywe5EZhAyFH2btnx1/tCUeo8V3GQePZ1wzK/sKxgXGbLFSlkCX7EmnIWMF2Y58YUcq8kT5OcO6njcdoSu/ALogffZgpMBok73HjCbnQ/j3GT6JNgPlZZ3B2CED5VU8iPEehsFnb4IdhOf0L0Aj2xW2ney941FZUo68L+Gua5wxNgsq1qVPOo5RP4B5J8isJRN5W8LcpxjR0bVfrfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -/* In some cases, both sendpage() and sendmsg() could have added > - * an skb to the write queue, but failed adding payload on it. > - * We need to remove it to consume less memory, but more > - * importantly be able to generate EPOLLOUT for Edge Trigger epoll() > - * users. > +/* In some cases, both sendmsg() could have added an skb to the write queue, > + * but failed adding payload on it. We need to remove it to consume less > + * memory, but more importantly be able to generate EPOLLOUT for Edge Trigger > + * epoll() users. > */ There is a typo here. "Both" is redundant now -- Askar Safin