From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx140.postini.com [74.125.245.140]) by kanga.kvack.org (Postfix) with SMTP id F1AC56B005D for ; Wed, 26 Sep 2012 13:06:13 -0400 (EDT) Received: by vcbfl17 with SMTP id fl17so1227022vcb.14 for ; Wed, 26 Sep 2012 10:06:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1348649419-16494-1-git-send-email-minchan@kernel.org> <1348649419-16494-2-git-send-email-minchan@kernel.org> Date: Wed, 26 Sep 2012 10:06:12 -0700 Message-ID: Subject: Re: [PATCH 1/3] zsmalloc: promote to lib/ From: Nitin Gupta Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Minchan Kim , Jens Axboe , Greg Kroah-Hartman , Konrad Rzeszutek Wilk , Seth Jennings , Dan Magenheimer , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton 2012/9/26 Pekka Enberg : > On Wed, Sep 26, 2012 at 11:50 AM, Minchan Kim wrote: >> lib/Kconfig | 2 + >> lib/Makefile | 1 + >> lib/zsmalloc/Kconfig | 18 + >> lib/zsmalloc/Makefile | 1 + >> lib/zsmalloc/zsmalloc.c | 1064 ++++++++++++++++++++++++++++++ > > What's wrong with mm/zsmalloc.c? I think mm/ directory should only contain the code which is intended for global use such as the slab allocator, page reclaim code etc. zsmalloc is used by only one (or possibly two) drivers, so lib/ seems to be the right place. Thanks, Nitin -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org