From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f71.google.com (mail-vk0-f71.google.com [209.85.213.71]) by kanga.kvack.org (Postfix) with ESMTP id DEB8A6B0005 for ; Sun, 5 Jun 2016 19:08:15 -0400 (EDT) Received: by mail-vk0-f71.google.com with SMTP id t7so362051835vkf.2 for ; Sun, 05 Jun 2016 16:08:15 -0700 (PDT) Received: from mail-qg0-x242.google.com (mail-qg0-x242.google.com. [2607:f8b0:400d:c04::242]) by mx.google.com with ESMTPS id 63si9300907qkm.83.2016.06.05.16.08.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Jun 2016 16:08:15 -0700 (PDT) Received: by mail-qg0-x242.google.com with SMTP id t106so5572077qgt.2 for ; Sun, 05 Jun 2016 16:08:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1465125103-26764-1-git-send-email-iamyooon@gmail.com> From: SeokHoon Yoon Date: Mon, 6 Jun 2016 08:08:14 +0900 Message-ID: Subject: Re: [PATCH 1/1] mm/kasan: use {READ,WRITE}_MODE not true,false Content-Type: multipart/alternative; boundary=001a11c1198ad2a8a90534900772 Sender: owner-linux-mm@kvack.org List-ID: To: Dmitry Vyukov Cc: Andrey Ryabinin , kasan-dev , "linux-mm@kvack.org" , "sh.yoon@lge.com" --001a11c1198ad2a8a90534900772 Content-Type: text/plain; charset=UTF-8 2016-06-05 21:49 GMT+09:00 Dmitry Vyukov : > On Sun, Jun 5, 2016 at 1:11 PM, seokhoon.yoon wrote: > > When Kasan tell memory access is write or not, use true or false. > > This expression is simple and convenient. > > > > But I think it is possible to more readable. and so change it. > > > > Signed-off-by: seokhoon.yoon > > --- > > mm/kasan/kasan.c | 32 ++++++++++++++++---------------- > > mm/kasan/kasan.h | 12 ++++++++++-- > > mm/kasan/report.c | 16 ++++++++-------- > > 3 files changed, 34 insertions(+), 26 deletions(-) > > > > diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c > > index 18b6a2b..642d936 100644 > > --- a/mm/kasan/kasan.c > > +++ b/mm/kasan/kasan.c > > @@ -274,7 +274,7 @@ static __always_inline bool > memory_is_poisoned(unsigned long addr, size_t size) > > } > > > > static __always_inline void check_memory_region_inline(unsigned long > addr, > > - size_t size, bool write, > > + size_t size, enum > acc_type type, > > unsigned long ret_ip) > > { > > if (unlikely(size == 0)) > > @@ -282,39 +282,39 @@ static __always_inline void > check_memory_region_inline(unsigned long addr, > > > > if (unlikely((void *)addr < > > kasan_shadow_to_mem((void *)KASAN_SHADOW_START))) { > > - kasan_report(addr, size, write, ret_ip); > > + kasan_report(addr, size, type, ret_ip); > > return; > > } > > > > if (likely(!memory_is_poisoned(addr, size))) > > return; > > > > - kasan_report(addr, size, write, ret_ip); > > + kasan_report(addr, size, type, ret_ip); > > } > > > > static void check_memory_region(unsigned long addr, > > - size_t size, bool write, > > + size_t size, enum acc_type type, > > unsigned long ret_ip) > > { > > - check_memory_region_inline(addr, size, write, ret_ip); > > + check_memory_region_inline(addr, size, type, ret_ip); > > } > > > > void kasan_check_read(const void *p, unsigned int size) > > { > > - check_memory_region((unsigned long)p, size, false, _RET_IP_); > > + check_memory_region((unsigned long)p, size, READ_MODE, _RET_IP_); > > } > > EXPORT_SYMBOL(kasan_check_read); > > > > void kasan_check_write(const void *p, unsigned int size) > > { > > - check_memory_region((unsigned long)p, size, true, _RET_IP_); > > + check_memory_region((unsigned long)p, size, WRITE_MODE, > _RET_IP_); > > } > > EXPORT_SYMBOL(kasan_check_write); > > > > #undef memset > > void *memset(void *addr, int c, size_t len) > > { > > - check_memory_region((unsigned long)addr, len, true, _RET_IP_); > > + check_memory_region((unsigned long)addr, len, WRITE_MODE, > _RET_IP_); > > > > return __memset(addr, c, len); > > } > > @@ -322,8 +322,8 @@ void *memset(void *addr, int c, size_t len) > > #undef memmove > > void *memmove(void *dest, const void *src, size_t len) > > { > > - check_memory_region((unsigned long)src, len, false, _RET_IP_); > > - check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > + check_memory_region((unsigned long)src, len, READ_MODE, > _RET_IP_); > > + check_memory_region((unsigned long)dest, len, WRITE_MODE, > _RET_IP_); > > > > return __memmove(dest, src, len); > > } > > @@ -331,8 +331,8 @@ void *memmove(void *dest, const void *src, size_t > len) > > #undef memcpy > > void *memcpy(void *dest, const void *src, size_t len) > > { > > - check_memory_region((unsigned long)src, len, false, _RET_IP_); > > - check_memory_region((unsigned long)dest, len, true, _RET_IP_); > > + check_memory_region((unsigned long)src, len, READ_MODE, > _RET_IP_); > > + check_memory_region((unsigned long)dest, len, WRITE_MODE, > _RET_IP_); > > > > return __memcpy(dest, src, len); > > } > > @@ -709,7 +709,7 @@ EXPORT_SYMBOL(__asan_unregister_globals); > > #define DEFINE_ASAN_LOAD_STORE(size) \ > > void __asan_load##size(unsigned long addr) \ > > { \ > > - check_memory_region_inline(addr, size, false, _RET_IP_);\ > > + check_memory_region_inline(addr, size, READ_MODE, > _RET_IP_);\ > > } \ > > EXPORT_SYMBOL(__asan_load##size); \ > > __alias(__asan_load##size) \ > > @@ -717,7 +717,7 @@ EXPORT_SYMBOL(__asan_unregister_globals); > > EXPORT_SYMBOL(__asan_load##size##_noabort); \ > > void __asan_store##size(unsigned long addr) \ > > { \ > > - check_memory_region_inline(addr, size, true, _RET_IP_); \ > > + check_memory_region_inline(addr, size, WRITE_MODE, > _RET_IP_);\ > > } \ > > EXPORT_SYMBOL(__asan_store##size); \ > > __alias(__asan_store##size) \ > > @@ -732,7 +732,7 @@ DEFINE_ASAN_LOAD_STORE(16); > > > > void __asan_loadN(unsigned long addr, size_t size) > > { > > - check_memory_region(addr, size, false, _RET_IP_); > > + check_memory_region(addr, size, READ_MODE, _RET_IP_); > > } > > EXPORT_SYMBOL(__asan_loadN); > > > > @@ -742,7 +742,7 @@ EXPORT_SYMBOL(__asan_loadN_noabort); > > > > void __asan_storeN(unsigned long addr, size_t size) > > { > > - check_memory_region(addr, size, true, _RET_IP_); > > + check_memory_region(addr, size, WRITE_MODE, _RET_IP_); > > } > > EXPORT_SYMBOL(__asan_storeN); > > > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > index 7f7ac51..47cb58c 100644 > > --- a/mm/kasan/kasan.h > > +++ b/mm/kasan/kasan.h > > @@ -27,11 +27,19 @@ > > #define KASAN_ABI_VERSION 1 > > #endif > > > > +/* > > + * Distinguish memory access > > + */ > > +enum acc_type { > > + READ_MODE, > > + WRITE_MODE > > +}; > > + > > struct kasan_access_info { > > const void *access_addr; > > const void *first_bad_addr; > > size_t access_size; > > - bool is_write; > > + enum acc_type access_type; > > unsigned long ip; > > }; > > > > @@ -109,7 +117,7 @@ static inline bool kasan_report_enabled(void) > > } > > > > void kasan_report(unsigned long addr, size_t size, > > - bool is_write, unsigned long ip); > > + enum acc_type type, unsigned long ip); > > > > #ifdef CONFIG_SLAB > > void quarantine_put(struct kasan_free_meta *info, struct kmem_cache > *cache); > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > index b3c122d..e0bee22 100644 > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -96,7 +96,7 @@ static void print_error_description(struct > kasan_access_info *info) > > bug_type, (void *)info->ip, > > info->access_addr); > > pr_err("%s of size %zu by task %s/%d\n", > > - info->is_write ? "Write" : "Read", > > + info->access_type == WRITE_MODE ? "Write" : "Read", > > info->access_size, current->comm, task_pid_nr(current)); > > } > > > > @@ -267,7 +267,7 @@ static void kasan_report_error(struct > kasan_access_info *info) > > pr_err("BUG: KASAN: %s on address %p\n", > > bug_type, info->access_addr); > > pr_err("%s of size %zu by task %s/%d\n", > > - info->is_write ? "Write" : "Read", > > + info->access_type == WRITE_MODE ? "Write" : > "Read", > > info->access_size, current->comm, > > task_pid_nr(current)); > > dump_stack(); > > @@ -283,7 +283,7 @@ static void kasan_report_error(struct > kasan_access_info *info) > > } > > > > void kasan_report(unsigned long addr, size_t size, > > - bool is_write, unsigned long ip) > > + enum acc_type type, unsigned long ip) > > { > > struct kasan_access_info info; > > > > @@ -292,7 +292,7 @@ void kasan_report(unsigned long addr, size_t size, > > > > info.access_addr = (void *)addr; > > info.access_size = size; > > - info.is_write = is_write; > > + info.access_type = type; > > info.ip = ip; > > > > kasan_report_error(&info); > > @@ -302,14 +302,14 @@ void kasan_report(unsigned long addr, size_t size, > > #define DEFINE_ASAN_REPORT_LOAD(size) \ > > void __asan_report_load##size##_noabort(unsigned long addr) \ > > { \ > > - kasan_report(addr, size, false, _RET_IP_); \ > > + kasan_report(addr, size, READ_MODE, _RET_IP_); \ > > } \ > > EXPORT_SYMBOL(__asan_report_load##size##_noabort) > > > > #define DEFINE_ASAN_REPORT_STORE(size) \ > > void __asan_report_store##size##_noabort(unsigned long addr) \ > > { \ > > - kasan_report(addr, size, true, _RET_IP_); \ > > + kasan_report(addr, size, WRITE_MODE, _RET_IP_); \ > > } \ > > EXPORT_SYMBOL(__asan_report_store##size##_noabort) > > > > @@ -326,12 +326,12 @@ DEFINE_ASAN_REPORT_STORE(16); > > > > void __asan_report_load_n_noabort(unsigned long addr, size_t size) > > { > > - kasan_report(addr, size, false, _RET_IP_); > > + kasan_report(addr, size, READ_MODE, _RET_IP_); > > } > > EXPORT_SYMBOL(__asan_report_load_n_noabort); > > > > void __asan_report_store_n_noabort(unsigned long addr, size_t size) > > { > > - kasan_report(addr, size, true, _RET_IP_); > > + kasan_report(addr, size, WRITE_MODE, _RET_IP_); > > } > > EXPORT_SYMBOL(__asan_report_store_n_noabort); > > > Hello seokhoon.yoon, > > Hi Dmitry, thanks for your replies. > > Where exactly do you hit readability problems? > I don`t hit readablity problem,but kasan need to abstract this expression. I think more abstraction give us more readablity. isn't it? :) > I would say that the only problematic place is where we initialize the > value: > > kasan_report(addr, size, true, _RET_IP_); > check_memory_region(addr, size, true, _RET_IP_); > Here it is really difficult to say what true/false mean. Even if you > know that it is access type, you don't necessary remember if true means write or read. That could be solved by adding comments: > > kasan_report(addr, size, /* write = */ true, _RET_IP_); > > In all other places one sees that we are talking about "write". thanks. --001a11c1198ad2a8a90534900772 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

= 2016-06-05 21:49 GMT+09:00 Dmitry Vyukov <dvyukov@google.com>:
On Sun, Jun 5, 2016 at 1:11 PM, seokhoon.yoon <<= a href=3D"mailto:iamyooon@gmail.com">iamyooon@gmail.com> wrote:
> When Kasan tell memory access is write or not, use true or false.
> This expression is simple and convenient.
>
> But I think it is possible to more readable. and so change it.
>
> Signed-off-by: seokhoon.yoon <iamyooon@gmail.com>
> ---
>=C2=A0 mm/kasan/kasan.c=C2=A0 | 32 ++++++++++++++++----------------
>=C2=A0 mm/kasan/kasan.h=C2=A0 | 12 ++++++++++--
>=C2=A0 mm/kasan/report.c | 16 ++++++++--------
>=C2=A0 3 files changed, 34 insertions(+), 26 deletions(-)
>
> diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c
> index 18b6a2b..642d936 100644
> --- a/mm/kasan/kasan.c
> +++ b/mm/kasan/kasan.c
> @@ -274,7 +274,7 @@ static __always_inline bool memory_is_poisoned(uns= igned long addr, size_t size)
>=C2=A0 }
>
>=C2=A0 static __always_inline void check_memory_region_inline(unsigned = long addr,
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0size_t size, bool write,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0size_t size, enum acc_type type,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0unsigned long ret_ip)
>=C2=A0 {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (unlikely(size =3D=3D 0))
> @@ -282,39 +282,39 @@ static __always_inline void check_memory_region_= inline(unsigned long addr,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (unlikely((void *)addr <
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_sha= dow_to_mem((void *)KASAN_SHADOW_START))) {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(a= ddr, size, write, ret_ip);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(a= ddr, size, type, ret_ip);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return; >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (likely(!memory_is_poisoned(addr, = size)))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return; >
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, write, ret_ip); > +=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, type, ret_ip); >=C2=A0 }
>
>=C2=A0 static void check_memory_region(unsigned long addr,
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0size_t size, bool write,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0size_t size, enum acc_type type,<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0unsigned long ret_ip)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region_inline(addr, size, wri= te, ret_ip);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region_inline(addr, size, typ= e, ret_ip);
>=C2=A0 }
>
>=C2=A0 void kasan_check_read(const void *p, unsigned int size)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)p, size= , false, _RET_IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)p, size= , READ_MODE, _RET_IP_);
>=C2=A0 }
>=C2=A0 EXPORT_SYMBOL(kasan_check_read);
>
>=C2=A0 void kasan_check_write(const void *p, unsigned int size)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)p, size= , true, _RET_IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)p, size= , WRITE_MODE, _RET_IP_);
>=C2=A0 }
>=C2=A0 EXPORT_SYMBOL(kasan_check_write);
>
>=C2=A0 #undef memset
>=C2=A0 void *memset(void *addr, int c, size_t len)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)addr, l= en, true, _RET_IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)addr, l= en, WRITE_MODE, _RET_IP_);
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return __memset(addr, c, len);
>=C2=A0 }
> @@ -322,8 +322,8 @@ void *memset(void *addr, int c, size_t len)
>=C2=A0 #undef memmove
>=C2=A0 void *memmove(void *dest, const void *src, size_t len)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)src, le= n, false, _RET_IP_);
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)dest, l= en, true, _RET_IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)src, le= n, READ_MODE, _RET_IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)dest, l= en, WRITE_MODE, _RET_IP_);
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return __memmove(dest, src, len);
>=C2=A0 }
> @@ -331,8 +331,8 @@ void *memmove(void *dest, const void *src, size_t = len)
>=C2=A0 #undef memcpy
>=C2=A0 void *memcpy(void *dest, const void *src, size_t len)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)src, le= n, false, _RET_IP_);
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)dest, l= en, true, _RET_IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)src, le= n, READ_MODE, _RET_IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region((unsigned long)dest, l= en, WRITE_MODE, _RET_IP_);
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return __memcpy(dest, src, len);
>=C2=A0 }
> @@ -709,7 +709,7 @@ EXPORT_SYMBOL(__asan_unregister_globals);
>=C2=A0 #define DEFINE_ASAN_LOAD_STORE(size)=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0\
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0void __asan_load##size(unsigned long = addr)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_r= egion_inline(addr, size, false, _RET_IP_);\
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_r= egion_inline(addr, size, READ_MODE, _RET_IP_);\
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0EXPORT_SYMBOL(__asan_load##size);=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0__alias(__asan_load##size)=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 \
> @@ -717,7 +717,7 @@ EXPORT_SYMBOL(__asan_unregister_globals);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0EXPORT_SYMBOL(__asan_load##size##_noa= bort);=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0\
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0void __asan_store##size(unsigned long= addr)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0\
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0{=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_r= egion_inline(addr, size, true, _RET_IP_); \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_r= egion_inline(addr, size, WRITE_MODE, _RET_IP_);\
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0EXPORT_SYMBOL(__asan_store##size);=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0__alias(__asan_store##size)=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
> @@ -732,7 +732,7 @@ DEFINE_ASAN_LOAD_STORE(16);
>
>=C2=A0 void __asan_loadN(unsigned long addr, size_t size)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region(addr, size, false, _RE= T_IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region(addr, size, READ_MODE,= _RET_IP_);
>=C2=A0 }
>=C2=A0 EXPORT_SYMBOL(__asan_loadN);
>
> @@ -742,7 +742,7 @@ EXPORT_SYMBOL(__asan_loadN_noabort);
>
>=C2=A0 void __asan_storeN(unsigned long addr, size_t size)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region(addr, size, true, _RET= _IP_);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0check_memory_region(addr, size, WRITE_MODE= , _RET_IP_);
>=C2=A0 }
>=C2=A0 EXPORT_SYMBOL(__asan_storeN);
>
> diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h
> index 7f7ac51..47cb58c 100644
> --- a/mm/kasan/kasan.h
> +++ b/mm/kasan/kasan.h
> @@ -27,11 +27,19 @@
>=C2=A0 #define KASAN_ABI_VERSION 1
>=C2=A0 #endif
>
> +/*
> + * Distinguish memory access
> + */
> +enum acc_type {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0READ_MODE,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0WRITE_MODE
> +};
> +
>=C2=A0 struct kasan_access_info {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0const void *access_addr;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0const void *first_bad_addr;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0size_t access_size;
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0bool is_write;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0enum acc_type access_type;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0unsigned long ip;
>=C2=A0 };
>
> @@ -109,7 +117,7 @@ static inline bool kasan_report_enabled(void)
>=C2=A0 }
>
>=C2=A0 void kasan_report(unsigned long addr, size_t size,
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool is_write,= unsigned long ip);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0enum acc_type = type, unsigned long ip);
>
>=C2=A0 #ifdef CONFIG_SLAB
>=C2=A0 void quarantine_put(struct kasan_free_meta *info, struct kmem_ca= che *cache);
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index b3c122d..e0bee22 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -96,7 +96,7 @@ static void print_error_description(struct kasan_acc= ess_info *info)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bug_type,= (void *)info->ip,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0info->= access_addr);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err("%s of size %zu by task %= s/%d\n",
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0info->is_wr= ite ? "Write" : "Read",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0info->acces= s_type =3D=3D WRITE_MODE ? "Write" : "Read",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0info->= access_size, current->comm, task_pid_nr(current));
>=C2=A0 }
>
> @@ -267,7 +267,7 @@ static void kasan_report_error(struct kasan_access= _info *info)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err(&q= uot;BUG: KASAN: %s on address %p\n",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0bug_type, info->access_addr);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pr_err(&q= uot;%s of size %zu by task %s/%d\n",
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0info->is_write ? "Write" : "Read",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0info->access_type =3D=3D WRITE_MODE ? "Write" : = "Read",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0info->access_size, current->comm,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0task_pid_nr(current));
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dump_stac= k();
> @@ -283,7 +283,7 @@ static void kasan_report_error(struct kasan_access= _info *info)
>=C2=A0 }
>
>=C2=A0 void kasan_report(unsigned long addr, size_t size,
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool is_write,= unsigned long ip)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0enum acc_type = type, unsigned long ip)
>=C2=A0 {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct kasan_access_info info;
>
> @@ -292,7 +292,7 @@ void kasan_report(unsigned long addr, size_t size,=
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0info.access_addr =3D (void *)addr; >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0info.access_size =3D size;
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0info.is_write =3D is_write;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0info.access_type =3D type;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0info.ip =3D ip;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report_error(&info);
> @@ -302,14 +302,14 @@ void kasan_report(unsigned long addr, size_t siz= e,
>=C2=A0 #define DEFINE_ASAN_REPORT_LOAD(size)=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
>=C2=A0 void __asan_report_load##size##_noabort(unsigned long addr) \ >=C2=A0 {=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, false, _RET_IP_);= =C2=A0 =C2=A0 =C2=A0 =C2=A0 \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, READ_MODE, _RET_I= P_);=C2=A0 =C2=A0 \
>=C2=A0 }=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
>=C2=A0 EXPORT_SYMBOL(__asan_report_load##size##_noabort)
>
>=C2=A0 #define DEFINE_ASAN_REPORT_STORE(size)=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\
>=C2=A0 void __asan_report_store##size##_noabort(unsigned long addr) \ >=C2=A0 {=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 \
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, true, _RET_IP_);= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, WRITE_MODE, _RET_= IP_);=C2=A0 =C2=A0 \
>=C2=A0 }=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 \
>=C2=A0 EXPORT_SYMBOL(__asan_report_store##size##_noabort)
>
> @@ -326,12 +326,12 @@ DEFINE_ASAN_REPORT_STORE(16);
>
>=C2=A0 void __asan_report_load_n_noabort(unsigned long addr, size_t siz= e)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, false, _RET_IP_);=
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, READ_MODE, _RET_I= P_);
>=C2=A0 }
>=C2=A0 EXPORT_SYMBOL(__asan_report_load_n_noabort);
>
>=C2=A0 void __asan_report_store_n_noabort(unsigned long addr, size_t si= ze)
>=C2=A0 {
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, true, _RET_IP_);<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0kasan_report(addr, size, WRITE_MODE, _RET_= IP_);
>=C2=A0 }
>=C2=A0 EXPORT_SYMBOL(__asan_report_store_n_noabort);


Hello seokhoon.yoon,

Hi Dmitry,
thanks for your replies.
=C2=A0

Where exactly do you hit readability problems?

I don`t hit readablity problem,but kasan need= to abstract this expression.
I think more = abstraction give us more readablity. isn't it? :)
=C2=A0
I would say that the only problematic place is where we initialize the valu= e:

=C2=A0 =C2=A0 kasan_report(addr, size, true, _RET_IP_);
=C2=A0 =C2=A0 check_memory_region(addr, size, true, _RET_IP_);
Here it is really difficult to say what true/false mean. Even if you
know that it is access type, you don't necessary remember if true
means write or read. That could be solved by adding comments:

=C2=A0 =C2=A0 kasan_report(addr, size, /* write =3D */ true, _RET_IP_);

In all other places one sees that we are talking about "write".

thanks.
--001a11c1198ad2a8a90534900772-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org