From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F5DC77B72 for ; Thu, 20 Apr 2023 04:40:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90ACC6B0071; Thu, 20 Apr 2023 00:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B3386B0072; Thu, 20 Apr 2023 00:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77B8D6B0074; Thu, 20 Apr 2023 00:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 621456B0071 for ; Thu, 20 Apr 2023 00:40:02 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 275661401A3 for ; Thu, 20 Apr 2023 04:40:02 +0000 (UTC) X-FDA: 80700517044.28.F0B77E0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 455F7A000F for ; Thu, 20 Apr 2023 04:40:00 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OZ9xegZ7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681965600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e2kMjxLw00pT2+EDznrCtqL7waGns3hQPtXSEb5TvkE=; b=eW2DLm9wk930SupG/yCT+39ClA2wov5XJyyLCGig12kuwbqBrSCU4bXWBGfJD4coEK6374 7KwdmIvwE60CC0e2F81xV1R7JU6WSBIG1K5ZZNkfQbVqtgZuXn/14V70VfRvB/fRodBOlU AOaB0Cs7XeTYXOQKH73QXKaAg+kr89c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OZ9xegZ7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681965600; a=rsa-sha256; cv=none; b=ApHEDqWE7zzUgOGyugO4Vwx42TAj4IuFM5sQXZEiSBTZEyoli/u7a45/tADjyLHioRPDu8 vLEoVgehy+tUhVsgJLTpY4CUHQqb4mNkcu6wDjrDn7ippEAI/3ZXJ4Bg5r7W3LTzflkOFr u+gyqWuLhVR3JTo9pn7NtmlWHvr9Wh4= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2DCDD644F6 for ; Thu, 20 Apr 2023 04:39:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1119AC433AF for ; Thu, 20 Apr 2023 04:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681965598; bh=e2kMjxLw00pT2+EDznrCtqL7waGns3hQPtXSEb5TvkE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OZ9xegZ7ko8U1oo6qnsJk+3Pue6KDnodVJn0JAIQi6gTJIo4nyPvSZDS93d7D+vr6 HIgyAvgojEeu4pt/P44ll5AqnZwiJHnbs6iMDCEqQSt7HwVSMWRrf4HqNSdo0BrgOs xe60XU9lC7sT4MIUWnPe+q4M56UlazdoGKbSZgDHhV2toutGfHKEiW2zHkBf82rtwg jZ1Ep03Bk3ysAlufjJiB3rHHPBUJanT/0EGQIb6R1EQpNOJRGLVX8GXOxyThgYx9dE LsZTtGjje+HVmrDl5lhNSNKWHgqslD5QxmtOpsTAaT5taPjWTrBab4k4khEjZkh+si KFUa9x5OVGXTA== Received: by mail-lj1-f171.google.com with SMTP id q21so1471155ljp.0 for ; Wed, 19 Apr 2023 21:39:57 -0700 (PDT) X-Gm-Message-State: AAQBX9cn22AGbTO8JQbJoXyj00FYM567D75mIz6/GjMNAxymUbNWNYxF MGHTJF8EdAJw/hvucZt2CGU2rYsmYeu81yArmZg= X-Google-Smtp-Source: AKy350brjGRI86LwVWGkzPXSEalUdCI4Td6YNPTTcnNRSEuyUW/eSnxVnpWQ0bvhloD205Vvr5DEOhYwggyQMmUmPfI= X-Received: by 2002:a2e:a313:0:b0:2a8:928d:2e2e with SMTP id l19-20020a2ea313000000b002a8928d2e2emr2679277lje.5.1681965595968; Wed, 19 Apr 2023 21:39:55 -0700 (PDT) MIME-Version: 1.0 References: <20230419140929.5924-1-jth@kernel.org> <20230419140929.5924-18-jth@kernel.org> In-Reply-To: <20230419140929.5924-18-jth@kernel.org> From: Song Liu Date: Wed, 19 Apr 2023 21:39:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 17/19] md: raid1: check if adding pages to resync bio fails To: Johannes Thumshirn Cc: axboe@kernel.dk, johannes.thumshirn@wdc.com, agruenba@redhat.com, cluster-devel@redhat.com, damien.lemoal@wdc.com, dm-devel@redhat.com, dsterba@suse.com, hare@suse.de, hch@lst.de, jfs-discussion@lists.sourceforge.net, kch@nvidia.com, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-raid@vger.kernel.org, ming.lei@redhat.com, rpeterso@redhat.com, shaggy@kernel.org, snitzer@kernel.org, willy@infradead.org, Damien Le Moal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 455F7A000F X-Stat-Signature: znz75owrwrracf67r99ftumnj5r7ak1u X-HE-Tag: 1681965600-683719 X-HE-Meta: U2FsdGVkX1/tvQCXmfnte7bCeWGCdHIRWIsLBiPY+xBMDs5arvrlVughK7Ch2XIc90lJyGkK/Q9vVyJJ02Pa20BVKl9/5CgjfKRMHmzVWQ701fsKEq8S73g4R29zwSs59XWy0JEiZbxX7r3eq45GCE3D35YlDk9U1V7Oqi0T7nmg4Ihhb5IxyEloGbH+mXn2hBc4N/jAVqXIItbtqW0Tjs6UQGpAI4CBkjnTlZZz3/Wg283FnNgrY05PQ+RyaCQUBconuJgy/Es3yB8XgxpDra/Xu4mYewXkn3JCr52pnv1M6HJJY3jzj46jWPdRIjiAhW2qyTSTWF2Z0lzt2JHw4hLFLc+GnNrmSTCLhLjW7pLfmqX0YOAlpC9ppVz+PJ+ieMhnBAHBjZJ4G/CJP/ZZyJ3G/Id7q/sCc6tQEuEtnn1vGensis3ZAk8qz/xG7nSvvBAOVq9PIR815ZLc9AiETsMFAo8uQw6qN4y0Ar3lYW8YOLuusprvcPHWFgTwGHfFfVs5btYOmaDtCIiSjZodu5HXfiFn5d28qFhF7nzMVZ9Op6YqcSsx4G2Vm2UR1EImEBnP0ImTMEimTpp1el/cJZ6Mm0Y2Qjfz1B1QhAlDOAfOML3/lgOAs0BMrt6+WxDGbP7eFJhFqkbZANACuY5nxuVfkYpyqntGCM7GGFJ3RqP47RMALlnSvg4T8+BfyCG3Uky/E2tl2DeqvkZsR8A/OcwTOExEYLxH7ddsO53jh3/hLs4HD6Gwm3bKcLvqBBfTw7QVuOnp4/vVc2Ju8kGduHmSm0eFknXXQtWEXvB6QXYmEGsCLpKkXYhDefRjylCWDOxBMPtJ5MkbmZSkx+S9Ydk45JJxegwdc3JAqjDBeUi1EsN46kCm9ITsUSp6Sj8Vz/sHmWpkIiaGGaXd0n6qEvLN6UhmNb3caTg7FIoZExExnS4X5kR1DKbKmXmhpMQ3ZFcnBscVKrpfCK3BlhS 3lPGEBJE ubJCoXG5B+bfLa+6sbbRJ3az9cE3H8vFexUft+2NwHBzKw9JLE+LNq9GSOdWDfhk/aXOAX25W5g9v+lhWcrWeWwGSF2UXZxRfe4uateserKvoYfvaA2lx1+OYntAid1f0gkeyoKP14Jt01kfC8Omhz44u2zziu12jEUuqbr9/86GkynPXDcr+kNYYdBao4tZPGzimXGdR9O5d799ovY7LRRnJF5WDkfTd+uADZOCtbKmNFUKESs+zn2quyX7wpXlhaGVLDDEB3PRaOi0mi+vzrmNIwWLf9AqrBmuT10ck/6/YF+LzAjTdsrzqZr22Ik85kGTYDyr+pwhBx7aJ+7cI0kp8tWUCE4SjXtFekhwEfiFh7JYWILSh1pgSA1/wzmgNftlxElzYKbDmTvdH6AkUax+MuGqqgMfwfZrF/RHTEXNKcL9xIrSsvp2ZlNd/r+zbyzIlEfMW5qcgFlU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 19, 2023 at 7:11=E2=80=AFAM Johannes Thumshirn = wrote: > > From: Johannes Thumshirn > > Check if adding pages to resync bio fails and if bail out. > > As the comment above suggests this cannot happen, WARN if it actually > happens. > > This way we can mark bio_add_pages as __must_check. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Damien Le Moal Acked-by: Song Liu Thanks!