From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E91C433FE for ; Tue, 22 Nov 2022 02:56:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7EBE6B0071; Mon, 21 Nov 2022 21:56:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2F266B0073; Mon, 21 Nov 2022 21:56:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 945E98E0001; Mon, 21 Nov 2022 21:56:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 880276B0071 for ; Mon, 21 Nov 2022 21:56:10 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59AABA03DD for ; Tue, 22 Nov 2022 02:56:10 +0000 (UTC) X-FDA: 80159564100.10.004F39E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id EDB0218000E for ; Tue, 22 Nov 2022 02:56:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5077461542 for ; Tue, 22 Nov 2022 02:56:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B694BC43147 for ; Tue, 22 Nov 2022 02:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669085768; bh=Xg4CfovBwHPfcEYY/0bJg7qhGA+G8rcFhnJbVLO6f7A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KzHwEXKmiRTZh57vql2GBr79b6ZnyVHtr0KV62S+gLWBJbg9ymaSOP1F/+DI3ypb3 11eYxbwYcwBmHhHqJtV7fSDHKCaBiv6Md2eOk7l4agvx3b+9yh0xX6bKy1kL+wTMSX FHtRu1ISW47RLb8IeLbbrf+MxD28jfi3TM83jsvKnm2EIIPIC46m0yrXgXxz2iYJ7A vpjOsYzeowpjgZc5RfwHq5DeHjLI4V21FDXs5DpAvXujuaCo6eIQLVYI9wqu6f7WuM lFWaCaEkVHX1Hiwc5+UVZR8lZwwmB7ZQxxlp8yv1ESZxUazfttMEOo+gn654h5UcmQ AvmGgvCHBAEHw== Received: by mail-ed1-f47.google.com with SMTP id l24so6251252edj.8 for ; Mon, 21 Nov 2022 18:56:08 -0800 (PST) X-Gm-Message-State: ANoB5pln3+9giZSvWOvWxJa3lOEOTaKaOocoOyachDy64SR+Wzwnnzj1 /yCm5anLEKY9QQA5lC7OEMJrMu9zI5UrlYha7DI= X-Google-Smtp-Source: AA0mqf4VFAdDOsQZGrBWiCDJ0Nmkm2LY51fkwE9aqWr9IiYlKOYmhWGHCWcgFuOHJKxCkoJ4QKHQYruWhnaWQM3/ayE= X-Received: by 2002:aa7:d653:0:b0:469:afb9:d14c with SMTP id v19-20020aa7d653000000b00469afb9d14cmr4537784edr.387.1669085766996; Mon, 21 Nov 2022 18:56:06 -0800 (PST) MIME-Version: 1.0 References: <20221117202322.944661-1-song@kernel.org> <20221117202322.944661-2-song@kernel.org> <882e2964-932e-0113-d3cd-344281add3a1@iogearbox.net> <20221121155542.GA27879@lst.de> In-Reply-To: From: Song Liu Date: Mon, 21 Nov 2022 19:55:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v4 1/6] vmalloc: introduce execmem_alloc, execmem_free, and execmem_fill To: Luis Chamberlain Cc: Christoph Hellwig , Daniel Borkmann , bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, rick.p.edgecombe@intel.com, rppt@kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KzHwEXKm; spf=pass (imf24.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669085770; a=rsa-sha256; cv=none; b=MZS+e2tE5z4JeLswhZU5Zkg0AKSj7Ip+jqyNeFo/48b6JKk1U7IEpTHKaPsEZKFr79fx7k zJC9Fh1sGoFbhWcXyVCyLCFV/06SXKuvtRgcuXf32T9t8ZjECN2ihAfCQOxKvdT+rUvXUj KsXz1EhovdsUrGQo9+VkwggoMWb/T4c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669085770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mZUoTPkI7Ks1VImmEAHbaZMLeg7VpyleJQXKuU/wcgQ=; b=3dRPsjgHbNuLT+/PuLs2IWvq0o654ztC3I1zqgtL4WvOJREHKMgpJyOb7/Pba1UjB8emzI gDsz/5C7Y6BdVi1EV5HvQgI6CpeWTLelisK8EiPr9uK5Pnl46BLsifTCyXfX4OlGWPzENO OJlY3Jw4GOC1cIDj+nSUNqYmue4iIno= X-Rspamd-Queue-Id: EDB0218000E X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KzHwEXKm; spf=pass (imf24.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-Stat-Signature: r3kz59gobbu66biknnobhxk3xjhtamaz X-HE-Tag: 1669085769-59957 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 21, 2022 at 12:55 PM Luis Chamberlain wrote: > > On Mon, Nov 21, 2022 at 09:29:20AM -0700, Song Liu wrote: > > On Mon, Nov 21, 2022 at 8:55 AM Christoph Hellwig wrote: > > > > > > On Mon, Nov 21, 2022 at 04:52:24PM +0100, Daniel Borkmann wrote: > > > >> +void *execmem_fill(void *dst, void *src, size_t len) > > > >> +{ > > > >> + return ERR_PTR(-EOPNOTSUPP); > > > >> +} > > > > > > > > Don't they need EXPORT_SYMBOL_GPL, too? > > > > > > None of these should be exported. Modular code has absolutely no > > > business creating executable mappings. > > > > I added these exports for test_vmalloc.ko. Is there a way to only export > > them to test_vmalloc.ko but nothing else? > > See EXPORT_SYMBOL_NS_GPL() Thanks! I will take a look at this later (vacation this week). Song