From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5263C433F5 for ; Tue, 12 Apr 2022 06:12:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3365F6B0071; Tue, 12 Apr 2022 02:12:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E6156B0073; Tue, 12 Apr 2022 02:12:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D68E6B0074; Tue, 12 Apr 2022 02:12:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0155.hostedemail.com [216.40.44.155]) by kanga.kvack.org (Postfix) with ESMTP id 0E72F6B0071 for ; Tue, 12 Apr 2022 02:12:08 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B8C128249980 for ; Tue, 12 Apr 2022 06:12:07 +0000 (UTC) X-FDA: 79347206694.31.6B577CD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 309D540002 for ; Tue, 12 Apr 2022 06:12:07 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6282E61898 for ; Tue, 12 Apr 2022 06:12:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C43C0C385AB for ; Tue, 12 Apr 2022 06:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649743925; bh=ACoZdA3Dxg/CYFEPdBg68crTUKAvPWorsgEWhy88cz8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dDadEpfrKVvTZbzYxaA4LFGN5+4puqiHrsAFMLPFQNZ+nkOVC6y8mto9LSPQmFjbL ceYPVbvLgWHhlXT7MK0h5O2Z1TG8UhScxZbIpJAikMmNOAagwBNFWr0lvew7Y3z+8B KV+cZvE+SDZKsWcZ02Nnd+eJNpf2YvHxy71aYx5LpkY1kJVX2qjzFvNYAzcIyDnzMY AscGJzYeWwvn7yOpOX+2vdtQ/SyTx99AclfeVsdcdNL7dZd2kNogP6bHBWruuTcue4 u1WRhXrwpvYVRpCa+r6yNpcHINyi00/GgAnckGIV9j7NafTqEvfyJ8czN5y5YQUNfj LkxHqYu/YHuUw== Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-2ebd70a4cf5so131368767b3.3 for ; Mon, 11 Apr 2022 23:12:05 -0700 (PDT) X-Gm-Message-State: AOAM530VNc6GN6qA3VYN/mVMRbDG1VnZG+cIWKo0PXY77TlxWS7iKLQd LT9oopC/boJAoh9jtWj7+B6VC0zvaiPVj9+9EEQ= X-Google-Smtp-Source: ABdhPJymgKneKeTIoxNk9CSLItjT7TD9MISrfs7p4O12oaJCxDCQbim9PNfUFRMIjdY24Ju5i697pzXbWYUiJfzzYIM= X-Received: by 2002:a81:5087:0:b0:2ef:33c1:fccd with SMTP id e129-20020a815087000000b002ef33c1fccdmr185706ywb.73.1649743924838; Mon, 11 Apr 2022 23:12:04 -0700 (PDT) MIME-Version: 1.0 References: <20220411233549.740157-1-song@kernel.org> <20220411233549.740157-3-song@kernel.org> In-Reply-To: From: Song Liu Date: Mon, 11 Apr 2022 23:11:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 bpf 2/3] module: introduce module_alloc_huge To: Christoph Hellwig Cc: bpf , Linux-MM , open list , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Andrew Morton , rick.p.edgecombe@intel.com, imbrenda@linux.ibm.com, Luis Chamberlain Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dDadEpfr; spf=pass (imf11.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 309D540002 X-Stat-Signature: dyyz6gzsw8su7hinf51acahe6m8ab6hy X-HE-Tag: 1649743927-660055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 9:20 PM Christoph Hellwig wrote: > > On Mon, Apr 11, 2022 at 04:35:47PM -0700, Song Liu wrote: > > Introduce module_alloc_huge, which allocates huge page backed memory in > > module memory space. The primary user of this memory is bpf_prog_pack > > (multiple BPF programs sharing a huge page). > > I kow I lead you downthis road first, but I wonder if we just want to > pass a flag to module_alloc instead. This avoids duplicating all the > arch overrides. I don't think we will see many archs support bpf_prog_pack, so the __weak version might be good enough for a long time. Adding an argument to module_alloc seems like more trouble to me. Thanks, Song