From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54BA9C761A6 for ; Fri, 31 Mar 2023 18:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF6DB6B0083; Fri, 31 Mar 2023 14:00:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA6D36B0087; Fri, 31 Mar 2023 14:00:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 947EF6B0088; Fri, 31 Mar 2023 14:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 80C8B6B0083 for ; Fri, 31 Mar 2023 14:00:14 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4F9AE16118C for ; Fri, 31 Mar 2023 18:00:14 +0000 (UTC) X-FDA: 80629957548.18.A83F1DA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 661844001D for ; Fri, 31 Mar 2023 18:00:12 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YgNZHmOL; spf=pass (imf04.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680285612; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9tXVcu579pVEe31v3uq18Kz/aIIJc6OZT76XuWimyYY=; b=TWMe9GCQa5wkXxcPHfYYzF0qCWqAL+obIhmrbM0sMMfEeCXATfbVhYQPriFe6kp8CCV8Vj cO0bRY+iqyaUPkvG4jdv1fGOh76IXXCfgYvIEIl4PSy9emIg9U+N8gsnw8uL6/Ld6m/Gdo ULvk/hHYdm6Qo59KhnozFxux6N6H4d4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YgNZHmOL; spf=pass (imf04.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680285612; a=rsa-sha256; cv=none; b=A13VlwCHkUswNL/bYUarTLhELCBSYKU2l4gbmCWJpNTRqFy4d0bP4fGWXHjwA+PdtLKgV9 oVihdzyl0Xcf2T/T15ydfe4yjTHRk4/mi5EMv/j55xwqaPW0lkZ4IQG3sUqBd456GNmImF 2/NC7sIoCgcHNiivPCKkzatfb5Rb1Hs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EC2F62B1D for ; Fri, 31 Mar 2023 18:00:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 308BAC433EF for ; Fri, 31 Mar 2023 18:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680285611; bh=9tXVcu579pVEe31v3uq18Kz/aIIJc6OZT76XuWimyYY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YgNZHmOLXZ1VOoy/QrY5pCHfzk02sSFrQTFY8GMr48v+dR8Qt80AuSqjMT9CMiyQP ysZNr5rNQY3tgaZGR4Y4E1KmqnncUybRBlI9djM6dnMAKa0tGiX2HdStla1bqU8Rui SX81lbv3qxEedlQfzWSfKo2BQGXsCELkmxicunMqhmL9LK/7cwUaFfqONAQAgbsMka lq0p/rO2GGulMBtdSYkbfCG6qYULmX+4wfIogx/OKsjD4vMqSwXtkoGVEEvklS8Xlc lwmpE8dJGYL0g76IAqUKiRhYvDAfDoXONYgDuBSUCv3CEfs4DoVFQS7aOkePgsQ0J5 lFU05B2XGayvg== Received: by mail-lj1-f175.google.com with SMTP id e9so8659622ljq.4 for ; Fri, 31 Mar 2023 11:00:11 -0700 (PDT) X-Gm-Message-State: AAQBX9cu0uCBUYwoDqhvaLyuvL4GaJQs9PwBIFdM4zR5pUUbBXS7emyz vVoPqotVTlGUO0SHM8qn25C7OhqrqakC3BwqPxI= X-Google-Smtp-Source: AKy350ZgbNojOjOEEz2nHphY2xJCW9wwsXYrrgwE3PRrjnKQvmDG5MKMnwlOL72DBVmaW0fPmBMmrb5gTNKFPGLQqzY= X-Received: by 2002:a2e:a556:0:b0:29b:d43f:f68f with SMTP id e22-20020a2ea556000000b0029bd43ff68fmr5465915ljn.5.1680285609272; Fri, 31 Mar 2023 11:00:09 -0700 (PDT) MIME-Version: 1.0 References: <4c9eaedd34f80d3477a5049f49610a8da8859744.1680172791.git.johannes.thumshirn@wdc.com> In-Reply-To: <4c9eaedd34f80d3477a5049f49610a8da8859744.1680172791.git.johannes.thumshirn@wdc.com> From: Song Liu Date: Fri, 31 Mar 2023 10:59:57 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 16/19] md: raid1: use __bio_add_page for adding single page to bio To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org, Damien Le Moal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: nh1ezo354ay3zfz15aixu348oskke9oz X-Rspamd-Queue-Id: 661844001D X-HE-Tag: 1680285612-184935 X-HE-Meta: U2FsdGVkX19aORJNvh+IhxyJHoxFRtX0yn+Z+rpjGGtlTQXwGBJHUQ5tPkm9z++gdS6NZFGOedQ2V2ZcfJNsdE5T85+cKylllwNJ14HeZdfdmBnwKynCemuu2g1sZEk7qCoGpBZe9rdPXfLiba4WkfveQTNEpBcEKzNgaZ0o3OoptwKmj9dRrx0ctoJOlWqwpSiBQb0N+bLda5+AEhcIk/8Uqw97DXEgdhQzp1Qg6NUS+1rzxm0Oizi8xzprpI+3c8/AGyruZjwpmATlfkTurhQUZMXTdMfV6DjimZdlmLX4oP7Pg+bzzPB459+QC2Tdl45AnqtwL1ivWw3fXOmIBG597UXjcX90ZBIU+l+YASxLHuem3BPuZJuqqPLdXzxI4SI9jFDN+jY9rVNNOK1oVYvKZAwcD2yDAPx9n09f5ah0/ZK8t+UtWuvMXRFIUQklJ9o8a+4EUk6aF3fcqLN9sQSZqjxJFEwWLVkaDziBhdV1fX2ORkC75xof1ZnkXqfG0nBEXN6GEZNUJ1D36S/sHBCf1DwjRjppiWZHs74HdaQ+9TqB1G1Z68xQAQ62dSzd608CTPtg2xoOJeVLUHsirLbigWbwZneS2jyiDqiO37PxT9XnmiQmTcdt8z5lNGWBi7TVUAXBPK+Sd9CFncb78PtX+eRfOxArl8vfEea0+FUpwkxIfqDEaWHXJuEmaL2xw1gkpTLm2wucYBitOwSjXD6tKDIsh4AwpFcBnlZkWJdom1OQyL/whNp6/wYwRp7C6FsU4DqsW3FmWdAKg89njk9uNvUnDUyKHslpxHaBN4ryoqGPevzT79XSDHpucbPEIOaoRyQnnkm7DAI1lceY1Gszblal3gCDOt8CG+JqKpfiGYME+gLGawpHiIm7VEXFv0KrcSxHA84KYc9hr3Ku1ftnEz7/qsIrx2fNtwwjO3W/AmJhmJZiWEaQ/Z3e9lGGhUHz8qspm2mNH9rhgMY //y3UGXz kvL2setZCYnE0YqAteStkVLdMX88YB0JdmpK5p3bXZKibUtg4PvyqYfg/oFxi9XMlpVKY7QDDnLOAAXQ3Uw3ppUA9+r1MVgV6F4xr9keT9GlWylqObGlUANaFbkvUEQfttoBnyg7+qeMIcAgdZzrnc/5mmMDO38dO0hAQWGco1Blzt2eH1LjEaKxkwAIkxrmP+8jRUYLs1rfLtO8BJuRyKn57Vg7PQMqrhvcbXCcL+VTQOarE5BJThjrEx2u36iSoebuHFuZt1rvgURHsjUN68kXVE/J74FvSoUuSSov9cZYYgrtyhMDVFyav6rdfvKfF3+srldrnaXtMHy/17JS0/luA7OuJBVTn1pn+m9Q3ud0TmSyTiNeROh46NyZnLQseubaVSp9sKty1gGKVuFmOy6ChA2WsNwcnj2oikRmJ0y1xVgoAIwViZExVKKSbwhqHR2mOj+vfKu5HZBqQ7RFRV7S6QTfIsnWdOobzdaHmV4fXLnRRuoumyUup3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 3:44=E2=80=AFAM Johannes Thumshirn wrote: > > The sync request code uses bio_add_page() to add a page to a newly create= d bio. > bio_add_page() can fail, but the return value is never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Damien Le Moal Acked-by: Song Liu Thanks!