From: Song Liu <song@kernel.org>
To: Christy Lee <christyc.y.lee@gmail.com>
Cc: Christy Lee <christylee@fb.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Alexei Starovoitov <ast@kernel.org>,
kbuild-all@lists.01.org, kbuild@lists.01.org,
Linux-MM <linux-mm@kvack.org>, bpf <bpf@vger.kernel.org>,
Kernel Team <kernel-team@fb.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH bpf-next] Fix incorrect integer literal used for marking scratched registers in verifier logs
Date: Mon, 10 Jan 2022 14:25:58 -0800 [thread overview]
Message-ID: <CAPhsuW747JiykdZRj4ReJfTMfdSbvZBCkyO2Fiiri5uVrt4jbw@mail.gmail.com> (raw)
In-Reply-To: <CAPqJDZqf8-4DCe9J1jr7KekxqfBac3JBc+hx7a6qW4hoF6xPUQ@mail.gmail.com>
On Mon, Jan 10, 2022 at 2:13 PM Christy Lee <christyc.y.lee@gmail.com> wrote:
>
> On Mon, Jan 10, 2022 at 1:52 PM Song Liu <song@kernel.org> wrote:
> >
> > On Fri, Jan 7, 2022 at 4:59 PM Christy Lee <christylee@fb.com> wrote:
> > >
> > > env->scratched_stack_slots is a 64-bit value, we should use ULL
> > > instead of UL literal values.
> > >
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > Signed-off-by: Christy Lee <christylee@fb.com>
> >
> > The fix looks good to me. Thus:
> >
> > Acked-by: Song Liu <songliubraving@fb.com>
> >
> > However, the patch looks corrupted. Also, the subject is probably too
> > long (./scripts/checkpatch.pl should complain about it).
> >
>
> I just checked that even with an absurdly long subject (more than 200
> characters), ./scripts/checkpatch.pl doesn't complain. It only complains
> when the commit message body has longer than 75 characters but not the
> subject line. What's the maximum subject line length?
Hmm.. you are right. I somehow thought there was a limit by checkpatch.
I would personally limit it to 75 characters though.
next prev parent reply other threads:[~2022-01-10 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 8:20 [linux-next:master 7391/10864] kernel/bpf/verifier.c:619 mark_stack_slot_scratched() warn: should '1 << spi' be a 64 bit type? Dan Carpenter
2022-01-08 0:58 ` [PATCH bpf-next] Fix incorrect integer literal used for marking scratched registers in verifier logs Christy Lee
2022-01-10 21:52 ` Song Liu
2022-01-10 22:12 ` Christy Lee
2022-01-10 22:25 ` Song Liu [this message]
2022-01-11 9:48 ` Dan Carpenter
2022-01-11 17:56 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW747JiykdZRj4ReJfTMfdSbvZBCkyO2Fiiri5uVrt4jbw@mail.gmail.com \
--to=song@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christyc.y.lee@gmail.com \
--cc=christylee@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox