From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17ADDC4332F for ; Tue, 29 Nov 2022 17:31:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A93A96B0083; Tue, 29 Nov 2022 12:31:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A43B46B0085; Tue, 29 Nov 2022 12:31:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 915F06B0087; Tue, 29 Nov 2022 12:31:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7D5886B0083 for ; Tue, 29 Nov 2022 12:31:42 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4B0D880A13 for ; Tue, 29 Nov 2022 17:31:42 +0000 (UTC) X-FDA: 80187172044.30.DFFB0DB Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf12.hostedemail.com (Postfix) with ESMTP id 322314001F for ; Tue, 29 Nov 2022 17:31:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B95ADB81894 for ; Tue, 29 Nov 2022 17:31:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71E6EC433D6 for ; Tue, 29 Nov 2022 17:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669743098; bh=Yno0ZxK35GmnvzREU6S3ysILrgeflHC9VnPjoSzS2DU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Awiz+hSZURBI5omZVEKnoxLLR9UVJbDwX3biufxrp9qkyRK2SWhNnw2G/44dJ1Kid lhZ3HZzKdmlBW4CfpPDTdboB0oj61HLAaP8eHW1nwno8giiOqmyOX1exVYzQkyVR7I vsmKwpz01TVmRJwqggNLaPVi9DM4biy1zIVAGNLdOIIECBX+SSbzKn1SBFGnvrIgwi Co3TsX0tgbupPhG1pPMlq++9Niikdn4IxIn2lp7aVTOUg85nbrlojJKy1v0qW7du9G VTzrnjuIA19eOpm+BEcOCzzn8nxHwO3DqIAg17/MDGSF0grO0G2ON6btYC8LjAiJWD RIiECzbDfGPMQ== Received: by mail-ej1-f54.google.com with SMTP id vp12so34281621ejc.8 for ; Tue, 29 Nov 2022 09:31:38 -0800 (PST) X-Gm-Message-State: ANoB5pkGsFCCKJaiYjMD8PDM2K3e9pemcmkNKoETaQi61m+PMKxo0HXh 7HtJkYoR8+EL/nGXrgip1NPtdzJQmEa+e0ZL/Hk= X-Google-Smtp-Source: AA0mqf6RHc1/36W/jxdBSx0RZAihVEbLrSdyD8D/ebu3l7C/w8q/wyMkS3Y4sDv3+KvliSjU+6T8HSI302tlJhjQURw= X-Received: by 2002:a17:906:9f09:b0:7bc:db1b:206f with SMTP id fy9-20020a1709069f0900b007bcdb1b206fmr18827668ejc.719.1669743096731; Tue, 29 Nov 2022 09:31:36 -0800 (PST) MIME-Version: 1.0 References: <20221128190245.2337461-1-song@kernel.org> <20221128190245.2337461-4-song@kernel.org> <20221129083518.GA25167@lst.de> In-Reply-To: <20221129083518.GA25167@lst.de> From: Song Liu Date: Tue, 29 Nov 2022 09:31:24 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v5 3/6] selftests/vm: extend test_vmalloc to test execmem_* APIs To: Christoph Hellwig Cc: bpf@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, x86@kernel.org, peterz@infradead.org, rick.p.edgecombe@intel.com, rppt@kernel.org, mcgrof@kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669743101; a=rsa-sha256; cv=none; b=MTmdimvw61piqu8d8D0veHkSMEaQ0ty7rt8LSowMJq6uhR1NZ4Yi8dr1Z/cCLgSOiW1oKe ysaA4Zhd/0wJHIIEN/yHpD8wkF3wHCJDo9Uewzcx08bt2oT0wC6iDWZ71hazlUxU5jZwUH i09V3oi8qZLcVtu/WnDHI4kTCKUTrI0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Awiz+hSZ; spf=pass (imf12.hostedemail.com: domain of song@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669743101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=naOy+kzMW+kZ6oduaQk2EHGKfGNA0G8wF7E9CI6W8Hc=; b=1jOsTeV33SsNgtExzXQbqCN22yk9vABCHomn/ZbVetvGRTULS/zIYbzCMnJr/qgDXCiKVi /gl2sGWVip5249/OTLZbuoFTSGh0Hx7utLx49I+W1+Coy9jAnH60hEBukfcypX/4ZbGX7w pUKND+bOE79HSQXqL65xR9nsJhKQqxA= X-Stat-Signature: sq5fpenap9b7h5ihgbieudnm74i9k9ec X-Rspamd-Queue-Id: 322314001F X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Awiz+hSZ; spf=pass (imf12.hostedemail.com: domain of song@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam05 X-HE-Tag: 1669743100-478450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 29, 2022 at 12:35 AM Christoph Hellwig wrote: > > > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC > > +EXPORT_SYMBOL_GPL(execmem_alloc); > > +#endif > > > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC > > +EXPORT_SYMBOL_GPL(execmem_fill); > > +#endif > > > +#if DEBUG_TEST_VMALLOC_EXEMEM_ALLOC > > +EXPORT_SYMBOL_GPL(execmem_free); > > +#endif > > Still NAK. These symbols never have any business being exported > ever. Just force the test to be built-in if you want to test this > functionality. OK. I knew this was really ugly. I just want to know your thoughts on it. I guess we can just drop 3/6 of the set, and everything else would just work. Thanks, Song