From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AAAC433E0 for ; Wed, 27 Jan 2021 07:22:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 934A82072C for ; Wed, 27 Jan 2021 07:22:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 934A82072C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 258596B0006; Wed, 27 Jan 2021 02:22:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 207DE6B0007; Wed, 27 Jan 2021 02:22:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D1426B0008; Wed, 27 Jan 2021 02:22:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id E6F956B0006 for ; Wed, 27 Jan 2021 02:22:16 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B2292181AF5C2 for ; Wed, 27 Jan 2021 07:22:16 +0000 (UTC) X-FDA: 77750711472.16.can39_13037b027595 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 92F06100E6903 for ; Wed, 27 Jan 2021 07:22:16 +0000 (UTC) X-HE-Tag: can39_13037b027595 X-Filterd-Recvd-Size: 5073 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 07:22:15 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 726012075B for ; Wed, 27 Jan 2021 07:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611732134; bh=UmXZ4WGct5TD5g2zWBqeUZIY7+IEh1H1mojHQndD4p0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=oDBiPqUDddARVPP8esIP80QkXjEj9+85T5QDZeh7nu2cYyt+eQZA8QDXikjpMwlat MNfPUAT8hEpYvyQzrx6AP5DR+ANmDLKNYdk+3I1Le4ClABg804A6YrqVAha+HDnXt3 aXXje54ZXGe396yLREjvTO7F28tQlsy1EwE9vIS6460xIuuh3AzToqKFH1MkXqxaCP /NJx/3JofqwPazejWSqyqiZGHT+4SBSDqNllnI/Q9rYdu+otPvNjz6i73xOtGWI2Ql 1f8AcHX5BqzHDL4QaB+j75p6mcXxGRjds0fAREsI+L/1LEC6UF0JYg2RbF8i9aAb9k jpAFtWZcqE2ig== Received: by mail-lf1-f42.google.com with SMTP id a12so1277370lfb.1 for ; Tue, 26 Jan 2021 23:22:14 -0800 (PST) X-Gm-Message-State: AOAM5316qkxbYldR8WBDZgxj5wiRBKxvR8Jpzv+J82JAUutUoYtt4L3U g+mi7ztSHhYczHcRoF2Ez203dC9JE43LgM9AA3c= X-Google-Smtp-Source: ABdhPJxflUggj8S5jQsQ3WpKvrE0C44XGXqHsiBc4rX5F3+Z0c1NJpDcJfbjDkFKR5D14faCz9LusUBrixofxv3V23Y= X-Received: by 2002:a05:6512:5c6:: with SMTP id o6mr4374679lfo.281.1611732132634; Tue, 26 Jan 2021 23:22:12 -0800 (PST) MIME-Version: 1.0 References: <20210126145247.1964410-1-hch@lst.de> <20210126145247.1964410-13-hch@lst.de> In-Reply-To: <20210126145247.1964410-13-hch@lst.de> From: Song Liu Date: Tue, 26 Jan 2021 23:22:01 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 12/17] md: simplify sync_page_io To: Christoph Hellwig Cc: Jens Axboe , Jaegeuk Kim , Chao Yu , Philipp Reisner , Lars Ellenberg , Coly Li , Mike Snitzer , Josef Bacik , David Sterba , Damien Le Moal , Naohiro Aota , Andrew Morton , Ryusuke Konishi , linux-nilfs@vger.kernel.org, dm-devel@redhat.com, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid , Linux-Fsdevel , linux-btrfs@vger.kernel.org, linux-nfs@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 26, 2021 at 7:14 AM Christoph Hellwig wrote: > > Use an on-stack bio and biovec for the single page synchronous I/O. > > Signed-off-by: Christoph Hellwig Acked-by: Song Liu > --- > drivers/md/md.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index e2b9dbb6e888f6..6a27f52007c871 100644 > --- a/drivers/md/md.c > +++ b/drivers/md/md.c > @@ -1021,29 +1021,29 @@ int md_super_wait(struct mddev *mddev) > int sync_page_io(struct md_rdev *rdev, sector_t sector, int size, > struct page *page, int op, int op_flags, bool metadata_op) > { > - struct bio *bio = md_bio_alloc_sync(rdev->mddev); > - int ret; > + struct bio bio; > + struct bio_vec bvec; > + > + bio_init(&bio, &bvec, 1); > > if (metadata_op && rdev->meta_bdev) > - bio_set_dev(bio, rdev->meta_bdev); > + bio_set_dev(&bio, rdev->meta_bdev); > else > - bio_set_dev(bio, rdev->bdev); > - bio_set_op_attrs(bio, op, op_flags); > + bio_set_dev(&bio, rdev->bdev); > + bio.bi_opf = op | op_flags; > if (metadata_op) > - bio->bi_iter.bi_sector = sector + rdev->sb_start; > + bio.bi_iter.bi_sector = sector + rdev->sb_start; > else if (rdev->mddev->reshape_position != MaxSector && > (rdev->mddev->reshape_backwards == > (sector >= rdev->mddev->reshape_position))) > - bio->bi_iter.bi_sector = sector + rdev->new_data_offset; > + bio.bi_iter.bi_sector = sector + rdev->new_data_offset; > else > - bio->bi_iter.bi_sector = sector + rdev->data_offset; > - bio_add_page(bio, page, size, 0); > + bio.bi_iter.bi_sector = sector + rdev->data_offset; > + bio_add_page(&bio, page, size, 0); > > - submit_bio_wait(bio); > + submit_bio_wait(&bio); > > - ret = !bio->bi_status; > - bio_put(bio); > - return ret; > + return !bio.bi_status; > } > EXPORT_SYMBOL_GPL(sync_page_io); > > -- > 2.29.2 >