From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49AF6C7EE31 for ; Tue, 30 May 2023 20:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8845E6B0072; Tue, 30 May 2023 16:41:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 834466B0074; Tue, 30 May 2023 16:41:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FCEA900002; Tue, 30 May 2023 16:41:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 60CAF6B0072 for ; Tue, 30 May 2023 16:41:13 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2DF0DC0351 for ; Tue, 30 May 2023 20:41:13 +0000 (UTC) X-FDA: 80848091226.07.C7C66F9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 47EE51C0017 for ; Tue, 30 May 2023 20:41:11 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=huQNFFH3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685479271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f0FfbwKrs0SBrp2l9jpO6xZkWlpiXTIvCrrrNrQOtjU=; b=xauUROVW3qauGSwop4m5eJecqf90OL0IMgZzl2e+d4k/yPsjjLS+obMbiK03d3PZrcI0Ee 4U8XgBuqcGAgrih3fO5alMlQXjOOQtbXkbERvnd2PG4O78ILkibti3eazPCEvyUwRpWDip 8SZoagAQSVimDxifUW6Ntc8RGG4YwE8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=huQNFFH3; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685479271; a=rsa-sha256; cv=none; b=oc2Fb3I/IW/+GtAEED7lkEhREyY1JiSPhOc817xyyCN6H7IqGjZFLAqcsRGz+P0e5KzJZc Ivn4YnTQFAi1s1DLsQ5XihS+GRuts/Yz4vEBV5A9UcCVViN7RRwgi9e4qLnM+5BbGtJV/w A3YLqIX4sOV+EtZizETjMEP9uI5Jwlc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2217263352 for ; Tue, 30 May 2023 20:41:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 898C0C433A0 for ; Tue, 30 May 2023 20:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685479269; bh=NZg4xbNptwq5J83x4/9FfgWYp2tn6LBMqAKgwyJG6tQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=huQNFFH3zVrLLnm5WPfMAbkQPvxCmvDcAuR9nNKd/g6ZoLU+oubgPMfhcvejhwbMy bRuBct3r6wHKkzYqhqEvGFfCpZYRAuAiT3wzv9jYwpqlslolPQpVoC6l4bkxTW5cgq aHvAkKgwybK+QQl1B0Jilwhzk8yfsI7fuifW9XQTkoKFITI0dXVq6KXEBzrUICZPze PyVOTDar79WsVhr08Ikvo3yCjwDdtgjfVU2jkcBlq4rrXYZPDH8DmVzyUBEoHLrosB Mkru2m9rHaX4pyzYCzA4oMl+/2mViC42oBWSv4cVmV6MbUN1IWMmZVyQlgMZsMsif+ TJLaW7xm4WLyg== Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2b03d3e41fcso3085251fa.0 for ; Tue, 30 May 2023 13:41:09 -0700 (PDT) X-Gm-Message-State: AC+VfDyNMNGaG8OpxKShUaPwIr0gAog0KHmw5HjP3fv/CuNaIIb5EbMF 2nq/Z+S2SEnomx+XmahMdLjB2Wm6eCttU+8w9LU= X-Google-Smtp-Source: ACHHUZ7vuf2vQNikh852gIOeYbs1mAspWrnHLpuRQ0WVk/9d/YVdWPAiSzLnXbcDRj80He113UbugMRuu4yM7AjsQxc= X-Received: by 2002:a2e:a222:0:b0:2af:18a9:782f with SMTP id i2-20020a2ea222000000b002af18a9782fmr4570675ljm.0.1685479267531; Tue, 30 May 2023 13:41:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Song Liu Date: Tue, 30 May 2023 13:40:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 13/20] md: check for failure when adding pages in alloc_behind_master_bio To: Johannes Thumshirn Cc: Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com, Damien Le Moal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 47EE51C0017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: fg4iijqskd66foj67sjg451xoae9msja X-HE-Tag: 1685479271-994289 X-HE-Meta: U2FsdGVkX1/bHPVvbkpgnpMVt6gO5VWIbhyM/rsGND4JW8csHxm+NCE+aJXWogHe9qGQ+Ls2JhBr0J2T0PvgdNwakaB9oLZqc6rVihTjpalW3BgmWRaKVgPTS4P9V0zKvnJTCJzl/t6bwybPBxKKiDiqT3pXzqQ+04dmxyrR4zA8DEaA8Vs0upq8eOr+wTIyeVJondv/hf9pAnplDqF88ervKJVwToSZO93nnz9G3iewrdhnnHo09Aqjuk+AtSoxjEzED3SfoZ0bGz2bILJNhbASqTLC5sLHdWMX8FWQDlwEL4SdXbu3MQWiGaGrvBQMYa/vQNl09B8bWT6rWuouT6IOtTsn2jWbjXriu3ZOcWNEGN6ZzAsMop7BoWnjgFXfBjUJOJX8/NK7hGeOcltPfwZe2XqWzZV1cgj5bCGqwvB6UmVDmyddNl3q8zJeyP5cFYEX6WniCsLdythUa4Zt8aBJE2NZJxlA0K4mtgmteCT0E5tMgkLEKlEPy47M6hAmuYHekwhYSPBr+UPJ+/DLA6RIR9yhgNb+Mqm/8MvGF8J7Ntt+TOEtPtueJHPPvdFa8L24njEpRET2+Mf1STNcTsU8Gm4j0LrflnejhgVn8FAujcJAq2f1pYC16KXMAdlPsegTxn3O/nM2TyFqUpoPwK/w9I++axcENr5q4sUDI+4QhpHPMdXbnXCQAtpyiczMpedrOIeTb+CbFOYGrjLHXQOFJw5OIekRcp25r315gfjZLWkY58p5QwwvTpErtDsXwun6sa04NXpxMx+2L8iFX/BK03uxGOF0v2N6kIphh6aTZ/EQ068bsJUofwpE+ZI56mAxlKJCXaLZjlxTmKry7sB25ySDzUNTMNj4V8U4kKUEtDVlbd20cE3YzcQwszmf9y6VCIDHdUG2vQVNHoe4cuxzUOeJvP8lCHT4hVnq/LM/uixWUT5HWvyxEC7MDeBTH2J10hqq/cya1KDmWmP E5Chzn6L XcYGmi77xyVxYnzSmwpyDtvTn3pk5D5G6xLt0Dpg+DeCsOUVC0CjC3nxonxU1o75snMHIoc5UNKwZDPXRYf30XSGo7p41xtHYBaJIDW7M6ffUfcWvIKB6TgzcuMbXq357ljoRpiH2zOCkCT0B5fyfigJnGL0xO6aQPuKQq/X2evcQskxc/a/Yb/SGWhDCF4+XclRJ55rocfwX0wzaxoJgyqQKAr0jX8SDawX+JzpW0bKyCztMhGE2q6wBJJTEXYnYcS90xvN/xIUTvILhJGuEcJnPnIH5wTjc9hGTLfMgbOamHi0oWMcxokXFXyf8jU2Xp1jzsXfi9oeeLF4PIfa5PnDZ0NMPFDxT7d+i9SULhxGiV1bhmLfIWk+98aiTMq15Oipg1CsmEm+4x7D9J0n5NtusvshEIi+hCON9SQuf24h6pMz0e53TGNJVtpk4E8+c4xAHyLVpaIsJvzrwCJe3pa9pyGCfcdqAfYRs3SVj/Ncdkbk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30, 2023 at 8:50=E2=80=AFAM Johannes Thumshirn wrote: > > alloc_behind_master_bio() can possibly add multiple pages to a bio, but i= t > is not checking for the return value of bio_add_page() if adding really > succeeded. > > Check if the page adding succeeded and if not bail out. > > Reviewed-by: Damien Le Moal > Signed-off-by: Johannes Thumshirn Acked-by: Song Liu > --- > drivers/md/raid1.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c > index 68a9e2d9985b..8283ef177f6c 100644 > --- a/drivers/md/raid1.c > +++ b/drivers/md/raid1.c > @@ -1147,7 +1147,10 @@ static void alloc_behind_master_bio(struct r1bio *= r1_bio, > if (unlikely(!page)) > goto free_pages; > > - bio_add_page(behind_bio, page, len, 0); > + if (!bio_add_page(behind_bio, page, len, 0)) { > + free_page(page); > + goto free_pages; > + } > > size -=3D len; > i++; > -- > 2.40.1 >