From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65C26CFC5E7 for ; Thu, 10 Oct 2024 17:18:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA6486B0083; Thu, 10 Oct 2024 13:18:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E56476B0085; Thu, 10 Oct 2024 13:18:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF7366B0088; Thu, 10 Oct 2024 13:18:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AE5FE6B0083 for ; Thu, 10 Oct 2024 13:18:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8B161A0A50 for ; Thu, 10 Oct 2024 17:18:30 +0000 (UTC) X-FDA: 82658351874.26.0F753DA Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf10.hostedemail.com (Postfix) with ESMTP id 6EB59C000D for ; Thu, 10 Oct 2024 17:18:34 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ohS2ZEJg; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of song@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728580687; a=rsa-sha256; cv=none; b=NIJw1SUJ4/JilT7j36aQWuunjAsXp7N/wn50a3Nu19GDPTSwiZJ9/Rm2CvrtKzklSUMnTy yrJ2e2XiYJHiiZjH6FXC8otfujuSPqGmybXnrT/qfaiVpRjEvh5vJU3Hx5SqZ/NqjfvUeO 2iRgZuXVLV7ZYxopsAFVoOPO/BM07Vw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ohS2ZEJg; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of song@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728580687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YWTfDGJOVIcVIWG5RKfiNKmMCfgGLl0hOHgzmSzW7HE=; b=RLNXEiOotGufTHXRMtBPnC2fyncobVTHiRVa2fYykwt/7UrGNXBKyuVxhRl1tftwYev0zp AUGeOo+eZCYTCRTpjAGiYd3ua5bfbpLU2+YhbHKAlBULvr+6AvSZya3ODpZFfb34ZimzLr Zd6Fody90/az7O+BwTo49nQoADeS7jI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 75A2CA44C2B for ; Thu, 10 Oct 2024 17:18:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10915C4CEE3 for ; Thu, 10 Oct 2024 17:18:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728580712; bh=vaucBuX2fMrEpT3kygwI4CcFnWG5blOdj+4yYIH1/lc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ohS2ZEJg9qBuI0SAkSL1XR/EeS8598zu72QfILrMEzXncFKMx6qICQZRdntjMsS/p SS6wjgHM1U93bHcBct/IZh7SgaOrlXJEsw/7AsIN9FDOB9Cim3DKPCD1ZdTCnU+E/9 QkNbFKkk7LUWrjaR+6Kko9xboDHUQcQEWDsodeLqwyooH3PFVOCg/3h+jLz/x5fLQf Y40BxFHxbl/QXSOFmytnmoFjUWMjdXm/FX9bkZk7nVSyUFa1ddzH/vzAu9m9Rx8msK AV+ZIMMHAB+Mz9A7bTRR8jxso5y3dofixzeSNtFEgi9wex/HyEj0rlhLqzIp3xQsva QX8SZQu1NQsEw== Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-836d2437852so26910139f.1 for ; Thu, 10 Oct 2024 10:18:32 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVt8/CMr/XESwpCWisPPJIHt4cN4ui/RINf9LO0Cb9wpT+xiR3WT4u4SjKyDXRUWN3suXprncWETg==@kvack.org X-Gm-Message-State: AOJu0YxI8aH0Y3XnoXA/+hH32/RSJWm6eyIfraMuWR2BECha01bWmDzD vGRyKoAWVMB/E7NxdXYtcJHx+V1Vqa6qJp1L4bsdeNRIdCHqHNMgVPNe84nl+fF2I/DwIkFQa+T TI3ar2dzZ9yfyb7DUgjHs2RyfZRQ= X-Google-Smtp-Source: AGHT+IGszKBBrf1gYsUhslMqcPNpC/f6sAFFbsmL+u+zGmeEd2sYZs3+7Tvb9T+CKCsx/nhk3yidKvoEgysxI18Lmn4= X-Received: by 2002:a05:6e02:144d:b0:3a0:92e5:af68 with SMTP id e9e14a558f8ab-3a3b51daa94mr2839515ab.15.1728580710921; Thu, 10 Oct 2024 10:18:30 -0700 (PDT) MIME-Version: 1.0 References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-5-rppt@kernel.org> In-Reply-To: From: Song Liu Date: Thu, 10 Oct 2024 10:18:19 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/8] module: prepare to handle ROX allocations for text To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: u3fsssb3dgcjdufyps5b9mt1bm9k3k6b X-Rspamd-Queue-Id: 6EB59C000D X-Rspamd-Server: rspam02 X-HE-Tag: 1728580714-424944 X-HE-Meta: U2FsdGVkX18vlgzCjlk6kDL6FKDJZkY6i4jYMCY3XCRSt5h9+mvxuTkAWxKCAXIGzmZ+FNGSvkL0XEAVxnG1syxcuqeIf7tJDQoLElmMkwSTmmocdZxxtHvmJrVCmdYpsF3MGy66AcyJCI3m+7XYBkQ+ywE8qy/hUkzICR+Owhwv4EX5FXvuzPUgSnRQ7oEICYO5OPXbeluv632zWK9j1x3VwNhJQ86zfk4BtPTxstC2cO8Z15JbBk0gce7K8BLHXki85T1PqdgevXSrsXFpmZJF5EXwi+/R0haOtDWzQqLuXKc+gndEsKBVpbn2SPa2mty8pLNQ+S492CDvv1hvpTe/x4VREKkgrgXoeXX0ulu8z7E6GzYz21WNWBTojmT7VqceXv8jFXm7cbVZnECY62GvUNeI+l6BsmuniPGRZ3i2DO0wWt3hmwtgmp3FSnjRxzwja648njOicybPst3UsWpCWFFMmzZfgarurKlHOkorVzkcE/qFy04uuVelAKhy7+tCwU+CSEvqO1ZvXNvF05zNLUEZ6FBf9idB/7+WyKoMaRmWJNgkrFtJhaZDjAN3cSYsxSFn37oVfffJ+ePXnIfCgvktj+0KKvcs4s6udTgxjVO5WioGyBngdXVjgn3sbd5MsO9sEos6NRDQKCsFMHRfyYijThM9Ekow1fQJz13FCP0xvl3k9qVaM9ZJ4XLU83cMnS+hd1FX/KpsOJH+cbTsAGWX70miTxSsHwzcl9NLeD4JopfOe3KhiyS+ozZEs9DG/rcp5dcucpUahwwO8/LgtqaRrX3fqN6yG3TRXI72RAzKyyOnnV2ByyREav/4ROIo/XsEd31tdt/IJDd6oNhmNDr8/Qjr7GcmOkr+3waWZzKdl+jWp++k871FYnsNEcfRUs1tFhMpM7pcm6CDSWQwpytPITEyObArEFFdfow0RKWU7l4j43hI+HRyRAEgmqjvTuJFAJKjdMUaGZM OLqJPJfy J5BPX+A3wkfmi9frm8OJO9CiEyUPW0UWtg/jga+za2pmv7OQkN1vQGYKSlFHW0uZVyHccAgDg01c/tyIcCBaOz5dGHSLLmVoaqRNJfrdOmhPq8AC9LYhQFOhkYWyUf+hZ2zckJZ3ctGpOSc39oIdMj38SY9l/KMIYm1ymb8RUQxgAawYjemR+V94OArgofUXHuYdIOzfHi+XDtlj4y6D6CDVPnYK5A2ZmMosfBnaHUuQNRcXo1R5U6rtN2evFu2ZF0O39HyzdjzlHpt7u1sLt4Sd/Wi93pVjBtoIB3gI/HjdA0z5eEFEy5UqgINWx7UM0YSv55yaxKZI7pfE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 9, 2024 at 10:47=E2=80=AFPM Mike Rapoport wro= te: > > On Wed, Oct 09, 2024 at 03:23:40PM -0700, Song Liu wrote: > > On Wed, Oct 9, 2024 at 11:10=E2=80=AFAM Mike Rapoport = wrote: > > [...] > > > diff --git a/include/linux/module.h b/include/linux/module.h > > > index 88ecc5e9f523..7039f609c6ef 100644 > > > --- a/include/linux/module.h > > > +++ b/include/linux/module.h > > > @@ -367,6 +367,8 @@ enum mod_mem_type { > > > > > > struct module_memory { > > > void *base; > > > + void *rw_copy; > > > + bool is_rox; > > > unsigned int size; > > > > Do we really need to hold the rw_copy all the time? > > We hold it only during module initialization, it's freed in > post_relocation. Ah, I missed this part. Sorry for the noise. Song