From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21A0C433F5 for ; Mon, 11 Apr 2022 23:52:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A1146B0071; Mon, 11 Apr 2022 19:52:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 727A76B0073; Mon, 11 Apr 2022 19:52:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C9096B0074; Mon, 11 Apr 2022 19:52:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 4C2916B0071 for ; Mon, 11 Apr 2022 19:52:57 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 21F9881B30 for ; Mon, 11 Apr 2022 23:52:57 +0000 (UTC) X-FDA: 79346251194.14.F443C6F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 818FE20008 for ; Mon, 11 Apr 2022 23:52:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB7EE617C8 for ; Mon, 11 Apr 2022 23:52:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89BD7C385A9 for ; Mon, 11 Apr 2022 23:52:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649721174; bh=MA2honiXWGeOzO9WdwjpEsoZG2CtJDXDu3X4YUBIiQc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jdxbEG/cJ9bBPd0gnfltrog660KLU3COJSzzRSbWXk0ogQLHldVpvIsV35eeIAPq8 ulRhfQGXvvJPezfASRtce2+HmrpPTMIHbiSVMKVOt+QGSZ/AGS/Icda7n7BLqU3Nj8 dg9q7uGUmHZSoIlI9WttHJ+1tZjxSWtEX0nz+w0O2+XUWmLjpNqYD2aq56s0R9hX/7 Zqfwk9d8RFuZeLkafNhpc46EGa6nfi3rqTnc2vihzYdHGNxoqI7VO/b18TzLOsOqb9 8vZl9lfuDwzzS0yvHFYbJMI/xXlgZccHednOvnvhb6IwHus09/2iMAdod66G1iBTFq QmthySP0p+TZg== Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-2ec05db3dfbso62899247b3.7 for ; Mon, 11 Apr 2022 16:52:54 -0700 (PDT) X-Gm-Message-State: AOAM532LH7PqDdGn0Jbp6WHO8avsQSjsBdJGGZMmqA1jxHXWTMlZHUV2 nLuF/4NLeJBW6SEGzHacy0QngA7UIXtXemYP5mE= X-Google-Smtp-Source: ABdhPJy/zaZyKbdypj1Ir6pRoTfrzhUUja8HYbw1+PrL4w3DfKO/U2kKNazR+UqBBUv9umC/SnpgklvN3WCGaxXljB0= X-Received: by 2002:a81:14c8:0:b0:2eb:eb91:d88f with SMTP id 191-20020a8114c8000000b002ebeb91d88fmr14373906ywu.148.1649721173532; Mon, 11 Apr 2022 16:52:53 -0700 (PDT) MIME-Version: 1.0 References: <20220411233549.740157-1-song@kernel.org> <20220411233549.740157-4-song@kernel.org> In-Reply-To: <20220411233549.740157-4-song@kernel.org> From: Song Liu Date: Mon, 11 Apr 2022 16:52:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 bpf 3/3] bpf: use module_alloc_huge for bpf_prog_pack To: bpf , Linux-MM , open list Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Andrew Morton , rick.p.edgecombe@intel.com, Christoph Hellwig , imbrenda@linux.ibm.com, Luis Chamberlain Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 818FE20008 X-Stat-Signature: bzpop769o5qz39dmuaetchih5ozyo6cj X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="jdxbEG/c"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org X-HE-Tag: 1649721176-2996 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 4:41 PM Song Liu wrote: > > module_alloc_huge for bpf_prog_pack so that BPF programs sit on PMD_SIZE > pages. This benefits system performance by reducing iTLB miss rate. > > Signed-off-by: Song Liu I am really sorry for spamming the list twice. The first set experienced long lag, so I thought it didn't get through. I also updated the commit log of 3/3, and this one is the latest version. Thanks, Song > --- > kernel/bpf/core.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c > index 13e9dbeeedf3..fd45bdd80a75 100644 > --- a/kernel/bpf/core.c > +++ b/kernel/bpf/core.c > @@ -857,7 +857,7 @@ static size_t select_bpf_prog_pack_size(void) > void *ptr; > > size = BPF_HPAGE_SIZE * num_online_nodes(); > - ptr = module_alloc(size); > + ptr = module_alloc_huge(size); > > /* Test whether we can get huge pages. If not just use PAGE_SIZE > * packs. > @@ -881,7 +881,7 @@ static struct bpf_prog_pack *alloc_new_pack(void) > GFP_KERNEL); > if (!pack) > return NULL; > - pack->ptr = module_alloc(bpf_prog_pack_size); > + pack->ptr = module_alloc_huge(bpf_prog_pack_size); > if (!pack->ptr) { > kfree(pack); > return NULL; > @@ -889,7 +889,6 @@ static struct bpf_prog_pack *alloc_new_pack(void) > bitmap_zero(pack->bitmap, bpf_prog_pack_size / BPF_PROG_CHUNK_SIZE); > list_add_tail(&pack->list, &pack_list); > > - set_vm_flush_reset_perms(pack->ptr); > set_memory_ro((unsigned long)pack->ptr, bpf_prog_pack_size / PAGE_SIZE); > set_memory_x((unsigned long)pack->ptr, bpf_prog_pack_size / PAGE_SIZE); > return pack; > @@ -970,7 +969,9 @@ static void bpf_prog_pack_free(struct bpf_binary_header *hdr) > if (bitmap_find_next_zero_area(pack->bitmap, bpf_prog_chunk_count(), 0, > bpf_prog_chunk_count(), 0) == 0) { > list_del(&pack->list); > - module_memfree(pack->ptr); > + set_memory_nx((unsigned long)pack->ptr, bpf_prog_pack_size / PAGE_SIZE); > + set_memory_rw((unsigned long)pack->ptr, bpf_prog_pack_size / PAGE_SIZE); > + vfree(pack->ptr); > kfree(pack); > } > out: > -- > 2.30.2 > >