From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37138CE7A91 for ; Sat, 23 Sep 2023 22:36:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 577806B0286; Sat, 23 Sep 2023 18:36:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 526FD6B028A; Sat, 23 Sep 2023 18:36:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EEE16B0293; Sat, 23 Sep 2023 18:36:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2F3686B0286 for ; Sat, 23 Sep 2023 18:36:20 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 07394A04EF for ; Sat, 23 Sep 2023 22:36:20 +0000 (UTC) X-FDA: 81269322120.25.6CB42AC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 1BC921A0008 for ; Sat, 23 Sep 2023 22:36:17 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HsXeC8Fz; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695508578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GV8FPAZPppds7kd4N8nGB6smCzlB8t5yR0hR1St5W3A=; b=S1q1wEHoETyh1MfRGOhDnzM2eewKR9ojVU7kRB3r6mvRzlOO0xjG6GB91jdRdoxjouW7Hn FEp+NgsONJ/GpfdKIJZVczqVvsbn5p5AoE2SptlhtyjvsM4cW5SgsUWO9QSycroTBi7lo7 XXmWOArP0rnIVt0VAnoo56mtbjJTvFE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HsXeC8Fz; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695508578; a=rsa-sha256; cv=none; b=EvuLZrbILTGHZc4Ns5lSB/1kPCiL7bm7/LQ1m+m/hNR+OdRKZkuLsapT49jseDTBFC3Gz7 A8kZxeZv7MRhipY3gwagCCv9EJJa5cGwHnmQJjJt92tv80XPxIpxHQmfnYbthpDYdqUkqD TCO6ieprem2xhwGHKC2wuPscQXV0TMI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1D66160B95 for ; Sat, 23 Sep 2023 22:36:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02B08C43140 for ; Sat, 23 Sep 2023 22:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695508576; bh=p6KwkG6gIDCpi+5ECOWCYMC6fT/RtPXwryMv7tZb+xk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HsXeC8FzbnuL2HGBLJZiuCDBblJ3dC0CWJZAs7Ko9Pk0M9quq/h5gqiWTqvrdcgwk itKojR8YTR5ZBLsDVT+aVMKIf/+4SYrOFwd/ZyLEbjm7omRRiWzviOumN9tiOOdnYJ ALYv4PaFyHMzjV7o2XFeI8EdbI8lLpQm06kuLrCiYQ+VE7VxvnEjf9LyC4q/8eQo6l nGIKccvQzYkcSBx7ujsOkNay4Ive+Liq+LoCw+rptMs27n07a/FqcH2Vg4DkRpHXHs aw4RsjS5gQWL57hCW1ty8y+9xbRAkIK6sgZ3PssfBL/jcSH6zIeiLfRwU8+hpo+Vua cFXFeedFkSJfg== Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2c008d8fd07so68451291fa.1 for ; Sat, 23 Sep 2023 15:36:15 -0700 (PDT) X-Gm-Message-State: AOJu0YwwW861Frgf72SA3ZhJ00xSAo9CGOAT5IAf8y/Qd60YTHdl7fmx aDI1wEtg/kVn7ugN1XBFa7GwAAwcmk9RoR+3CXk= X-Google-Smtp-Source: AGHT+IHGEMyzPMP0PdtKXqSKknw0oXHfeYEIvmKQhWxGVhq9jrC3LZkcXvNIlQvBWHbanSZQKP0MnXe/fed+WldiSzw= X-Received: by 2002:a05:6512:250d:b0:4fb:90c6:c31a with SMTP id be13-20020a056512250d00b004fb90c6c31amr2958776lfb.14.1695508573892; Sat, 23 Sep 2023 15:36:13 -0700 (PDT) MIME-Version: 1.0 References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-3-rppt@kernel.org> <20230923153808.GI3303@kernel.org> In-Reply-To: <20230923153808.GI3303@kernel.org> From: Song Liu Date: Sat, 23 Sep 2023 15:36:01 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 02/13] mm: introduce execmem_text_alloc() and execmem_free() To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1BC921A0008 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bfdgwubttxj6sy95cngg4ymoqoaob5ro X-HE-Tag: 1695508577-352176 X-HE-Meta: U2FsdGVkX19tHINYZpQqZkuuCJWbKFS7n0I/jXT/23OYfq0SjW4gh2wwt35GLii4RrRsqZsLifYHOKQxuAnQo7lSAO9rkI7hpMGcukuIYN631Onb3QEdLfa8QuP/Vqv3S29fLFQUVhQokY7tJFUablNcqxXSrhiQd1UnYMQQPWNSMmkLyBz4rRSJi3gMlNp9v4Yw4gxsK3qxfuUb/fWR0G8iV8PLbB4tDu80P306jLk1dJy2EYHXf7YamsUuGtAJ+FC42vVj7gfHo/GEkWiqobpffXzvtZq4cEG5sv1uIJygS0058dyvfedtd4GWjQws4TY4tcIy3MI99EUTrM1Wnk+MVAnIxTKW7VLcUJKyre9jnxQ9oxnVgfqmX7OpTnO3A/Iz0zKJ1e+/c11B2PVbtmh/2oXFtM2+s9jnGYhHpSzKeIHsXjSe3dPTrqA9fRQeIwbme5hBzEYdeg5eQfkcfuRSO3Waz1WkeTWjQCk9KXLOWIxtTQLDXW+LEUcvaSZVHOMQltea7E+o6Nf7QF0c8oBrKa22ydmGTZmWCAYHqtI3sL4uzHmoy/zoIeBFyIPXPfeYlTuQRsfza5DvYi4dmHIXd2YPuvcfE00MLYvfkCfs3ATOcGkCYWJEC3FZOU+SyFCIvbW2ihH9Su8T7jVCwe5RCMhyrQPiYpkB3mMLbltFNvGQEdH30TSC/E24WEooL974XBEEhwtMowS1NFJ/y92aKYCiVJY3ylmWwPFCJTvxU85/KTCfcKAdmdRgRr8ZuqHS/EE2dfrgX1nZWfuKCsX8LSkW90QTUwMwBACJ7Py6rLOKmEYPNusJjR5Fni6UurVHveOhdgf4kjgZypdmdGO0PEwAOU1tFC9JsN36Ez/HK0EKUslUUClfY8UkKr7tolvdIab2omg4mtBK5c3twhxIlxR7j1wkp6IAExfF5DEE+f4s9iCO+OGCzf9wmxyQkMPPC8TaOidmm3UBqov 5INOQjiA QuZlBdQIZyUJclD8M3Ta5RuwgODuj9I1OJGK6OF1afQd5Ej2YJbVe6JJ260gji03j1H8qnhA1KTcvlc6S+5E9Dlmi5M6/kaYH4SBUaJbLR+ZQr/sixSKK6LKul7xx61OYeTE//FgHhp9NPi1OEGkXynEinlOc0fpdVSJYyNf2BJ5zKtbXc3RNWgyD8gg8XQOqEzn2/0hBFtDIA8nYZshnp3buBDGQrx34ehoCOaP+gmyUQtqWeajU5lmQV0/G+UgH7DTdIZA6xy9uJDVA6SpUNQIzsF9yme2669/Rs7BmvQD2ODvzO4UoU65G9glzO7UGKly0Q4BOm291GOn9V2D9xrtkchJHbSMKu+8vDsgK2N1gt9fhoeQRnqG9KsxB5icrQ3xTUZGDicoLO7m9YsVGsC1wzyvlC4Mix5fP7mk1UUQA0neAPkovxhx4Mw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 23, 2023 at 8:39=E2=80=AFAM Mike Rapoport wro= te: > > On Thu, Sep 21, 2023 at 03:34:18PM -0700, Song Liu wrote: > > On Mon, Sep 18, 2023 at 12:30=E2=80=AFAM Mike Rapoport wrote: > > > > > > > [...] > > > > > diff --git a/arch/s390/kernel/module.c b/arch/s390/kernel/module.c > > > index 42215f9404af..db5561d0c233 100644 > > > --- a/arch/s390/kernel/module.c > > > +++ b/arch/s390/kernel/module.c > > > @@ -21,6 +21,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -76,7 +77,7 @@ void *module_alloc(unsigned long size) > > > #ifdef CONFIG_FUNCTION_TRACER > > > void module_arch_cleanup(struct module *mod) > > > { > > > - module_memfree(mod->arch.trampolines_start); > > > + execmem_free(mod->arch.trampolines_start); > > > } > > > #endif > > > > > > @@ -510,7 +511,7 @@ static int module_alloc_ftrace_hotpatch_trampolin= es(struct module *me, > > > > > > size =3D FTRACE_HOTPATCH_TRAMPOLINES_SIZE(s->sh_size); > > > numpages =3D DIV_ROUND_UP(size, PAGE_SIZE); > > > - start =3D module_alloc(numpages * PAGE_SIZE); > > > + start =3D execmem_text_alloc(EXECMEM_FTRACE, numpages * PAGE_= SIZE); > > > > This should be EXECMEM_MODULE_TEXT? > > This is an ftrace trampoline, so I think it should be FTRACE type of > allocation. Yeah, I was aware of the ftrace trampoline. My point was, ftrace trampoline doesn't seem to have any special requirements. Therefore, it is probably no= t necessary to have a separate type just for it. AFAICT, kprobe, ftrace, and BPF (JIT and trampoline) can share the same execmem_type. We may need some work for some archs, but nothing is fundamentally different among these. Thanks, Song