From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DA56C43219 for ; Thu, 3 Nov 2022 21:04:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB1A36B0072; Thu, 3 Nov 2022 17:04:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3ACA6B0073; Thu, 3 Nov 2022 17:04:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADAF76B0074; Thu, 3 Nov 2022 17:04:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9ADA16B0072 for ; Thu, 3 Nov 2022 17:04:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6F19F141503 for ; Thu, 3 Nov 2022 21:04:11 +0000 (UTC) X-FDA: 80093358702.17.CA4B6E1 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id E696E100004 for ; Thu, 3 Nov 2022 21:04:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 075A5B829FD for ; Thu, 3 Nov 2022 21:04:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15238C43143 for ; Thu, 3 Nov 2022 21:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667509446; bh=nseTDyxyu0yRm9gZT+OFw4Dhw1UAyXHDHko2gLKfinI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qMT8ajE9HpOjUvF3ngCGud3jLZw630zCFxPea8P644TVB6oZ1aiZxm4qFOikMFG/G X/MjikTe8THD4a2ve5KVJZybanlLm/UYLPish69/vjHtWKefOF3aFjLkqdIM4bY6Xb AcwGjrO2TirgEhQ1SX3NOShdmDxXr6Ntr2rvCcEuPBOI+EcF9YUc1c22K8ZkFwMC3N xeQfhEsPZDawtey6TVui3idmHGIa15qxqlQgy32EiZKM/kHV+ytGmEIEch2Qmfijsu swTnXlUJyW7xMByjIIF1dpjibZ/EjO/Uq8MbxlFzXfly1iquArcpFfddseN4wmz4G0 isIRXB4qHXVOQ== Received: by mail-ej1-f47.google.com with SMTP id y14so8567370ejd.9 for ; Thu, 03 Nov 2022 14:04:05 -0700 (PDT) X-Gm-Message-State: ACrzQf0D+DpvJFwoV2S9lWEGXcime1iGantcbEFGJfYVUs8rgDMvKaLD 1lNrP18T4/YjJuGtUgQb0qaMsqLORm5hT1UFHfI= X-Google-Smtp-Source: AMsMyM5+SExDA6gWyjMON5e/XKuPJGG6vDE35nbZ27zwUi5RdN79dqxVqX7NELDyhK2eWMgtZlV9HPjujhJ4RApDCUc= X-Received: by 2002:a17:907:628f:b0:72f:58fc:3815 with SMTP id nd15-20020a170907628f00b0072f58fc3815mr30383160ejc.719.1667509444205; Thu, 03 Nov 2022 14:04:04 -0700 (PDT) MIME-Version: 1.0 References: <20221031222541.1773452-1-song@kernel.org> <20221031222541.1773452-3-song@kernel.org> In-Reply-To: From: Song Liu Date: Thu, 3 Nov 2022 14:03:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH bpf-next v1 RESEND 2/5] x86/alternative: support vmalloc_exec() and vfree_exec() To: "Edgecombe, Rick P" Cc: "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "hch@lst.de" , "mcgrof@kernel.org" , "peterz@infradead.org" , "akpm@linux-foundation.org" , "x86@kernel.org" , "Hansen, Dave" Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667509450; a=rsa-sha256; cv=none; b=nz872dXOg4rDSmcxS5/wFcbRc3bJ9uDp3tmMwPa5hSwULHhkLO4IAj2Umy/TdWj/p1tTBx GQVaboPldhD7iardwl7Z8bltmPA+uF2oArXtlwYToYVBjWdVVqKp2jm7iEDEtoy5j+UCtX UmJO3lb135mdWhqUmlf70aI7hPGS8Ak= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qMT8ajE9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of song@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667509450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y1Ajm7flee4mMQW6HwVa1QRnV0l+Ka8HvNT6W5pKruw=; b=adqHEDf2cZKS6GqNc9FbV9KC1uyqB3nCmxGh+QSuggC7L/Mv+CqM+hNxVg35ZHmOzhaw8h vzMtJDDrvSakbo1YSpX4FNfsDf0fOq2V2K4GtzD2wggQwurmJXneSTryI+/Rf2YewLeIq+ 1XzJdk6Gprb3WA3EiYx5YcvUDstqwo8= X-Stat-Signature: fim3chsyrqpry5dxp9jh8tppwruw3yi8 X-Rspamd-Queue-Id: E696E100004 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qMT8ajE9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of song@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=song@kernel.org X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1667509449-847377 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 2, 2022 at 3:22 PM Edgecombe, Rick P wrote: > > On Mon, 2022-10-31 at 15:25 -0700, Song Liu wrote: > > diff --git a/arch/x86/kernel/alternative.c > > b/arch/x86/kernel/alternative.c > > index 5cadcea035e0..73d89774ace3 100644 > > --- a/arch/x86/kernel/alternative.c > > +++ b/arch/x86/kernel/alternative.c > > @@ -1270,6 +1270,18 @@ void *text_poke_copy(void *addr, const void > > *opcode, size_t len) > > return addr; > > } > > > > +void *arch_vcopy_exec(void *dst, void *src, size_t len) > > +{ > > + if (text_poke_copy(dst, src, len) == NULL) > > + return ERR_PTR(-EINVAL); > > + return dst; > > +} > > Except for this, there are no more users of text_poke_copy() right? > Should it just be replaced with arch_vcopy_exec()? I guess this is not really necessary, as we may have other use cases for text_poke_copy(), and the text_poke_* calls make a good API. I won't object if folks agree removing text_poke_copy() for now is a better approach. Thanks, Song