From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C592C0015E for ; Fri, 16 Jun 2023 20:05:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BB938E0002; Fri, 16 Jun 2023 16:05:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86AC58E0001; Fri, 16 Jun 2023 16:05:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 733248E0002; Fri, 16 Jun 2023 16:05:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 650108E0001 for ; Fri, 16 Jun 2023 16:05:48 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 328CCA0CE2 for ; Fri, 16 Jun 2023 20:05:48 +0000 (UTC) X-FDA: 80909691576.22.2390B8F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 3076F80018 for ; Fri, 16 Jun 2023 20:05:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f6jdPi0v; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686945946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vP06fhDEQJD3la3PEjDzHE2/n8fHAR9RhYKfFR/koK4=; b=JviJpxnEa1XMtqIf/p+onbF8S4IBwMqjMJcyBqC64O49W2a7jGP5htepAfZxoWa4nebgxf 3mMH7CF/KbQszZFhViNMOsGaJACufyIOz30nuQiFkPbeZ9bH/SpFq0WqqDPS4xlXi9KW5X FTOWrsCwNUqMh0lL9NXbxfmy+woBP2k= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f6jdPi0v; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686945946; a=rsa-sha256; cv=none; b=ET5uvpXxwca0bZ80M9GCTdiyFO8/w14W2ckN6vUCKW8J/j3WBzdyZxnysNBpU5DqlZr1bv wXb2HC3xSyRyExYe5ZBefCizuQflcL/A7D8Qqm9OY3FqIX7C90eBufIQrMonB8FgtB8TH2 zJcr5RbyXJjWdU4tBAyNR4suXeBavwQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6471163D5A for ; Fri, 16 Jun 2023 20:05:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C164BC433B9 for ; Fri, 16 Jun 2023 20:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686945943; bh=WtL681uu0xgDuNDCtnoYcQSLjySma9uSe62fWHoJUhA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=f6jdPi0vbCVqLqgQDDmD+GO6OBfmTAAnNSnv31ejf0X579gkscpmfn1bTrsu+q2ra 40XK5tgjD4Pn3DEwgEMNXaNpAJoNV7jL4P4r8shZe9dBhyksUMC8rwkwFkvZkFVkCR IGp3JmtLPxLnrzx47G+lStd1hKB4UgLYKewi3Ki/K5woVsZktBsRAZ2Di1MUFiXRWn 1YkJryPbn+hll4loxeYSz5PcOp11n7V/droF7ZpB0pqIuzSutJSGr0pq7VRjU9BgpD r54x5CfpgaRK4fVGltSX9D3VAd0D4uJxrcV171/lcN7V+Y7pDOa0WYzp0o27UZTPXi Y80FFy3waZkgA== Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-4f845060481so1571532e87.3 for ; Fri, 16 Jun 2023 13:05:43 -0700 (PDT) X-Gm-Message-State: AC+VfDwErFXRyktYfnR9kigQKHZHi9oJ7hghGLHqzB5klSCZD00P4hyC 485AcxnKEAmKI2g96Gpa52qqhZPgGarLzclodKI= X-Google-Smtp-Source: ACHHUZ7v0OG7lj710Dpkky2x3Qwl+xOOMZ2WmKSKGrGJ24Aq4/yPm9YniFAuyGWs2DWPlG6NvD65kdAaVeIKyOd6PQ8= X-Received: by 2002:a19:644e:0:b0:4e9:9e45:3470 with SMTP id b14-20020a19644e000000b004e99e453470mr2381818lfj.3.1686945941704; Fri, 16 Jun 2023 13:05:41 -0700 (PDT) MIME-Version: 1.0 References: <20230616085038.4121892-1-rppt@kernel.org> <20230616085038.4121892-8-rppt@kernel.org> In-Reply-To: <20230616085038.4121892-8-rppt@kernel.org> From: Song Liu Date: Fri, 16 Jun 2023 13:05:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 07/12] arm64, execmem: extend execmem_params for generated code definitions To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3076F80018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zcexj49zjb1wu47zefypddruy6q94jxq X-HE-Tag: 1686945945-789182 X-HE-Meta: U2FsdGVkX1+sd66PB7c7TAO+gzIR1tjjiYs6U1UeQZhR0Zyj/PjZT7A7zlBJ1g3sWW3Sh2ivRi31B9roHuUCBA2yxtVf9qgeGUgfAuH9QrxXt+qmC03ILMMcGWNLNgmu4ZfVl3wMn9ocW2kM9ZVKwjXCy6j+8WUaa/PbFJCuKNZcUtrNLBycbqGCGjb+D/faaygt+33LpEMPyqAgDCPbNn9qGgxtrXSyyrSHwWmMr/Bc8Rn4JgfgvhR5/+A60n+/su91k5ZN3fu8NtRzDgxzLgST0vsRIPHF0lEFQ8CxP9rXnIeLNwxAlkzmPfAdmAPnK96SfyM7Ptb7raGisDzA5Sxbcx3/mDrp61Y7oOm55vBuzjtsvZRzXfD/yPMhjY/nPX10jiz54yEp1VauAU0i95OZqaL6zjbDMOEpGAcErVY986GNCZz1/Uttcx7y03UR0KdJmWPfbw4MXpWLotHEcDLqRfXTkkcXm3HqZgauDgP2Em2QYqs81IgOq6sv0woYeN3WE/g+580BqM60XzgfPwW3EVM0J5T1m5AsONPe6w8EXYJSurUPpnQe1eC6DIEsFzi65ffPe4+kmFJRMOhXexkox/r/y5aUiof+C0qVsrg5mzzAzV5ggevQoBasR8pbcOToH8JTw6Q0AvTEmPlTu4SUrEdjWCriIsf4OdyauAP+K+2MWu9C14u6E+YnBkgi5uowHqNYHkdT7bPUrBoTtL7gq95QjE7xjqmeQ8/gVlEulYIKBrGqo0l2c7OIr4LhL42Vnh60CNeU6VqtWrjqwbxcS96QP7gRz2bZ3nfQffk4Rjferpt34bhjQmc9S8uJrUzzGHaBo5m9kMJZrPithuelcaAzO9ECX00v0p49zyqeVEg7xlbaWvm8xmlyfQkQV5MLZ2JgdHg1CL+PMzVCCt3P7jE5COHSagPMeVPpykznDEmO2q1EP9huGV+jfVCUVRXtkDSchOE2i9qpVzi cbqdDxCH Z9+6V2VJAzhwxQrX1FAap8+NT1IdHz1+ZxbPOV+YPhe+tTVu1hAdLjTYqhAPxfelUU8y89+NGW3n78n9Wd2LN4VVlmvWvHC7RsgRg7AzG2O062FA12A1om0kqwY9BKi2y6GgbkCbCKUpLg+Jxl0LfK5kZpvfyJnHVbjRvsUjCLHNicuQ7cYQSEvcv95Bdx6AaTZgPoqvXaw60R7EXir7/hrF0elx7DzPXZBzgr6pRYSHMYyKKzX3Zi0ACO++3ay5nE4wOiJ8obF0uSZb0S7pFKNBm4gQO3wikxEi6WhG5nAiFqGCisxwp17FraRH9CpR4BrYIYd21jdGg/HIZB63nNyHh5rjuKvva1b11zPi4z19AKg2h7ZBpSzzRzp77qRBv3WjmYeiPzaQi28GEESVyYjXCfrolmccOF9thAb4XM11btJ8NiP1cznRKKgxP3IBpKPHSXLwpkpQI/eciO0j4LBMNAQerXdI84ZFyYOfGZaDceXQJPRowoqpQug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 16, 2023 at 1:52=E2=80=AFAM Mike Rapoport wro= te: > > From: "Mike Rapoport (IBM)" > > The memory allocations for kprobes on arm64 can be placed anywhere in > vmalloc address space and currently this is implemented with an override > of alloc_insn_page() in arm64. > > Extend execmem_params with a range for generated code allocations and > make kprobes on arm64 use this extension rather than override > alloc_insn_page(). > > Signed-off-by: Mike Rapoport (IBM) > --- > arch/arm64/kernel/module.c | 9 +++++++++ > arch/arm64/kernel/probes/kprobes.c | 7 ------- > include/linux/execmem.h | 11 +++++++++++ > mm/execmem.c | 14 +++++++++++++- > 4 files changed, 33 insertions(+), 8 deletions(-) > > diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c > index c3d999f3a3dd..52b09626bc0f 100644 > --- a/arch/arm64/kernel/module.c > +++ b/arch/arm64/kernel/module.c > @@ -30,6 +30,13 @@ static struct execmem_params execmem_params =3D { > .alignment =3D MODULE_ALIGN, > }, > }, > + .jit =3D { > + .text =3D { > + .start =3D VMALLOC_START, > + .end =3D VMALLOC_END, > + .alignment =3D 1, > + }, > + }, > }; This is growing fast. :) We have 3 now: text, data, jit. And it will be 5 when we split data into rw data, ro data, ro after init data. I wonder whether we should still do some type enum here. But we can revisit this topic later. Other than that Acked-by: Song Liu