From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6F8CEE359 for ; Wed, 9 Oct 2024 22:23:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46BC86B007B; Wed, 9 Oct 2024 18:23:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41AB86B0082; Wed, 9 Oct 2024 18:23:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BB576B0083; Wed, 9 Oct 2024 18:23:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 102386B007B for ; Wed, 9 Oct 2024 18:23:57 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8EC4AC105C for ; Wed, 9 Oct 2024 22:23:53 +0000 (UTC) X-FDA: 82655492472.27.E6E3CE1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 91A064000D for ; Wed, 9 Oct 2024 22:23:53 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Wiwa3rlr; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728512607; a=rsa-sha256; cv=none; b=kxI/oOLvQvptqVj/XiBXzwBSWN7agvlB2tZwCT+3hElb24Ska4t0+fA65VBMn/+czp7sXQ s4ENirbgQV6mmxfu0n1y1p7GMEuqSpsEqDJv5lHBSj2GE4NVL+zb8gQTljg6CBFpoY32eI eeJGpxdszbpYHkIhqvHdCpCw1CRd58E= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Wiwa3rlr; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728512607; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qr2NiDkTzchL8uGJCnEfJucVtKgbESvAiwuQEhcXyhg=; b=kddR8kVioyrK0JKpqjE8OURpA1mVUb1NADpoP+tlZy9XpJUZTHZ2FLqd0SKrGLEUBjDpcV peK2ZV9FJPn1XgLDHu3cWLlv22aK/QKS4AnL/98FqIp/BlLyrgfdDkTIR+I8AxJU3ZhbYa jrPJveZh9+qZCkw+zFOTNA2mh/gZTcY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 526D85C5E81 for ; Wed, 9 Oct 2024 22:23:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BF5FC4CEDF for ; Wed, 9 Oct 2024 22:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728512632; bh=w4l9dzDzlilO4E+6HL//zAT4zhaj8ld4amfc5zECEfQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Wiwa3rlrYH9BC46EoCHkt+QLbJoTT1X2QA01HAqIYKjAte3oUq44GaeL+zZ4AkJ2c 2fmhTarWCgJZzvugjgiXFaapdrUxRw+aMHjQkxk7R7tMQ4X8TAISQfJF8mwZjkVS1k P8ckfmO9JeSeyS8x4lu0kJaTjkOtHpLIIPYKJmo4HQ1/9VWZa6uO3ff20ntiwcvv+8 WNsOi1fvz3WyQp8/mTsIKp1bTZX1Q46ddgghD/obeQF4nyOrExSGPC7njchLh/Wo1L w8uAfe7NKlqBlMlX1oAMsBsi5zUdQStu0GaxZpBZ0z6hB0R3qZA3l0SEImsa2B3CEC jNcMMmsZn1/Ag== Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-3a34ccc6a9aso1541785ab.1 for ; Wed, 09 Oct 2024 15:23:52 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVyezYRD1NmFuXdoTgqAgB04LWUo7DM716/MjgMlil3MkBk3qFX0CqLLuKRxrzlLguXNY0LLzoMMg==@kvack.org X-Gm-Message-State: AOJu0Yy/qCvo+Brm/Q5KgS+v7jSFPNTXQ0+/SUAa+IadOaK4/i03zTo2 XgGBJWOQnig21dtJIpvR2at9+nXUbrdZe2qs/DBEhgyUybVE4aJzP2+3AC+5Dh/l/K/mE/u8DVg JmndWQN8XaMDYaL18468HUU9HGLc= X-Google-Smtp-Source: AGHT+IE+0c/kMVosLTSGHy+n6QvIYJcOAn6W5BXDQkMmjF/nhxZwOJHSZ6SOjh26Vu9mUcUiW0DFRwoy/+Y0vdg6KQk= X-Received: by 2002:a05:6e02:1fe6:b0:3a0:aac2:a0a4 with SMTP id e9e14a558f8ab-3a397cffa21mr40549325ab.9.1728512631542; Wed, 09 Oct 2024 15:23:51 -0700 (PDT) MIME-Version: 1.0 References: <20241009180816.83591-1-rppt@kernel.org> <20241009180816.83591-5-rppt@kernel.org> In-Reply-To: <20241009180816.83591-5-rppt@kernel.org> From: Song Liu Date: Wed, 9 Oct 2024 15:23:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 4/8] module: prepare to handle ROX allocations for text To: Mike Rapoport Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 4epwsojwbzinyidcccf4hwhkxmh47nr1 X-Rspamd-Queue-Id: 91A064000D X-Rspamd-Server: rspam02 X-HE-Tag: 1728512633-630140 X-HE-Meta: U2FsdGVkX1+lMFRRvSBL8A+dlbbbzS/zQSNYXOdI3K4xuaVXLfiuM9O6DLUWnCRHRoHLtr/SOSooeZTVUexXK+g4eHQ5QjyseL/OJJr0Jc5I4TVq0F7hBd4fd84c/ww6FoVQb4fASMxy0YAPPWpQaN7/WOwEPXGZpN0C3As3IRNwfce7i+7IKUwTWgj1U8mFKVxq6hz9wrsEbmd+mAQWKBa9BdJcRWynptz5LgaxXpQ4KY70DmN/HXdOG+2WLD1fSBU6Dwcm5yYHLCYdf7FC2S1prOievgkgRUg12umxqZj4vIE2NcazLD5mepeOCiRtxDcHVAqI2dI2gyksua5123I0SsNnwLw+hmZx10REgHn34c/2MMlD4MJrBKY1G/LBFjgXFIqlUUrCp3lKdNgwuAAMTu8nL/O5FI7U2UKN399sd2YUFDKep2mvUvwy3pP2TB0KQ+QRGizkidVr6TUlWwS9W33U9Y10bzhVk1RLfz87eTorSwV/F1rqYC8wSnDC0O2TZEPk43pFxoGoaNPk4yo0yhn/Owqo9lL6YWP9/18B8dNWwmWoqWIQqaSEv7TRoy182SF18wyQzbVuFEIw1iCHr5F7mDyyUyWbVkWICPGEAD9PRN+wOsRpTHQQH78MGObdGgYo1EY2RD7eUUM5DhgsM9eoADP1n2PVaACYpOP9dKKxKfXR2hwnxzN9wD9SCAzTIUgusP9fA5mhR73SkvS5Sph9OwYu0G0W9YJGrzC6jnNbdScBmElX62BQ+fyxsEUUvaJ2DaG9t5rgeXuZfXwEeRX0f6OtfcREVCFYH7wnuMxH4BgiOXeHwmIIi4Qfp6aMxHiLYWMrBLWki8zOhocHEzD4U0OwjiEirrmfENBOSyoQ1l4YUqYTY2NbW24lAmtcX8lQ2FxcZ/B03Yj3DK7/ADanDetHI06Q5oUewO4HWQ5UdT+KFsAmAeX9zXjFn8juDJxJqBdBjcUBg6n Z+WJgNf7 tfccOKdTFP+0Vm1mcBUZ9v/xIU3kNgo78mqROcOEkSPPwWOiKu5iuMKF8sb6D53k60AXRxnxx7bb6EVO2EzRJsIPey6isGxPljW1pRI4F7jyjZDry4zCz+XpQJh/0MsiykJQ+x+nkw0/lkNRn/reE0RZVDgatGp3EdqFzWkEaWbzzLrW3+y/zx5unLsvI2FcR5VmXB5ifwj6LCHtz06lFgdTRBpV3wXdtfupDyyCEppUzNTBCy2KhU9GJ1F1ueHVPtQHWAHWmd9xeQItnGObDDuu1jZIAduenUkXmTU2tkokxEKPmpcMGhjWEfb2JCkfYNB8asx/y6BX9GW8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 9, 2024 at 11:10=E2=80=AFAM Mike Rapoport wro= te: [...] > diff --git a/include/linux/module.h b/include/linux/module.h > index 88ecc5e9f523..7039f609c6ef 100644 > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -367,6 +367,8 @@ enum mod_mem_type { > > struct module_memory { > void *base; > + void *rw_copy; > + bool is_rox; > unsigned int size; Do we really need to hold the rw_copy all the time? I was thinking we only need a temporary buffer when we want to update anything. The buffer might be much smaller than "size". Thanks, Song [...]