From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F102C7EE2E for ; Wed, 31 May 2023 04:58:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3377B6B0072; Wed, 31 May 2023 00:58:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E8F76B0074; Wed, 31 May 2023 00:58:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AF99900002; Wed, 31 May 2023 00:58:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 083146B0072 for ; Wed, 31 May 2023 00:58:38 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 924E416017F for ; Wed, 31 May 2023 04:58:37 +0000 (UTC) X-FDA: 80849344674.14.241F215 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id A209218001B for ; Wed, 31 May 2023 04:58:35 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NPRYthHF; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685509115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Acpk3D0vIaaSq7knQOSMcE5Zt2GM0cFl+HSZygJWetU=; b=LjtEsJyLur5P/WQPo2CVwTm+/ZWQp/j7m3yNYIm57gxGFKk58hym95H8LD+Rm+mut3m5c4 sbN72oPsHHMCjIYvqX1y5QvYIa5HWoKGnzXqtt3lprJdBByZeHfjX3d+JYVDRbsokRQeau jXgmRdUx2rFvMFLekO2q0nj+/6J1Jyw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NPRYthHF; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685509115; a=rsa-sha256; cv=none; b=RvCTcZI7zHyWHzG3YoOZXTKW9MRUus3TGLFM55m12EMbmg/ELQP57VJMsiSQUU9XQKw8Hu CVNxFsEjTp4+URYZ3UzjYlcsJj1+R4XUzjLcht6DxoGCZI3hEhxuLYsIg/i5tZOPjyfaRR Rr+V+VtHXfO1OiaogZKoubo4dU8F8Bw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 90871636C5 for ; Wed, 31 May 2023 04:58:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69ACDC433AE for ; Wed, 31 May 2023 04:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685509113; bh=JBZOocixWDLgxHtO8LMBV75DV/IkdmBnKFJ284Ve6Ug=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NPRYthHFV5Q6hvYrOD3SuDJ7bc3jcwirwiEVUlFtev6MSaaABYammq+Cs/uY0FO2+ vhBtr9eYwJ3UusESuVNNxH4jzwv4bmGi3n2ga+aQwysq5IoCZanBHAUOmVZoDthS2v MWZC+Cyot1N6yNLStBFyiY8AoWj7Q2T9lkJ+ZDOiQg3jALxHDgsLMtawH+N3PT9ePK eyL6em9yX50zt7h0E72+ENupjn+mfQwoS/Fyd1YuLD7fn4ly4rOsAqedCh2PPoNIn6 FKJKhjoLtemhKv4H2GPulhB7WA8ULvz23yGSyJJCGpRqNsUfydJII11BqJ6LnyRxu5 u1yL2U5/JtQxQ== Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-4f004cc54f4so6136018e87.3 for ; Tue, 30 May 2023 21:58:33 -0700 (PDT) X-Gm-Message-State: AC+VfDymzMhJbo7EK3kmawdCD4U/lD0bMMaie7vqO0HnryswVN+BNmzg r5ikwsaV6MALJ0tes8P9GwXDbC5agD5jqPdNKeA= X-Google-Smtp-Source: ACHHUZ7XDiYWJcs+q0AXYFH83FpH+4XZaAkwQNLTh6knjyPLIO1LGIR2Y7lAqiqnrlvTJ8gMp4sK/wzuHD8SIBdPb68= X-Received: by 2002:a2e:a28f:0:b0:2ad:9acb:4849 with SMTP id k15-20020a2ea28f000000b002ad9acb4849mr1778554lja.47.1685509111386; Tue, 30 May 2023 21:58:31 -0700 (PDT) MIME-Version: 1.0 References: <20230531042502.GM32705@lst.de> In-Reply-To: <20230531042502.GM32705@lst.de> From: Song Liu Date: Tue, 30 May 2023 21:58:19 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 15/20] md: raid1: check if adding pages to resync bio fails To: Christoph Hellwig Cc: Johannes Thumshirn , Jens Axboe , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , gouhao@uniontech.com, Damien Le Moal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A209218001B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: rro3ti37778zzrp3agidh4umtaak61h8 X-HE-Tag: 1685509115-943038 X-HE-Meta: U2FsdGVkX19M64uxkqotHDCHTCy6cHlwKW3urhQh1u14n6BfHhw+VbHlJHbabgVGzLADJM6OvF2FQDBzF8HQjkAgdgnWESA2w5vF5ShNTn3VRehOpMJF5qN1cct+PkQAPasC+cpeBYL0I/mtImLNVnif3S0brQxva2EuO07c369rFpmowyKEcY8FN0tmtyjE3PBLgU8smYKIcOiThNc13IABQVPthQFg7Y2oRk6ic4uisc2oNTFfR19t1gMBreuBDFm20Jark1Kf5xEuhm4IYMH3ztpH2ZQe5XSEJg/tm4qFYSmxAQlj5yZmJwEYH40lI6wTvKV9VBuxo9uxHlPNbAsI/7N6s/Bchuhp7PGCcSZbjUWfhuT+qJXIpNy7/1f9bKgbKEZTxOGFezmHodeMuwjxBm05N2V26uP0BNpSOAItiECFCJD4si4lXVdufD7pWt20ked+zeJINuheJORV33PtRHa7EJ6MdnK4rQ3/Z/u18Yb+1tioD8MYIsxwzyRAYRYq2PWePV/vJOwECZXiKUkwCFw+JdqwUhzckzV9Emxx36+qpyCWWORat2GOsuMN1rcF7sM4Iw7rFxnkfVZbybQEmFNQSRSB2BxkMPluX/tOP5pOYWV2JnQkBnoRBRwMTOCGfCz6PG+dpGdwjQafvbWcn/2pcz7RNW/NnGvPvh9JThJC2vqTlmihW3DORmdMuhZMv547ybnyeucIb2y166enizhsw6OKEJZ3oBm1yqOpU4dKUi9iJXKZ8qtqVGTFSOXscljDkXbTci48XJBPDGJ3hiuOUB7is0PgGtID18pcWTsxUw2n0/SdgQsTNO6cda+cagD5Y5ubq5TyLmY+MrIm41/VSiF/1p2XKJQPWkek5x++zf8j3XRu0lcAhuEwZSs4cjahQ8CIO7fEihSD0cb9M91Ci7C6uTMzxRTywoWbdxJvQOwb/f8ZCAjk0gQ/zIFF2eAaSl3+cvh80dz yuzeiv9o pMAgoQXOd+hj3BZ6+aRJLh3GB4hoHrtiCPg+2McwObGc/Q4vX2Fh9XAqt2Q3+275TUC+Z5hMlRxFJrCJRwzrZ8fHyUy/1ZkmvD2C60QUe9VQEmwvn1GHZptpDGXsZhnul3iKPp5XstECTOaf7nprWu6UbU+5Ol3svT5QEVSaCG6yjPEQOSN7tHz9mrhjyM7ULu842NWcQQmF/pNIhvqaaViLWDKdIOHi9gfmGM0e67N8xs5DROz4B0Gx/7tAYqhPtV5Dh62BaQiXVG6OyoUL6dhr2FLNb+GOdXA/kRRzlVkQZ2idlshDdYE0eB3ubznXA6Urf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 30, 2023 at 9:25=E2=80=AFPM Christoph Hellwig wrot= e: > > To me these look like __bio_add_page candidates, but I guess Song > preferred it this way? It'll add a bit pointless boilerplate code, > but I'm ok with that. We had some discussion on this in v2, and decided to keep these assert-like WARN_ON(). Thanks, Song