From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF202C7EE23 for ; Thu, 18 May 2023 18:54:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D62A900004; Thu, 18 May 2023 14:54:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68433900003; Thu, 18 May 2023 14:54:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59B42900004; Thu, 18 May 2023 14:54:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4D1B5900003 for ; Thu, 18 May 2023 14:54:41 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1176F1C77E7 for ; Thu, 18 May 2023 18:54:41 +0000 (UTC) X-FDA: 80804277162.09.DDD7EB3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id F2DF8160020 for ; Thu, 18 May 2023 18:54:38 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OD5NrdHw; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684436079; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iYxZosG8BtOYrGXh59PzQU54VXNPopHL75vY+dwiVcM=; b=rjeOGimxIc2/kgv5IdGJc0XcV4AvMAt0Q6Nh6maJjyRNjiNFYgyet8HXzk5ETQtQDUm497 tFq8v+8tLNQKXpDgcPufK7b6CcfexGu3EBu/KTnrhR3X4X96F9eOaS83jwSojwtPkF32Dz BeiLk5Iz4Jx+yfvw56kye4wiCD/xhpg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OD5NrdHw; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684436079; a=rsa-sha256; cv=none; b=jcq+xlAZsRMRH3MracTrdWBqKJfbaZTLuBt/nY0tvnjMPm9ldOHBaDN+VB3DRIg4t46N/w 0Wqld/7zjTAF9/3eGs9tNR+rJDuXMIfFzy+NDDfGnjRY2BDIHAahhBNtqIIW/3FITvAr7y HJfNGhG3eMBjnaB1+veWU+WMViNNDHk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B7D861029 for ; Thu, 18 May 2023 18:54:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AA33C433EF for ; Thu, 18 May 2023 18:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684436077; bh=tSeHM2j6YYE6eQ0ZjDsz94w5GR3l8DavaTLlPbhc2J8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OD5NrdHwvEf3BnD5mg99CS/15uplK/QF3paQ9C+SLkCMRtmw0TcqQqyWN/sgsntT+ Wf9gA6IhsBCoqvaqSTP+oxD51l+ATZ+rp0zdNk0O/LJeMDB6SZS7Z4chIihHq/R5zr XqlT2s8Y67+wQhbNPC+GLRPPTc7V7qcp8NuYB+d4nczWXY4k2y+8TOTUtTczbuJz00 d14rRtP+sqZa1dOW4IV5WpVY45+04HWhVv5QQBPD9ErtrZ7zNGwCO4aVQ7LdjyvRH6 oEGWp8eJOiYQuE1QEMp3f0bXe4ar88F2Q8ZGkaDLnPCW+t2rtxERYwF7qyl40A6HIi eniMRMbgArPPg== Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-4f383d6f2f8so2841092e87.2 for ; Thu, 18 May 2023 11:54:37 -0700 (PDT) X-Gm-Message-State: AC+VfDy3kc+p/B7Hlwq3yjxiUQon8rA9XAgUNaJ9J3/G5wTdRRrrxPZY 7ivqLkZ1Gd9zU1iMLlElidKjq3LOXptnzM+tHnM= X-Google-Smtp-Source: ACHHUZ5hNGUAql7F4iLvA6AejMOez0kLIougPttOSmgZJuTKMCgCBvbcFvUx4IUPbIfwuKe5NGHsnVlzd8gSMRY0R40= X-Received: by 2002:ac2:5315:0:b0:4f2:6817:2379 with SMTP id c21-20020ac25315000000b004f268172379mr62228lfh.23.1684436075613; Thu, 18 May 2023 11:54:35 -0700 (PDT) MIME-Version: 1.0 References: <20230308094106.227365-1-rppt@kernel.org> <20230308094106.227365-2-rppt@kernel.org> <20230518152354.GD4967@kernel.org> In-Reply-To: From: Song Liu Date: Thu, 18 May 2023 11:54:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/5] mm: intorduce __GFP_UNMAPPED and unmapped_alloc() To: Kent Overstreet Cc: Mike Rapoport , linux-mm@kvack.org, Andrew Morton , Dave Hansen , Peter Zijlstra , Rick Edgecombe , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 1pu7fobxjoazuifgjnwneihf84jupdb8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: F2DF8160020 X-HE-Tag: 1684436078-208310 X-HE-Meta: U2FsdGVkX18umJvtWBsxt5UO8/qfRlD1fJ4x3EEOlXLgJK/6esJvy+oFiaAboHocw6TF0gzP62lOW1Rv/dl9/zCjdR93OIFsaOH01Q4OzJgOO7OpvwMrWCHsM3Up268ZTWrnfsLjD/x2Eh/puVDEyBwb7gfYOr4iSH0qbLi2A/g7jHL9bhqIV3z+u9J7iHze9bKIluLo7ZvV8MD53Nl/M7lXnqs9afat7h8jfTkMjxYHtb4PgGqjRHKNU5KcQzU0WZNEyIqkDYb6loMpgKB23mtf3KMMGYB6dV4GZEYG8Bo6EzwZfX5G4G4uytHQVX2h/4V/FSQ9JrmDzZBz8Qc48kRP8ITIJb/YnYwjbhhJIJgWdoHZNsfU2FJSid6rXyDM+ndPPQGu5tsafpB0I+q/R7hifuwAjtEfAZDQJim6OsHHJeg7Oqpw3lJzeRGhw3R1KKaaJt2D/YcPRP5EpOTmOohxqBrjuQEs2EAlJEVNOoFGlNnr5U3J7yALMDhNC9J5IZPNxhEfTnYx88T9A5+2wetkrjXEkJi29EVH+8VNrEK9NGjP4b/r4kKg5/X/mLFovNRnNJndgNW2uwUYzS6/kzn9Wtma3kNc3uFbMx1OQecyjkytFAfazrw0hZKIB14RiMyAZUirwCjZwSQIwo/3Af1CRkNDMhsiXknn4j7p3VEtmI+S6dMSs4jYawxeDk2bI6Bx0BDyAuaDccdU1l8o3NUbaoIioxgF7mV5S8JW1dhIXpHJShrnK9XdvRhBKwWMw+1ait/nD6wafCh11Sw/3Hf7KsohSLSXYQRkP6s9GHkw8SnTqjJj/kziCuGaUuL1+GJlcdYcffse+JVmpO/dn927iaRcZTKnRiku01+jCZIEhUQ7/RRuuj4SLZ+ZVG/gd7EsP6tddwS6dylZFDCKhuEyksxNAfNg83ARSpyI7HNmbHMkRHb69dP+mRL/75BhuHwkuKtD7uXv63TgEpd D1FSEha6 mSyPv2bj1fznXBDoxWz4RPnJw6Lw6aA+DvkQLkzwbsg7NlTfOdn86qN2klQQB5+NmspXQIHvQqY6NE9z8ELUdewo4rCVNkdv/KfhA7eq+RjyoIriQ4EOBpBRmzOHGye/fHcfUddZz5d/g9wdwArlNLpgWTfsYO66PM6E/8MkU842zBboncSeYENz1h+wBw6ty0YrRPcWDKegihurKydIAAMtqRc/yOpSnt99NzBnboe1Wy9f7KKnJXcyHzARFFbl3UjDCDPWZLtLWnTbpf+HfhrvpcvEqi+XsC5jXw96PiqfYUsw8D+vtJI02yRQkYPkehBwGXzvwqR4HTmZ9SMhCG3wEpPIb1RZ4xVNjgezC6bCykWE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 18, 2023 at 10:25=E2=80=AFAM Kent Overstreet wrote: > > On Thu, May 18, 2023 at 10:15:59AM -0700, Song Liu wrote: > > On Thu, May 18, 2023 at 9:58=E2=80=AFAM Kent Overstreet > > wrote: > > > > > > On Thu, May 18, 2023 at 09:33:20AM -0700, Song Liu wrote: > > > > I am working on patches based on the discussion in [1]. I am planni= ng to > > > > send v1 for review in a week or so. > > > > > > For reference, here's my own (early, but functioning :) slab allocato= r: > > > > > > Look forward to comparing! > > > > This looks similar to the bpf_prog_pack allocator we use for BPF at the > > moment. (search for bpf_prog_pack in kernel/bpf/core.c). I guess we > > can also use bpf_prog_pack for bcachefs for now. > > The code in bpf/core.c does a _lot_, my preference would be to split > that up and refactor the bpf code to use something generic :) The code is actually splitted into two parts: bpf_prog_pack_[alloc|free] vs. bpf_jit_binary_pack_[alloc|free]. The latter has logic just for BPF. But the former can be reused by other users (maybe with a little refactoring). Once the vmap_area based solution is committed, we will replace the former with the new allocator. Thanks, Song