From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92464C433F5 for ; Wed, 29 Sep 2021 16:59:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0891661425 for ; Wed, 29 Sep 2021 16:59:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0891661425 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4F42B940046; Wed, 29 Sep 2021 12:59:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A3FB94003A; Wed, 29 Sep 2021 12:59:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3931F940046; Wed, 29 Sep 2021 12:59:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 2B1F894003A for ; Wed, 29 Sep 2021 12:59:54 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E1AB81807B522 for ; Wed, 29 Sep 2021 16:59:53 +0000 (UTC) X-FDA: 78641223066.11.48DD4C0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP id 8BA901910 for ; Wed, 29 Sep 2021 16:59:53 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A3FE861465 for ; Wed, 29 Sep 2021 16:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632934792; bh=EM1oXwkdc2lgGvdOkjq5hSe3UNtKYKWdDP9Ix+9b/d8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Hw9faFeP3SZ4O3q6uU8evzRoqbXelSlG+udiY6EiEmvgypoUXGn06h176v3DHiZTs wyOfCsQTIaIGevL/hdXJcn59i2o7wOw/CGpR44U8cJonHrLzwTk2cHowVWru9G9L9q ip4GpkiNJ+wIR6GSPngAD1Al9rYCvmXP+6tZlZbJD8CVG3wQIuZMk4KS5HpuJIhBjR OSqxHZw4hnglfs+AG0cy+KopN+mskmwPLosXEo6rEOPUFZC0BkCqbKu1Zcm2U4P9Wv n7hzJQOAxvMT6NiaJ4RIn6xg1kCzwQ/E8uNmBaWQkExI1e9ebonFyNx32sQlEYm4nK NEIY76dRTRaBw== Received: by mail-lf1-f42.google.com with SMTP id m3so13353356lfu.2 for ; Wed, 29 Sep 2021 09:59:52 -0700 (PDT) X-Gm-Message-State: AOAM531ZNe6HN2HAT7TnM0a17KsYxmD+hbnyFkgQUVU4r26+wF7n+jxz gPxL5ArSFcxpnVnTdMHms5e6vmcM1ZSqERByyo0= X-Google-Smtp-Source: ABdhPJw7hQ1nuxxV8XvyPSjdABcYtydwuRR3hMTfgc+jtUjuq++mjj2jboz18aXRR16M79QbHWzcj6v8qymZOr/YAIs= X-Received: by 2002:a2e:321a:: with SMTP id y26mr1031724ljy.234.1632934789801; Wed, 29 Sep 2021 09:59:49 -0700 (PDT) MIME-Version: 1.0 References: <20210906121200.57905-1-rongwei.wang@linux.alibaba.com> <20210922070645.47345-2-rongwei.wang@linux.alibaba.com> <20210923194343.ca0f29e1c4d361170343a6f2@linux-foundation.org> <9e41661d-9919-d556-8c49-610dae157553@linux.alibaba.com> <68737431-01d2-e6e3-5131-7d7c731e49ae@linux.alibaba.com> In-Reply-To: From: Song Liu Date: Wed, 29 Sep 2021 09:59:38 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] mm, thp: check page mapping when truncating page cache To: Rongwei Wang Cc: Andrew Morton , Matthew Wilcox , Linux MM , Linux Kernel Mailing List , William Kucharski , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8BA901910 X-Stat-Signature: 99cho99he1j71s9kpg1x15rbqb715rw4 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Hw9faFeP; spf=pass (imf22.hostedemail.com: domain of song@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=song@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam06 X-HE-Tag: 1632934793-280929 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 29, 2021 at 12:50 AM Rongwei Wang wrote: > > > > On 9/29/21 3:14 PM, Song Liu wrote: > > On Tue, Sep 28, 2021 at 9:20 AM Rongwei Wang > > wrote: > >> > >> > >> > >> On 9/28/21 6:24 AM, Song Liu wrote: > >>> On Fri, Sep 24, 2021 at 12:12 AM Rongwei Wang > >>> wrote: > >>>> > >>>> > >>>> > >>>> On 9/24/21 10:43 AM, Andrew Morton wrote: > >>>>> On Thu, 23 Sep 2021 01:04:54 +0800 Rongwei Wang wrote: > >>>>> > >>>>>> > >>>>>> > >>>>>>> On Sep 22, 2021, at 7:37 PM, Matthew Wilcox = wrote: > >>>>>>> > >>>>>>> On Wed, Sep 22, 2021 at 03:06:44PM +0800, Rongwei Wang wrote: > >>>>>>>> Transparent huge page has supported read-only non-shmem files. T= he file- > >>>>>>>> backed THP is collapsed by khugepaged and truncated when written= (for > >>>>>>>> shared libraries). > >>>>>>>> > >>>>>>>> However, there is race in two possible places. > >>>>>>>> > >>>>>>>> 1) multiple writers truncate the same page cache concurrently; > >>>>>>>> 2) collapse_file rolls back when writer truncates the page cache= ; > >>>>>>> > >>>>>>> As I've said before, the bug here is that somehow there is a writ= able fd > >>>>>>> to a file with THPs. That's what we need to track down and fix. > >>>>>> Hi, Matthew > >>>>>> I am not sure get your means. We know =E2=80=9Cmm, thp: relax the = VM_DENYWRITE constraint on file-backed THPs" > >>>>>> Introduced file-backed THPs for DSO. It is possible {very rarely} = for DSO to be opened in writeable way. > >>>>>> > >>>>>> ... > >>>>>> > >>>>>>> https://lore.kernel.org/linux-mm/YUdL3lFLFHzC80Wt@casper.infradea= d.org/ > >>>>>> All in all, what you mean is that we should solve this race at the= source? > >>>>> > >>>>> Matthew is being pretty clear here: we shouldn't be permitting > >>>>> userspace to get a writeable fd for a thp-backed file. > >>>>> > >>>>> Why are we permitting the DSO to be opened writeably? If there's a > >>>>> legitimate case for doing this then presumably "mm, thp: relax the > >>>> There is a use case to stress file-backed THP within attachment. > >>>> I test this case in a system which has enabled CONFIG_READ_ONLY_THP_= FOR_FS: > >>>> > >>>> $ gcc -Wall -g -o stress_madvise_dso stress_madvise_dso.c > >>>> $ ulimit -s unlimited > >>>> $ ./stress_madvise_dso 10000 > >>>> > >>>> the meaning of above parameters: > >>>> 10000: the max test time; > >>>> : the DSO that will been mapped into file-backed THP by > >>>> madvise. It recommended that the text segment of DSO to be tested is > >>>> greater than 2M. > >>>> > >>>> The crash will been triggered at once in the latest kernel. And this > >>>> case also can used to trigger the bug that mentioned in our another = patch. > >>> > >>> Hmm.. I am not able to use the repro program to crash the system. Not > >>> sure what I did wrong. > >>> > >> Hi > >> I have tried to check my test case again. Can you make sure the DSO th= at > >> you test have THP mapping? > >> > >> If you are willing to try again, I can send my libtest.c which is used > >> to test by myself (actually, it shouldn't be target DSO problem). > >> > >> Thanks very much! > >>> OTOH, does it make sense to block writes within khugepaged, like: > >>> > >>> diff --git i/mm/khugepaged.c w/mm/khugepaged.c > >>> index 045cc579f724e..ad7c41ec15027 100644 > >>> --- i/mm/khugepaged.c > >>> +++ w/mm/khugepaged.c > >>> @@ -51,6 +51,7 @@ enum scan_result { > >>> SCAN_CGROUP_CHARGE_FAIL, > >>> SCAN_TRUNCATED, > >>> SCAN_PAGE_HAS_PRIVATE, > >>> + SCAN_BUSY_WRITE, > >>> }; > >>> > >>> #define CREATE_TRACE_POINTS > >>> @@ -1652,6 +1653,11 @@ static void collapse_file(struct mm_struct *mm= , > >>> /* Only allocate from the target node */ > >>> gfp =3D alloc_hugepage_khugepaged_gfpmask() | __GFP_THISNOD= E; > >>> > >>> + if (deny_write_access(file)) { > >>> + result =3D SCAN_BUSY_WRITE; > >>> + return; > >>> + } > >>> + > >> This can indeed avoid some possible races from source. > >> > >> But, I am thinking about whether this will lead to DDoS attack? > >> I remember the reason of DSO has ignored MAP_DENYWRITE in kernel > >> is that DDoS attack. In addition, 'deny_write_access' will change > >> the behavior, such as user will get 'Text file busy' during > >> collapse_file. I am not sure whether the behavior changing is acceptab= le > >> in user space. > >> > >> If it is acceptable, I am very willing to fix the races like your way. > > > > I guess we should not let the write get ETXTBUSY for khugepaged work. > > > > I am getting some segfault on stress_madvise_dso. And it doesn't really > > generate the bug stack in my vm (qemu-system-x86_64). Is there an newer > Hi, I can sure I am not update the stress_madvise_dso.c. > > My test environment is vm (qemu-system-aarch64, 32 cores). And I can > think of the following possibilities: > > (1) in thread_read() > > printf("read %s\n", dso_path); > d =3D open(dso_path, O_RDONLY); > /* The start addr must be alignment with 2M */ > void *p =3D mmap((void *)0x40000dc00000UL, 0x800000, PROT_READ | > PROT_EXEC,MAP_PRIVATE, fd, 0); > if (p =3D=3D MAP_FAILED) { > perror("mmap"); > goto out; > } > > 0x40000dc00000 is random setting by myself. I am not sure this address > is available in your vm. > > (2) in thread_write() > int fd =3D open(dso_path, O_RDWR); > p =3D mmap(NULL, 0x800000, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); > if (p =3D=3D MAP_FAILED) { > perror("mmap"); > goto out; /* fail */ > } > > because of I am sure the DSO is bigger than 0x800000, so directly map > the DSO using 0x800000. Maybe I had use '-z max-page-size=3D0x200000' to > compile the DSO? likes: > $ gcc -z max-page-size=3D0x200000 -o libtest.so -shared libtest.o > > If you don't mind, you can send the segment fault log to me. And I will > find x86 environment to test. I fixed the segfault with 1. malloc buf (as it is too big for stack) in thread_read 2. reduce memcpy() size in thread_read. Now, I am able to crash the system on find_lock_entries () { ... VM_BUG_ON_PAGE(page->index !=3D xas.xa_index, page); } I guess it is related. I will test more. Thanks, Song