From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A180C77B7A for ; Thu, 18 May 2023 17:01:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D68F9900004; Thu, 18 May 2023 13:01:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1839900003; Thu, 18 May 2023 13:01:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C06D4900004; Thu, 18 May 2023 13:01:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B0BAC900003 for ; Thu, 18 May 2023 13:01:36 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9F6C6140889 for ; Thu, 18 May 2023 17:01:33 +0000 (UTC) X-FDA: 80803992066.24.BB18AD8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id ED0E2400BA for ; Thu, 18 May 2023 17:00:55 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=i1juZWv4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684429258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sCSVMW5kMTxYSaFkH40XHeC5n90U6Hx/eg/xMtGfKDo=; b=ExDe7yKCvUkQgLQDjxpIqrUBicH9j+UjBG5+zJXeLYNhLBTNuUUQQS6CniAxuA7oBmNwXy oZ/jyyVvxKvhTaqXCWzI47Rd3d6xnieVn3dX1o4eGkw0i155PszpBNb4iAavJTMOyWrRkD 9b9b/UsthvMD3TKpNd8BzP5xpkiRtY4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=i1juZWv4; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684429258; a=rsa-sha256; cv=none; b=VtQrdUnNqBu1zDflmDz4BDwALDpVozj/rrsjUw8TU8HMZ24xDhj4vVsN/Mcus6U4YAy5mx oL/X01h3P/z7LosnLIGrjNFziRcT75+/tItoOyHptOz6Ztrue6ATBY5h6nPzi0srzLXYOX 5nc4vjUhWUi0ae2lRV4yYwkyOCllCmM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AAA02650EA for ; Thu, 18 May 2023 17:00:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19FD7C433A0 for ; Thu, 18 May 2023 17:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684429254; bh=sCSVMW5kMTxYSaFkH40XHeC5n90U6Hx/eg/xMtGfKDo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=i1juZWv46pB3m27CQOX0N7Bw8qKT7bUAmyk8Kmr8u9NJyCwjm/iH0dyJrK01uHy7u EGisgfrv7Bt1pqQCSSpis5nHZ74oA8hzkE8oEvFvrcnRiUKbAk1QtNcZ5ntXKwJyCG F6fK9TCC59OjOlsRuiSWeii2ZNC18FceEfUzNjmzmgYmmZI3Bm5/bJ3au7tlb8KIHK yzrNf4FiM/MmzOW/RhqeAfFNIFEJkNER3WG4R4PuMyvS8Ekl6KyHWoMYdMF8ftc7fw /DVaK9vGrioLNvretdjUk4JTFKx6Xo7bM+XFrdk2tagqodI3S+0+MO7I7CjMOHwDxM XpyribiI6QHxA== Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4f383d6f2f8so2711497e87.2 for ; Thu, 18 May 2023 10:00:54 -0700 (PDT) X-Gm-Message-State: AC+VfDzErj7vSDgMr3uVZvdGhEYXlzB1gI+rmuTaLwqczqf4T7LtCYw1 d/CKREDKZw0JzSSvZKhv/uuvhP4Yac9a7h492zg= X-Google-Smtp-Source: ACHHUZ675aHp+CW+nkRJVt7JHNZZHL2+M+LrcNBRb35yggvsg9ZQbp5WjjCRKHHtBlMjWzQlYXwTCFAS5Bpua6P4HF4= X-Received: by 2002:ac2:4575:0:b0:4e8:5576:98f4 with SMTP id k21-20020ac24575000000b004e8557698f4mr1296585lfm.45.1684429252015; Thu, 18 May 2023 10:00:52 -0700 (PDT) MIME-Version: 1.0 References: <20230308094106.227365-1-rppt@kernel.org> <20230308094106.227365-2-rppt@kernel.org> <20230518152354.GD4967@kernel.org> In-Reply-To: From: Song Liu Date: Thu, 18 May 2023 10:00:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 1/5] mm: intorduce __GFP_UNMAPPED and unmapped_alloc() To: Kent Overstreet Cc: Mike Rapoport , linux-mm@kvack.org, Andrew Morton , Dave Hansen , Peter Zijlstra , Rick Edgecombe , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: ED0E2400BA X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jp71h1wqye7zo6o34winob5stiebjoz4 X-HE-Tag: 1684429255-559945 X-HE-Meta: U2FsdGVkX1/ogwo0/02ydG9pZDV4s4tLoZzFRg4CtWn9eXBmJNUGMG9qsYii5f9yIhEPDpgYTAUIhN+r5KqbHg22MvKJRfAP5vXxeV+hXmuLBg5Z/eVth+tjOQ2x4xzVEaXSYOARXdLVgWvv3KNuDbdXbZS1/sTrGGy30owaaoWnSKy7hxf0HuTXxTnwCrQcTCgExzOZHpBmBBovd6FbxRoE21ci3kV6AqxBUstJGY7UGYLKHqB9QmU1nfT72CQk+wtGPXgqRnyZKCSFmdiqikDK2U7se2dA8p6kgaCLaFUjgiphkrm0DFSpwqO2h78lAMHdwR0aQcSrEQI6D9KBNnYltbikQoOp5/houTBUX2KYVBIyCboahaJni/1atqaPLnfHLl0IP2GJs0N9WJYJcOKd5dZQlYRdKDx7OAqpTRBrz/dF3SDzl5m6R7pdxRz4u1VNlKxOV7aSpIhd3Ftg7mTdayBH5kiynuRRbwJyoSqDbSXssKNv7RueW4swbgPxoRkCdSmOBogxzFQtWUI9jeFoRpzRzKvK4FzYPpflmUZBxZCIoBeJh3BuSLD5c6/ELx3t4/5LmCshbXPeouWi+s5fNq1dbQthXarmUZSBulIw/pKIhoFuXIbf+4gcPRqYB+vwxVaTMkaeKQSbgrl04ZZJBQjIEtd5agjJCnhlV1Q20BEOzznY5xGyZ7aJbd1A5Rt8NDBUPbjYBwQOhbRmb09NXBSow53tkZMOralcUaQIYuM9+ZuQ06SOReb0sn0enOaMGC96GrUYG9KCsi8xYa3AKu0zXR7Nf2twMcJJAAgLliC5nYxr46soZLlAPY9e8GwdFo42pZt5WrbNcPwneEr07JMhCuz8xmNToyinaf3RP2GhjrIjOj810X73DqsfX1M0aPKD5oOq/DFu/WxBOV3oApAMMD2DImdsn1MiAVK6+PAU2KqsNenFYq+n+uhBpyFJPCM4EKDq09aaTMg 1QZEECPn BoGKEhEfyMUpWQ41PcibfncjtnH8QW1mjFe6PLh16JkMxblfxM74l+ojymKdUu20mM3Z+qZu+Qkkh0tdsUsZV1ctIvVroWE5sepCvkOVpBwcUW4e8AmF6ku1ytjH/ctaPc1LQpXOVCQuR0FON85HJU1ov+MhVmzGNotTSUPjH5vaLzKK38gRdkRExcgrPJeA9pMs/cM3E/a46N/TS/G2gZAguAAOeRGgLgO/qJLaMe3a2bRrcABW/lf3c/IayPd5fQBdcrR4JSz7wznfIpWC/+vNaWsoGX52AdHdh7qppY4PSjvO9XpPT5axjntEW22f7shm0wc1XIttU6iHbPJOLg4CX8fE/S2qCaELmeg423eqgS87nlyXoEP9SQ+MMzOAMTVKonSep2BN6QZrIJHAJlTUXLhb2z2XasPFIKiPHud1F/TM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 18, 2023 at 9:48=E2=80=AFAM Kent Overstreet wrote: > > On Thu, May 18, 2023 at 09:33:20AM -0700, Song Liu wrote: > > I am working on patches based on the discussion in [1]. I am planning t= o > > send v1 for review in a week or so. > > Hey Song, I was reviewing that thread too, > > Are you taking a different approach based on Thomas's feedback? I think > he had some fair points in that thread. Yes, the API is based on Thomas's suggestion, like 90% from the discussions= . > > My own feeling is that the buddy allocator is our tool for allocating > larger variable sized physically contiguous allocations, so I'd like to > see something based on that - I think we could do a hybrid buddy/slab > allocator approach, like we have for regular memory allocations. I am planning to implement the allocator based on this (reuse vmap_area logic): https://lore.kernel.org/linux-mm/20221107223921.3451913-2-song@kernel.org/ Thanks, Song > > I started on a slab allocator for executable memory allocations the > other day (very minimal, but tested it for bcachefs and it works). > > But I'd love to hear more about your current approach as well. > > Cheers, > Kent