From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DF0E7D0AB for ; Thu, 21 Sep 2023 22:34:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EA926B026E; Thu, 21 Sep 2023 18:34:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 173566B026F; Thu, 21 Sep 2023 18:34:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03A426B0270; Thu, 21 Sep 2023 18:34:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E66966B026E for ; Thu, 21 Sep 2023 18:34:36 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B552EB305E for ; Thu, 21 Sep 2023 22:34:36 +0000 (UTC) X-FDA: 81262060152.12.5EAA63A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id CB00E120004 for ; Thu, 21 Sep 2023 22:34:34 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mfa0wr7Z; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695335674; a=rsa-sha256; cv=none; b=0kKt41xhQNQD2YtgrsC2j0YN4GiFG6B8LV5gLLpZLVAh/WYzzrrqZFn+4rDUrkC8BrCPa+ I9qU9Am6VmmIv0A36DGVTJMJ7HFMVNByrL5Ki40meuhmPpAOeCFUGJb45X/NZat4InYfJN g9FyS/g6Vgvv66Ahqdo8Qq0BAIMnrFQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mfa0wr7Z; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of song@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=song@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695335674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BYmc+5Z1d3gETvzBA6uUCzub3QPVVnay5rzsMEs5J6k=; b=ftnSJHkuk5lr0F4Q2Wiec0nPkqVtVSsZFQfcH5/7FuBUb53jJ4/WQ1aDqhDQnuApRniQDG mLPoqNNQEXvrQ+RAUEnl6Z4xwQzDoLvO/Y+MHq1gpGlHjZFVbdregk0u7Nwp07eYDi2zWm fVcEP1SlGUugx2LithiKf/azA6xkIOM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 076A662103 for ; Thu, 21 Sep 2023 22:34:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A83C3C43397 for ; Thu, 21 Sep 2023 22:34:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695335672; bh=fncpICFIZJhs+CFipAysf+2ViMsb5Ntfqci2xnszhTI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mfa0wr7Z0lJ3IA4HjAqOtrk9SSrWWB+YGbaJc16KYeVVOnawrEHs3dy+iDauvghvS XAHLDo1Oga4nzW8Yi1caKnTTFJMqd7AtLKV54l/hFjnIDnOa7YaUJG8OwSNQt6PDO1 7A+xKgOCxHubIbnNN8HZ22TUVPtwpthTbmR6DHRJsZoaCg1nFEuNlqOAO63MKUXx9I SVjAKnxkUVKeWQXgqE8UM2tHBIJCB/eo8eJdbedgXyDGRo4W6Xudl4FTLuPEDPrLWB k28dHj46DhheR/Wrwnz4X+g5x8ZjJWpuI68P2lkJi7EwbKR/MM3KSc5SviEdI3D0pl RSPtrB9bT5Klg== Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-502b1bbe5c3so2475988e87.1 for ; Thu, 21 Sep 2023 15:34:32 -0700 (PDT) X-Gm-Message-State: AOJu0Yx4FECHZvdLKnxYX4KwEhnJK9ENIqkxVkyPGtSEwTZhA69OA9Ay FSQXrRfD2LxiQacKAdnv/qU9jINpT4KsDUw8dd8= X-Google-Smtp-Source: AGHT+IFZJtrM0/Sc4i9G46WkcXtuEGlwSrtGZZ9iCEr70spXydIPXGtt7clCqr3CvwCB3MyRIs3nmXQD2zetfl7/+As= X-Received: by 2002:a19:6445:0:b0:503:3446:8ef5 with SMTP id b5-20020a196445000000b0050334468ef5mr4362567lfj.10.1695335670837; Thu, 21 Sep 2023 15:34:30 -0700 (PDT) MIME-Version: 1.0 References: <20230918072955.2507221-1-rppt@kernel.org> <20230918072955.2507221-3-rppt@kernel.org> In-Reply-To: <20230918072955.2507221-3-rppt@kernel.org> From: Song Liu Date: Thu, 21 Sep 2023 15:34:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 02/13] mm: introduce execmem_text_alloc() and execmem_free() To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, Andrew Morton , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Catalin Marinas , Christophe Leroy , "David S. Miller" , Dinh Nguyen , Heiko Carstens , Helge Deller , Huacai Chen , Kent Overstreet , Luis Chamberlain , Mark Rutland , Michael Ellerman , Nadav Amit , "Naveen N. Rao" , Palmer Dabbelt , Puranjay Mohan , Rick Edgecombe , Russell King , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Will Deacon , bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, netdev@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CB00E120004 X-Stat-Signature: zwxax83hpxeduobwrh6yepc6to81w4yd X-HE-Tag: 1695335674-745208 X-HE-Meta: U2FsdGVkX1/vN7cpv+v6Bn3Vc4S+i4y4GFSf63xiW1Y5H9KLjV9QeOzmBxGMr0SofP4OXBMXCCnimjiMWbbM+bD9atTsgIENV7D4qdiFTrQKQGzf8W5SsWOV6u6V5p4WPLs4oJGmlcDuYA3/mEqPouQjQxCFkuG7mB+dUc3dAKcgx3nS/8UxgCMMVrHttJjstN5rC/Srjn4X236DBlOlv59cX0+kdPrNfkPOjm/XsjIVg+/VAEb91nzmS6A/BkIW9wi19vJjZNsR4VSII+F0gy7WLnhClX6rIFBVJyio4+8VeL1Bf/Ox65YszUEXpH7gT5TN5x+PqaqeR0GBVVU+qF+SqWaY5T285oONkvDSN1lwHY8IEcZNPnxdx6PqDBJFdhb5j+zswIPyuBxC5twndbPMy3WLn4nS2C8d/cYy/OJ8E/+FLkuCzB7iP4aBMJUaTCfYq7KXC8stzM+Wo7OQ9r7lk+5V+sSdifu0P/wv02gvOpiIONHyord9mtdL0gjbsBAANt1EJKy7LMhcjx5RPi+oxgmDdRvTCzMU2OlgzrYweBrmY6VYNLhsf50YQq0KElTNn+TmxKwDX5z7CKqHvCodXT6SxCBFWJfrElBSvs/yRepqE//GVumyxoSh27MUo5bxoTjOkgKwr9eDEEoJ7l6Ip5RFtk3VTmHc16IG6IXgkI+i9xejE2Y7ZwGEJ14KWEqlfDfABreImCzeVkqphhfKSaW87AkjX3V8zYZG0aXpoHfIOIJIcFI88OEJMcmq/yzMYswrYe9KWxc518ZRblt7nagIY7RW/xBfa9KYktgvkt538Nrael8QZTKpPo/arvCe7rtfNX76dw4ux2yB7582gdFrKsIpZ9kXjEfiUq06r7ZvBfDO1MmiF7LtiYkKuHAQdIPPnEP/TLmCIyCi0cZni9VZZORH5yr9xuUX9ByXt+vmE76g8reGMVU+0uxW35We2C2qhLJtoQeNOdI V6wD6AYa Nkyxy/0t/Oc4X8FaL10jVuRAY4IJzL5VWfLiX4y+pr3qWcdrMoYODGglPHiTqLOxSEyuMnc1F6YdHl8EhMKlfljzSeN+ybGV/EagvrhJx6Ft6mxl+UorR8WaY37lIpA30BOJIkROzhZzV3WQFfF4UyLtcviu6csRdZlCD7XG+mUyVbLnSdRKAF+ni+WSD6TFqflgr1W469Iio/n7tCeE51GiBZ4di/YFXsUmv/EV2/g1G70+rSmojGK/0vMoWme8Oum0pnUoKzowNQSaj2Fk35474NGgbi1v5/1sq1QNUdUTRaZBFvNBrgV8O14mqneVM5bt/ZazuycOvF7BvYHlnWRmVMuG3IeS9HwVleW7QFgrPhXCE8Q4dpfKipW84K7ruAo+bw/gtB6Wi5l44KyJuLJem2e84nyiPy3uzzWOEGejeoZ5ncqrMNjgeZMYtIe20BFISX4zpVFOPIj4naf7QDPayXXM/yFA6Svvu7yC4bTOkWmXYpLP0L2ipXtxWB7BOBBi6dHZc2jdPsurxGjCJ2YUSpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 18, 2023 at 12:30=E2=80=AFAM Mike Rapoport wr= ote: > [...] > diff --git a/arch/s390/kernel/module.c b/arch/s390/kernel/module.c > index 42215f9404af..db5561d0c233 100644 > --- a/arch/s390/kernel/module.c > +++ b/arch/s390/kernel/module.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -76,7 +77,7 @@ void *module_alloc(unsigned long size) > #ifdef CONFIG_FUNCTION_TRACER > void module_arch_cleanup(struct module *mod) > { > - module_memfree(mod->arch.trampolines_start); > + execmem_free(mod->arch.trampolines_start); > } > #endif > > @@ -510,7 +511,7 @@ static int module_alloc_ftrace_hotpatch_trampolines(s= truct module *me, > > size =3D FTRACE_HOTPATCH_TRAMPOLINES_SIZE(s->sh_size); > numpages =3D DIV_ROUND_UP(size, PAGE_SIZE); > - start =3D module_alloc(numpages * PAGE_SIZE); > + start =3D execmem_text_alloc(EXECMEM_FTRACE, numpages * PAGE_SIZE= ); This should be EXECMEM_MODULE_TEXT? Thanks, Song > if (!start) > return -ENOMEM; > set_memory_rox((unsigned long)start, numpages); [...]